From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 902E6C27C53 for ; Fri, 7 Jun 2024 08:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:Subject:References: In-Reply-To:Message-ID:Cc:To:From:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=yuHDFUh6qaUECndUqyCi9Pnq8mMEh2Pg9wr/z7B2xls=; b=XuB7ZXnPAZT7YfXd8NrwtXCj0H qaLXdaJ23iuCeJGWnm8r75b74Xt8rW99x8+18xm3/lj+eblAv9RFfO9lGg/gsfmYAKTHhcuKPf/Nc J9p+8aLFG7jAaxVrEo/q9Q9k/xhrJU/1rzuBnzxRkoB/xk4xo6xIuoCAX+r9GP5Puc4uQmbu+e8CV S1eevbuY+C6vasFAu22AhvD1eEwcBj4EAGc0LduuJGtF0lIUoE97J7dqEjPG5Kxwj+Iu2uf73vEds qIHz8YDKzSKhwUWFhqMYn7XfYRIXdevEmCek7vEr1UFeOa1kC3KXcpjgrH2wRFD1s6y5vsYLND06t wNSLqRWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUal-0000000D3TL-3NDM; Fri, 07 Jun 2024 08:04:55 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUai-0000000D3SY-1pTf for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 08:04:54 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a68e7538cfaso226919166b.0 for ; Fri, 07 Jun 2024 01:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717747487; x=1718352287; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vHTEB/VzVlwsDqiMfVQQnNEOGkiSg21MmPi/eavWhB0=; b=mOOhVdm5FVXYrKUDWzzMXROBmEuIBtdyZVdP3IGcgO2wnlezP+idMNCaWCZjm/8tZZ kPEm3o8XExieZkiV+/FLdi5O/U+m/Sz2Ag6qCiBt2b9qXvde1DxBBhCVLTA1yuLCeELO u8xhsCnaHJZr72WbRbHV2S7NNFk9WyI1G7wv1k2kTx4O0yxMfsA2odtPAAh5UDd49WRj YWV4DX+XTX+1jNWj6JMuEhA9IuxSMjTdVkCE7wPVLHnNGzt/yo6BJOhdY8lWIADVL5DI Cy+BB7n753bKhfj0y7pUsa68efAK8lP8p1OFA7sn3hQnHY0aGJ/NDS8Rg63SWEfD/pjU zQcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717747487; x=1718352287; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vHTEB/VzVlwsDqiMfVQQnNEOGkiSg21MmPi/eavWhB0=; b=xTO5CJBWmiCPAElJahKZ7a06mv/pa79xmzHGbopfG4Z/Ai51EZwl6hJ1dk4730MZ/1 GOiUG36lr7Kbk3CuhUIc1gwvM7BX3rncqB1nUmytIDwgviFy9TkSKtKpAKMG1CMerKNN RpXQA5C1JoTfOGE843znA5VvEn3disOzXw0PD0Z9PXW19Aoail2Xy4N9M/efqhm+bcHd yIh26qETiD8d9Sj7Yt7hBSAtyJSr4P93fs4+HcIdxKfAiHuhYvW2Qikq+Nv5gih6h7kD owqspEln4E5mYqqKVjloOZ9G5dagFp1ecbaRF/GYhZncxrTo+u0YkZQxHzMKvL2VswA0 zTVw== X-Forwarded-Encrypted: i=1; AJvYcCWG+/K3750utRpg5NCK3d+PJlQ8uwxeJ7ojH/XBejDYR2q9SqeLMGl2eUKSHELzw/uPcbyfYYNew9d2A6fagYlkZ/kn7SVjkVW/p2i1oLw+norL63I= X-Gm-Message-State: AOJu0YzzYCYIkpJ7UaimLhSXfpGNJ7jhI7RJfy8CRff0z2aLrddeS34I oAXFH++Wc7Mz8H6+3LR+CGcX/TSkESukE/Z/GgCdipFTcNXEt77X X-Google-Smtp-Source: AGHT+IExgnAQUcrdORoGg6TV/9qPh9JBwUAmzwB2cHbzIem0i3Xhw9fMo2vk9TjEW4CIT6IHMAkpMg== X-Received: by 2002:a17:907:7211:b0:a6e:a97c:fc9a with SMTP id a640c23a62f3a-a6ea97cfd20mr31412166b.8.1717747485112; Fri, 07 Jun 2024 01:04:45 -0700 (PDT) Received: from localhost (host-95-246-50-43.retail.telecomitalia.it. [95.246.50.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c84aa8351sm183122066b.142.2024.06.07.01.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 01:04:44 -0700 (PDT) Date: Fri, 07 Jun 2024 10:04:43 +0200 From: Matteo Martelli To: Maxime Ripard , Matteo Martelli Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Marcus Cooper , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Message-ID: <6662bf1b61bbc_2f51737023@njaxe.notmuch> In-Reply-To: <20240606-savvy-wallaby-of-champagne-d4a50e@houat> References: <20240529140658.180966-2-matteomartelli3@gmail.com> <20240529140658.180966-3-matteomartelli3@gmail.com> <20240606-savvy-wallaby-of-champagne-d4a50e@houat> Subject: Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_010452_565588_CA742C7B X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Maxime Ripard wrote: > > - /* > > - * DAI clock polarity > > - * > > - * The setup for LRCK contradicts the datasheet, but under a > > - * scope it's clear that the LRCK polarity is reversed > > - * compared to the expected polarity on the bus. > > - */ > > I think we should keep that comment somewhere. I think that keeping that comment would be very misleading since the LRCLK setup would not contradict the datasheet anymore [1][2]. Also, do you recall any details about the mentioned scope test setup? Was i2s mode tested in that occasion? It would help clarify the situation. Could anyone verify this patch against H3/H6 SoCs? [1]: https://linux-sunxi.org/images/4/4b/Allwinner_H3_Datasheet_V1.2.pdf section 8.6.7.2 [2]: https://linux-sunxi.org/images/4/46/Allwinner_H6_V200_User_Manual_V1.1.pdf section 7.2.5.2 Thanks, Matteo Martelli _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel