From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 342BDC2BD09 for ; Fri, 28 Jun 2024 16:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Mime-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8BLuQHw7XUYh7A6NXygwXg3SOfMQ/2DhzNHBqiquzFk=; b=TLasE0fXsFtNi1o842e60U1w85 vSxeoVZ5ceLJrCdulQi8d+H0vSmPxCquzmSu5FQMVpDStwaTIGLCez5EJjoQyOWeCQMD4CSpKY4y8 SMgKWtk+wu7gglIek26tQv0EFkMwvp59iS023E7l8urycS6nZrFKiRaGz7VbmyMGd8OyUEwfwHPFW Y1o5fPn5Sv3mp6zpM2wvZ6AurxOH6erO+rGjx9I5umg6vxNNllNhsOvwRI1ZNWaZsE5MQonePKh37 TaIKxqv8T+AgNPPZd2j/QA/GyJxVmr9DwvgMHoLM7BPRclDBI0vZRbjyF87Y7jFtzWAnp+pqHbWJx igtFts1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNE8D-0000000EIq1-3VLH; Fri, 28 Jun 2024 16:07:25 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNE85-0000000EInK-1yng for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 16:07:18 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-52cf4ca8904so1190664e87.3 for ; Fri, 28 Jun 2024 09:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719590835; x=1720195635; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8BLuQHw7XUYh7A6NXygwXg3SOfMQ/2DhzNHBqiquzFk=; b=PNpHKGvAR4dBH7VDjzKX/lry/yJzGZ2uFdaRT60XC35FbeQDa6dTWgFeFOwW/OXX9U yvLqScE2arub54ZOFjxySSH+bNt+Lff3KGELAYrvjLCLfAITDCUl6hyoQZvHZIaqXIFL n3q7r5YpyCUImSmtl0v+W7e/JwifVw78QYhY9TNjVLIrmVaPCM7uvwudzYoWmfKAb/Qi vtQ/9xbFNWMLw30hXP4BJ6Q9/laBZ764ZVttWUrUzLFJWY7akRGkhLnuVabWJfV2Y7n1 iJ83u3WgZ4E9JqBxRbhXqOpjJooCZ4LEjDr+KkI6A/nqWFVN1W1zZQ+4kxg0H5rqsCE6 mTKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719590835; x=1720195635; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8BLuQHw7XUYh7A6NXygwXg3SOfMQ/2DhzNHBqiquzFk=; b=DSrFMhDLyx5V6cJ6R12AfyT8/6NqOLYdV8K5UTh03zmXXv9CB4wBnxhFOVQexwM67y KgaOAjytuE1nSs1DJCRDO61Lk8vR3RjStIJ5MGN2p48Nq2rIK5nqaw2J8DgJ99DEd5Z3 N7SGWRo9Ot8fCY+qSE+6yMReRv6OeHSoeew7abAMV2DIw2rnefni8YziT74yYpKLlZmG lmuWorN8pBEJHgD7GsqEfZrDP4PNN3vPzvyAKvrVYqxCdokREZ1qVGZzEW2PlZ58lYVE BP7wt85gRiOdpTQbp1dSU8oKIdbQM8DpM9dtt0X29L1GCLbt8vrux9iuurJgzFutGaOf G/cw== X-Forwarded-Encrypted: i=1; AJvYcCX8U+kmoASigLPI6+fiy9mOBSeRIMhx/6/38gxnyiBPoZc54QNysGhH7gLkfUFfdVBWXQwWV2CuFBU1pW8fRVMm7r7Mj6+tsp1xxl+tdM6RFasarl8= X-Gm-Message-State: AOJu0YwX421AtJpd6vpJbSSmZWvACdsERj6/odpgMG+wkRlEriZxmxPG acbnXUZHvDrlhe1rXYNEkRK04S/UtAPD+cIKZfPlop8DRuUfAUTF X-Google-Smtp-Source: AGHT+IGKtZ27jyLm/4hObT+qQKvkXECnsn/l8exN8++MKWIkS87HhKNrOpgNjyAfe/Lwii2sJwIqVw== X-Received: by 2002:a05:6512:3105:b0:52b:b327:9c1c with SMTP id 2adb3069b0e04-52ce068042emr10387590e87.62.1719590834351; Fri, 28 Jun 2024 09:07:14 -0700 (PDT) Received: from localhost (host-95-246-50-43.retail.telecomitalia.it. [95.246.50.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b097c2asm42256035e9.38.2024.06.28.09.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 09:07:13 -0700 (PDT) Date: Fri, 28 Jun 2024 18:07:12 +0200 From: Matteo Martelli To: Mark Brown Cc: Maxime Ripard , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Marcus Cooper , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Message-ID: <667edfb08cbf3_eca1e370ea@njaxe.notmuch> In-Reply-To: References: <20240529140658.180966-2-matteomartelli3@gmail.com> <20240529140658.180966-3-matteomartelli3@gmail.com> <20240606-savvy-wallaby-of-champagne-d4a50e@houat> <6662bf1b61bbc_2f51737023@njaxe.notmuch> Subject: Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_090717_550146_7B1FD042 X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mark Brown wrote: > On Fri, Jun 07, 2024 at 10:04:43AM +0200, Matteo Martelli wrote: > > Maxime Ripard wrote: > > > > - /* > > > > - * DAI clock polarity > > > > - * > > > > - * The setup for LRCK contradicts the datasheet, but under a > > > > - * scope it's clear that the LRCK polarity is reversed > > > > - * compared to the expected polarity on the bus. > > > > - */ > > > > > > I think we should keep that comment somewhere. > > > > I think that keeping that comment would be very misleading since the LRCLK > > setup would not contradict the datasheet anymore [1][2]. > > > > Also, do you recall any details about the mentioned scope test setup? Was i2s > > mode tested in that occasion? It would help clarify the situation. > > > > Could anyone verify this patch against H3/H6 SoCs? > > Any news on any of this? Not on my side, unfortunately I cannot test the fix against H3/H6 SoCs. Matteo Martelli