From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A55BCC30658 for ; Tue, 2 Jul 2024 15:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Mime-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t7xByIbV2umIoygttU7Su2ntwwqoRDPa8Pnvxm3eHlc=; b=p2SP4yOlRytS06QoqJzJE8kthv QQ9iAhorS8oyFKI08d/es/5l3u2VRxlLhwmDEuwBbDysF05Ta/IKqv3kfEH4a6fv7CfwKoWSckwbd uKLiIYEFGM0lalTBRWe02HGq6lNF1T2Vw02FjrUW8rYW9PjqoKHWerDaxXKUg5pFoOTa/thZow7jA Oa4FfYODmhQ12pQ6HhgjeHLqMZiUiugkvKoQzrGRlxOvSk5QJ8bLd4xApZ5IcBUg5fznfesMEcBvh bf1zRWfhctfiCaQlowJBm311b8wl7tyxEbYd3/BQiuoptiJ5au+FDCsNIFRmdjMErmCjPc0T/J8sT JAgiJOUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOfG7-00000007AvR-3mCy; Tue, 02 Jul 2024 15:17:31 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOfFw-00000007AsE-1CO6 for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 15:17:21 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42562e4b5d1so30707375e9.1 for ; Tue, 02 Jul 2024 08:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719933438; x=1720538238; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t7xByIbV2umIoygttU7Su2ntwwqoRDPa8Pnvxm3eHlc=; b=lcsMTEW3QB2md9XO7YDMNWd0AzMuL4Ht9x8qJfc8C1Akz+HG1ZbPwLvCjxN3LYtiJJ U+OdW7sdvIrCa0AjA3hnhsMB5jRXu6QflPUIpJpIvw7/6vG6NEyWs1c1gyDyTb1L6wrv FWoCa9PWqKDWmUIyfgMMw+kpce5UbeMHtO8rTPJIlu+prGPHTmCgNItTUg7u+xVOUqvB Sbvy0aF4WmR4N1QfQnDmSO2z21ovd4hfhxhV6Oyj5k9Ty+L2m1mLlB7W2w1Cw1RR18zk SySKa7uJvRw6VxiE+l2lJcCDYVg8RcaW3mWDOg+/u+GRaF5X7J7HPTRv+/Phz18zAAEw Zxwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719933438; x=1720538238; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t7xByIbV2umIoygttU7Su2ntwwqoRDPa8Pnvxm3eHlc=; b=D/zFaVGG/8VxlM+3X6NbS56YdEF2UF5hKp1AnGbzjlXqjBvh6p/d5+lnyWtIE+d0ds LDekS2+Ji7kZnTv+1yoK5FZCcbPHlXLih2Y8uC6HgwRXy+L+HXT4btAozhdmqgb68Mqk au40Y/3T2QJQUqlNfTLn1gDFTfwZx+xPsZBCWuabk9AEeKTrBgqYVZjsWoYBJIT3+pgX 12Z9q8KhTvxnZ3xgmNIZiNBXP3iNP9tOHg/yVGT1fLfNifR/wkfGFEt3gLpJYs+XCil5 dorTwvGPHsuwuOYdQ2mHXVZaFqJsTMMAqnKAbITuG8BSf+7IjEMdKFM5IhhZNByf03rj 4qAg== X-Forwarded-Encrypted: i=1; AJvYcCXQsqDWrCvW0je75S+JD9aNJHrsUDidPNyfbObexa2Sl6vqlue2YA79Q6XDD4JYaTlt9HhOsf5kUtVEtnhXtJ31941I+OTYJtxf0Gv7NJZAucHTFZc= X-Gm-Message-State: AOJu0Yw+Jo6ogwXQ4ho8Jsf3zdkU0JDlO28cH8GMJ+Z21/JSlBFW3nMu AwdFMd8gaXT73QHwnfoyojZE+nLLjLHaI4Uz5z6yAzH2jZUgI6IV X-Google-Smtp-Source: AGHT+IGX4cMz2AKxR9UquQ5Q7gBmz158IKH0vcsGbbVsGmFToi6f21HaHfYS04B91Tgb0Y7+kQ1CNw== X-Received: by 2002:a05:600c:3b09:b0:424:7bcf:2486 with SMTP id 5b1f17b1804b1-4257a00aadamr54017895e9.4.1719933437469; Tue, 02 Jul 2024 08:17:17 -0700 (PDT) Received: from localhost (host-95-246-50-43.retail.telecomitalia.it. [95.246.50.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b068e54sm205410225e9.25.2024.07.02.08.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 08:17:17 -0700 (PDT) Date: Tue, 02 Jul 2024 17:17:15 +0200 From: Matteo Martelli To: Maxime Ripard Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Marcus Cooper , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Message-ID: <668419fb8ef9f_2a76d370f1@njaxe.notmuch> In-Reply-To: <20240702-copperhead-of-unusual-intensity-7f43a8@houat> References: <20240529140658.180966-2-matteomartelli3@gmail.com> <20240529140658.180966-3-matteomartelli3@gmail.com> <20240606-savvy-wallaby-of-champagne-d4a50e@houat> <6662bf1b61bbc_2f51737023@njaxe.notmuch> <20240702-copperhead-of-unusual-intensity-7f43a8@houat> Subject: Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_081720_362197_02CDB29D X-CRM114-Status: GOOD ( 28.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Maxime Ripard wrote: > Hi, > > On Fri, Jun 07, 2024 at 10:04:43AM GMT, Matteo Martelli wrote: > > Maxime Ripard wrote: > > > > - /* > > > > - * DAI clock polarity > > > > - * > > > > - * The setup for LRCK contradicts the datasheet, but under a > > > > - * scope it's clear that the LRCK polarity is reversed > > > > - * compared to the expected polarity on the bus. > > > > - */ > > > > > > I think we should keep that comment somewhere. > > > > I think that keeping that comment would be very misleading since the LRCLK > > setup would not contradict the datasheet anymore [1][2]. > > > > Also, do you recall any details about the mentioned scope test setup? Was i2s > > mode tested in that occasion? It would help clarify the situation. > > I can't remember if I tested i2s, I think I did though. But most of the > work was done on either TDM or DSP modes, and I remember very clearly > that the LRCK polarity was inverted compared to what Allwinner documents. > > So the doc was, at best, misleading for these formats and we should keep > the comments. > > Maxime Thanks for the reply Maxime, would you be able to point out the Allwinner document part that is (or was) misleading? The current datasheets (see links [1][2]) look correct, the current driver setup for TDM and DSP modes respects those datasheets and it's not "reversed compared to the expected polarity on the bus" as the comment states. Also I didn't find any related errata in their changelog. Could it be possible that during those mentioned tests you were still referring to the datasheets of other SoCs like A10 for instance? Or maybe that the misleading information was in another document rather than the main datasheets? If that's the case, would you still think that the comment should be kept as it is? [1]: https://linux-sunxi.org/images/4/4b/Allwinner_H3_Datasheet_V1.2.pdf section 8.6.7.2 [2]: https://linux-sunxi.org/images/4/46/Allwinner_H6_V200_User_Manual_V1.1.pdf section 7.2.5.2 Thanks, Matteo