From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Kevin Chen <kevin_chen@aspeedtech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700 binding description and example
Date: Mon, 14 Jul 2025 10:24:16 +0200 [thread overview]
Message-ID: <6685da47-748a-4d90-ba1f-d7bcf82e8677@kernel.org> (raw)
In-Reply-To: <57c0d48d-1484-45df-a99d-11388b6efdb1@kernel.org>
On 14/07/2025 10:23, Krzysztof Kozlowski wrote:
> On 14/07/2025 09:36, Ryan Chen wrote:
>>> Subject: Re: [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700
>>> binding description and example
>>>
>>> On 14/07/2025 09:17, Ryan Chen wrote:
>>>> - Update block diagram for better readability and accuracy.
>>>> - Clarify the relationship and function of INTC0, INTC1, and the GIC.
>>>> - Documentation and example refine.
>>>>
>>>> This enhances the documentation quality and helps developers
>>>> understand the interrupt controller hierarchy and usage.
>>>
>>> Changing ABI (compatibles) is not enhancing quality and is not explained here.
>>>
>> Sorry, I would add following in description.
>> - add 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible strings
>> for parent interrupt controller nodes, in addition to the existing
>> 'aspeed,ast2700-intc-ic' for child nodes.
>>
>
> It does not say why is this needed in the first place...
>
And also never tested :/. I won't be reviewing it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-14 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 7:17 [PATCH] dt-bindings: interrupt-controller: aspeed: Refine AST2700 binding description and example Ryan Chen
2025-07-14 7:21 ` Krzysztof Kozlowski
2025-07-14 7:36 ` Ryan Chen
2025-07-14 8:23 ` Krzysztof Kozlowski
2025-07-14 8:24 ` Krzysztof Kozlowski [this message]
2025-07-14 9:42 ` Ryan Chen
2025-07-14 8:17 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6685da47-748a-4d90-ba1f-d7bcf82e8677@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox