From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF193C3DA49 for ; Tue, 30 Jul 2024 09:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B1rX42vyLb2o7bCFZWbpolb7axljRnf+cPcxVtkPaGQ=; b=FTc5Tr3EuV+9uytKMV+vBbYrc0 nyOoL5/+g69uTmPvoUfFE+cfMWoe0sxixXOqsGbVPVGRquh7zUJQ3zolCD/nC3QAXupV+uGMfEQ6I KP/49fhqZpu58miOnC1OxYP+igCTMvXaQeFXXk5ScjosfPo1Kb9acG/jX5t2sHMJOXSACV963Wcxi M8ZCbK1j9QPa5UPTGBLelBRbWgdjqtOhTESksed+2r4SSLOmYh2od3GYFPdhskDM5sXAdQ6a/6+0j JfF4D39nEvbtsLxRaxVcbJlaMsRVEUY+yq953A/4REbksgYMYJw63GwF53k24pxihURY/mRfC5Ezb B9Yo991Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYilw-0000000EQu3-2mz9; Tue, 30 Jul 2024 09:03:56 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYilS-0000000EQlb-3WQx for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2024 09:03:29 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1722330203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B1rX42vyLb2o7bCFZWbpolb7axljRnf+cPcxVtkPaGQ=; b=bCfFGBIT1faiidn30la/pcdfIJvxka3DNVc0xjGFfX6kvV2FhIXUlEqbjhoKhyZVD6OrZu rUWUQCJCb90tmf8Ez/2TwpgNJatjH6TVQ2qCBKL6H1pwV2sVJIuEwRP9qxWWFT+CrqbuFX IKAjb5OD/VQm9YCL6AEP+0qmdTMRRpA36I4UqbQ6LxOkXwRaXEhfPwhsGbjsGOrxweKuOX EvdKyeXhkFALDJjEWLNZJ0Hr7gSWA75mH6TWg25dyyU3j00GjKVCoTSNaVBvQhMEElubb6 7Qd/GNZXXTZRjpCPAImtTpu5VYy3orfCohbBN26pAlMSOWBH5vwLH7nb9B/3Qw== From: Diederik de Haas To: Dragan Simic , Daniel Golle Cc: Chen-Yu Tsai , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Conor Dooley , linux-kernel@vger.kernel.org, Herbert Xu , Martin Kaiser , Sascha Hauer , Sebastian Reichel , Ard Biesheuvel , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, Philipp Zabel , Olivia Mackall , Krzysztof Kozlowski , Aurelien Jarno , Heiko Stuebner Subject: Re: [PATCH v7 0/3] hwrng: add hwrng support for Rockchip RK3568 Date: Tue, 30 Jul 2024 11:03:06 +0200 Message-ID: <6690040.iosknibmi9@bagend> Organization: Connecting Knowledge In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart20867227.UFCzubSe9b"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240730_020327_700525_C947AE64 X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --nextPart20867227.UFCzubSe9b Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Diederik de Haas Date: Tue, 30 Jul 2024 11:03:06 +0200 Message-ID: <6690040.iosknibmi9@bagend> Organization: Connecting Knowledge In-Reply-To: MIME-Version: 1.0 On Tuesday, 30 July 2024 01:18:37 CEST Daniel Golle wrote: > On Wed, Jul 24, 2024 at 08:07:51AM +0200, Dragan Simic wrote: > > Thanks a lot for the testing. Though, such wildly different test results > > can, regrettably, lead to only one conclusion: the HWRNG found in RK3566 > > is unusable. :/ FTR: I agree with Dragan, unfortunately. > The results on RK3568 look much better and the series right now also > only enabled the RNG on RK3568 systems. However, we have only seen few > boards with RK3568 up to now, and I only got a couple of NanoPi R5C > here to test, all with good hwrng results. > > Do you think it would be agreeable to only enable the HWRNG for RK3568 > as suggested in this series? Or are we expecting quality to also vary > as much as it (sadly) does for RK3566? Unless we get *evidence* to the contrary, we should assume that the HWRNG on RK3568 is fine as the currently available test results are fine. So I think enabling it only for RK3568 is the right thing to do. So a 'revert' to v7 variant seems appropriate, but with the following changes: - Add `status = "disabled";` property to the definition in rk356x.dtsi - Add a new commit where you enable it only for rk3568 and document in the commit message why it's not enabled on rk3566 with a possible link to the v7 thread for clarification on why that is You could probably also integrate that into 1 commit, but make sure that the commit summary and description match the implementation. IMO that wasn't 'technically' the case in v8 as the rng node was added to rk356x, but it was only enabled on rk3568. My 0.02 --nextPart20867227.UFCzubSe9b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZqisSgAKCRDXblvOeH7b brDnAQD8u6tajseWbanb373R9KrnELq+Iwcw8RlufXKnVpFIQwD/YZ/Dq5lXye++ z2hXSo/Jh+izrQpNgfewXWOAVGeswAI= =mbtE -----END PGP SIGNATURE----- --nextPart20867227.UFCzubSe9b--