From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C0BC433F5 for ; Mon, 27 Sep 2021 09:58:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ED8760F48 for ; Mon, 27 Sep 2021 09:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1ED8760F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PTGnAoDEnLrlrAQQEweiT3HhYAzqolfMyCqJnefr0/E=; b=hYT+wmIcLFQHwfQ8C2AwdT0jik KAonkQTnMkGufa00gXKZAHyAQrNKUpYDyCKRlr68CqOK2bpB59d/M7Gbo1gvFn+2eij8kmlqN9NGx NOmSgD8BMpb3ehSidhlFjxZPw5O/55lIupzT/H2WI2LMTdBaV1KKH6muIMr7rf8sfe7MEpJwvAmhi b0b0H4Exbsb8rcvN3Gudb6zuUOU3cKcOFr0v/ud0m2+1Zw1blMVzInwxl+i8rR+/jVFLHtgnXbuQ5 IgOJxZAoPsFoODP2if5CRUXJz7r7ExyqMXN/kQhAAthYrfmmBw4N7Wfpcp2T/g0qoYR0qaxVxBEXs OpHnMHEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUnMp-002ELC-3Z; Mon, 27 Sep 2021 09:56:11 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUnMj-002EJb-Bo for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 09:56:09 +0000 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6DB06402D9 for ; Mon, 27 Sep 2021 09:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632736559; bh=nIU5tLYb8kiPoNkLCvMx2HqJO/MUaTxKgEujQiXGrPI=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=JSy+4eYnCTplSl+dSVzoeHu5juCEE7J6rLBOPRIxYenATLauGNMlxxpuQfEE/+aVP EB4BFKceHi793dN/Z7d/XUjgW6bXcXUCxHZ8ICSt7NF9s8ZcvMY1T8oQUI212Rr12f 3LxBHNuBSsp3t6jVWu8+t65nuZOUWHWRmuWFptamtvXEDZ/6d1KiwcOR9DyVf64jsV uw2kSybRBUQPLLbtTDIhgxXeXjggk5fGcao2ZTmXLQ7UJYlA1EzPVeXIk1hso3z72o NnauAfr94+CSqNK4Psk/UZm35uuwwUmNFddEd4YcOXXonRNPSjY0AyGDVKzo5KbZ9E UawS+6gtvgxLA== Received: by mail-lf1-f70.google.com with SMTP id bp11-20020a056512158b00b003fc7d722819so15333029lfb.7 for ; Mon, 27 Sep 2021 02:55:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nIU5tLYb8kiPoNkLCvMx2HqJO/MUaTxKgEujQiXGrPI=; b=Nu8mQFTZ228IzrIEuBsfLEkSFBEe/eIfObD1bH7zGgMZUZ3nxGayNCunZGVUN35BKK om+wKFTCCMpvzDCI+y7H2nZ89peIQ1Tj3XhbkLvuIxtBa9HEpbfQM98ec7GEC1kvYLnx pM55bWwM2avcsqvDLsb6Bz9Pr2GoBOyMq+OpWq8EzJCjXAdMOJpSg6P3p2oSpsQii5Vm 4tTWixnfk/xcFOdIOmGyY2tU7BxUHXdujNZXYhJgnIq9n+8d12V/kixo8UDRBQR+CzYW KlFHylcij1LbzaSjImII+KGBNkCUxg531wgJ25zYcuanXzYQHUCIWp7uu9Ei9d7JYsy1 Nqeg== X-Gm-Message-State: AOAM533Elfw7po+5eE/Fi3qqxH87KY6FssOFIKpSYsC/jtWLiDfbIhR+ xSHXfyHpgKy/gEnelvxZf9+8Xu34xPOutBFzWBrRGm5X5cwLN9h1IQ+gEm3XNcqies7ojEv87rH +RdUkn1LD/Z3+dCmEYHdMprSaRCn9pwwBqyW2ebLlET5d0jPc2oIr X-Received: by 2002:a05:6512:234b:: with SMTP id p11mr22993034lfu.81.1632736558903; Mon, 27 Sep 2021 02:55:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsQ6KVBbhaTPACnyZPmIXhjr9se2x7ZwWQTaBMxZMqHiZxJFGWKh3hO/D3QI+51qPHcHs7eQ== X-Received: by 2002:a05:6512:234b:: with SMTP id p11mr22993025lfu.81.1632736558751; Mon, 27 Sep 2021 02:55:58 -0700 (PDT) Received: from [192.168.0.20] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id br38sm1537149lfb.305.2021.09.27.02.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 02:55:58 -0700 (PDT) Subject: Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch To: Arnd Bergmann , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210927095150.944127-1-arnd@kernel.org> From: Krzysztof Kozlowski Message-ID: <6695844c-e79d-d62e-87da-f96f8d5ca3bf@canonical.com> Date: Mon, 27 Sep 2021 11:55:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210927095150.944127-1-arnd@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_025605_572665_000E5990 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/2021 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) I think I saw it but back then implicit-fallthrough was not an error :) LGTM: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel