From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 395A0C7EE22 for ; Thu, 18 May 2023 08:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HPnAWIrD0yB5uTtvxZmWmiYe6JNeH0fo3bJyy46tsSY=; b=Ymvqwr4mcGlbvi dlpJubMjoWwlrI2cBIlg/I4rq2+az9zrFsrpfr2v7YKA32ZauO2TTui5P0y/50q52KY3dHczr7+B+ sdfcrDxFhczHpsrxTGXp7AMflWkkr1HdzdY9kq9l1vzoOEJfhMBchzaRwM3YxFrhCvpTff4CyogEW CS5M2BrO3ze03rbiDi86AEWn6fjudL3RK9BFZzN2U2r2ZppHQtuSOiCv4iaHX2NRTwCfZqxJUC6Me HEYaEVYsPeTV67LZlI2XGdNhSPfq1OlXArTC3Zbi1NqmTZU+hm+6p2izafcsus97Pf9DBijeahojC 6bhTF2q3v6+XfuvpLCSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzYvr-00CKmX-28; Thu, 18 May 2023 08:24:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzYvo-00CKlL-1z for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 08:24:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3191561B68; Thu, 18 May 2023 08:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CD61C433D2; Thu, 18 May 2023 08:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684398254; bh=bthXTbRdn0p6tWozz2CFQo/ARnZN5zmu2V0n1rsAQ5Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OM5lRlNpkVVzjDFq/sjddkhE/QNh6e4/zqBcwgDRC3xKn2i6gEAaADYvlcb13OJhe usNdQnJuXh6m8DUwJ5XYXAI6IrCo+ZyGYMpeO3asBobK0aOfAIBsnzBL0TqecUNbGC YWJrMXUntyQQFt5kqLLnn7MfJ+S73I8oYqdLhPoFj78zkA1LSeLnwHuwIKLIJHRz+W NI3Jhy6e0/A6OS90DWtTms2SIS3KbtJKUMM5CX1sNnxNXxmviDHtbEcrYITmVprHZW N+nCJltmo5TrNZ4+JbDLaxOC1Xtm5Fk2WJHg43Blf1mSSXx4vTqxSA3Gu8+TW6gtT9 +hbiecR+bVBPg== Message-ID: <669d7b79-71a6-e1f9-8d7a-71c4b64de28d@kernel.org> Date: Thu, 18 May 2023 10:24:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] dt-bindings: rtc: Add Mstar SSD20xD RTC devicetree bindings documentation Content-Language: en-US To: Romain Perier , Alessandro Zummo , Alexandre Belloni , Daniel Palmer , Rob Herring Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230517144144.365631-1-romain.perier@gmail.com> <20230517144144.365631-3-romain.perier@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230517144144.365631-3-romain.perier@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_012416_759630_688F6DD4 X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2023 16:41, Romain Perier wrote: > This adds the documentation for the devicetree bindings of the Mstar > SSD20xD RTC driver. > Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. A nit, subject: drop second/last, redundant "devicetree bindings documentation". The "dt-bindings" prefix is already stating that these are bindings. You actually repeated everything... > Signed-off-by: Romain Perier > --- > .../bindings/rtc/mstar,ssd20xd-rtc.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml > new file mode 100644 > index 000000000000..2acd86cce69f > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/mstar,ssd20xd-rtc.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/mstar,ssd20xd-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar SSD20xD RTC > + > +allOf: > + - $ref: rtc.yaml# This goes just above properties: > + > +maintainers: > + - Daniel Palmer > + - Romain Perier > + > +properties: > + compatible: > + enum: > + - mstar,ssd20xd-rtc Why rtc suffix? Can it be anything else? Missing blank line > + reg: > + maxItems: 1 > + > + start-year: true Drop What about interrupt line? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false instead unevaluatedProperties: false > + > +examples: > + - | > + rtc@6800 { > + compatible = "mstar,ssd20xd-rtc"; > + reg = <0x6800 0x200>; > + }; > +... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel