From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F22C4742C for ; Fri, 13 Nov 2020 11:14:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2E96207DE for ; Fri, 13 Nov 2020 11:14:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="baBjcCYT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2E96207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=az3Jz1Tr8JcHpl9QU7nUeyMsLg7kQM+f6ymVGD7NTFk=; b=baBjcCYTSqOXuRcM/7czd7Wop TPZ18nPlHeLXIRfRvpsZu+VQ60edMstLMwED5HQsSJgSKUhiLqHYKvRq4zx/FIcre9ICYM3ATKgZZ JSk7Z4bxSRsfzaGw3JrU5ObrUiTLSu+4cIDRELrE0E5L8f+lLA9QRMUQJwDL1bFdOcaAgmJe2+6rh tsng7JiadvSN2bGYMg8wAoDrdItpCWMuZOLI4vsy+5YDnaTcwliUlZb1V1gBdAequlyptQkbu45Sb 7aK1C1katcHiE/MvuKRUuMSQLXUH6RO/x6l0LVOAm/Oyq9TQoTjafXb+h+TmSD/ecfd0XkoSlLp8F y8491rcWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdX23-00080t-3g; Fri, 13 Nov 2020 11:14:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdX20-0007zy-Ee for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 11:14:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B40081042; Fri, 13 Nov 2020 03:14:12 -0800 (PST) Received: from [10.37.12.45] (unknown [10.37.12.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 568CB3F6CF; Fri, 13 Nov 2020 03:14:10 -0800 (PST) Subject: Re: [PATCH v9 30/44] arm64: kasan: Allow enabling in-kernel MTE To: Catalin Marinas , Andrey Konovalov References: <5ce2fc45920e59623a4a9d8d39b6c96792f1e055.1605046192.git.andreyknvl@google.com> <20201112094354.GF29613@gaia> From: Vincenzo Frascino Message-ID: <66ef4957-f399-4af1-eec5-d5782551e995@arm.com> Date: Fri, 13 Nov 2020 11:17:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201112094354.GF29613@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_061416_563987_0CF7A04D X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, On 11/12/20 9:43 AM, Catalin Marinas wrote: > On Tue, Nov 10, 2020 at 11:10:27PM +0100, Andrey Konovalov wrote: >> From: Vincenzo Frascino >> >> Hardware tag-based KASAN relies on Memory Tagging Extension (MTE) >> feature and requires it to be enabled. MTE supports >> >> This patch adds a new mte_init_tags() helper, that enables MTE in >> Synchronous mode in EL1 and is intended to be called from KASAN runtime >> during initialization. > > There's no mte_init_tags() in this function. > During the rework, I realized that the description of mte_init_tags() in this patch refers to mte_enable_kernel(). In fact the only thing that mte_init_tags() does is to configure the GCR_EL1 register, hence my preference would be to keep all the code that deals with such a register in one patch. What is your preference? -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel