From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99409CF9C5B for ; Sun, 22 Sep 2024 01:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bgfDg8A4KnnscMVrY8WmrQLQYbE82PYhso4UPM3tj5I=; b=kmLgB9Lo7iPAZQHzJx1KWIBLs0 /YhABtsvJtjirHNhKDUEYwsgF/VQnlksnzXJZMrrzjPcoVzjQe9PsGJVG9rkz6I5234ibIVwlM0vZ My6oma/jW+PGMS7zV5P9f24kttOT5NNvKq4LttAEsjm8KmrU82wLG3gQkrflQV0X6reyaj/Y+pXmt A+HJgwumv5Vr/hLF++i4hyNqu7N89YAYz0OD5Y4N5fo9tSgH69wmI2jSP4c2E9wLJPitzFoxIcg/q poZ+Xm80ovfvhDAZw57W4hkvBIva09B6axQhpVRRfPG2uSqG1XF0nouqyOphzroqAbUq2GNDPVVqh 0s54xNyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssB1C-0000000ETgX-0wsJ; Sun, 22 Sep 2024 01:04:06 +0000 Received: from mgamail.intel.com ([192.198.163.19]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssAyP-0000000ET7M-2I6e for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2024 01:01:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726966874; x=1758502874; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9Vrrx1YRfKNwQa+T4E1l0C/HEH5iuM8HFnpWrb9B5F0=; b=dUE7E0SRRfPt15IN2ij/dC7KOpVRNNBcO1KrVk8GqN9Ca8T7c75PSgvn 6GYq5FbXHbPTjW4v9DrpRMO5GpY9PLp4wp8BAa94nh+mbC6YYws6Vlf7n huocN/S0Zwp7eA8zmZZ/P5QLNMsr32PcTeWZhc5LInIVXKBHcK0ln2OKH w527r7/YyjsdNp5eHtmJMG0zQoV7jabRlpO+iPy7go3XP3CtwGnqMBH2/ uD5QGQFwh9fZWXt/4Yvd5mi8nK0K+nFV7uVaL28lXfL+4KsRJQeRuJDPB geeBkHbqFtbTVknsv65AwEn+RBbYRbWR+PVA9MMA5cvEiMONWIpwdg4fg g==; X-CSE-ConnectionGUID: Y7PT5g8MRUOi5zK+BoYz+g== X-CSE-MsgGUID: a/QOKrnjQ3y7QS3rRrpePg== X-IronPort-AV: E=McAfee;i="6700,10204,11202"; a="25459618" X-IronPort-AV: E=Sophos;i="6.10,248,1719903600"; d="scan'208";a="25459618" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2024 18:01:10 -0700 X-CSE-ConnectionGUID: 1mn1dEBiQL2K6vfJHG13ng== X-CSE-MsgGUID: xfRw8tS4RhyKdxBNP4l72g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,248,1719903600"; d="scan'208";a="101409980" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Sep 2024 18:01:10 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sat, 21 Sep 2024 18:01:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sat, 21 Sep 2024 18:01:08 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Sat, 21 Sep 2024 18:01:08 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 21 Sep 2024 18:01:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VaUcIbhRF0wxq6XxK71wKzfBLm5MD/fLr8+O1AB+qnN1VVK6SjZ0vvnCTYps6sBNLEMwsHGwX3ZwIF0LQDsQUlqmATbGQisdUt9uOZDynWYh9DPXy5Y4+adNYnjmjeYH0+Adk475+ZI+ThbZRCtWKHMDci1giRbJxvxyUKjTcTR0fR2nPC6LQHuyXzjyWhFC6v1BhLADIF2y2bUKG4wwqUA5JphKSslVm5b/kjyRYAUJIzOxtJKgzg0FjG/bvIg7MTjkB9e2nM8T/xJYejTN59VcFnaOtbp63rZVtkPNw35tncALDC204xxdAQ1OEEkSUgIW82uCW1U5KN7CNHyFbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bgfDg8A4KnnscMVrY8WmrQLQYbE82PYhso4UPM3tj5I=; b=aHL+HrUyTgq/AXp2fV26hhMt6vNBgWz0/Qg/RsqQuXuIWfTUbtCt4F82m551BYq5qrYdGiuoTp38cTjOxtnADd/WfPU/zmBfMxX/qPc0+7WPHlcJ3m0eoNU+Q/rLK+yMknAWp6/gdRbWV2tQ5DX6rBfZYyRMVlFOvW9RZEtrRpzgql2OkDNT8vMEHhmgiC5LXL34X1oe5tRxAGzjgTgitjRx88EylMxf4dyBqQAOAJNjuQlJx8S2gDDZ/gSf4bPjUy/7DQrffEYEiC+KAHNF1FB18wjqTKsa/nuS40hVLFJp+4f091s6jc+AOHzyzeQmLmpZF5qEaxEdiR137HIAbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by DM3PR11MB8684.namprd11.prod.outlook.com (2603:10b6:0:4a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.24; Sun, 22 Sep 2024 01:01:06 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%7]) with mapi id 15.20.7962.027; Sun, 22 Sep 2024 01:01:06 +0000 Date: Sun, 22 Sep 2024 03:01:01 +0200 From: Dan Williams To: Alistair Popple , , CC: Alistair Popple , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 03/12] fs/dax: Refactor wait for dax idle page Message-ID: <66ef6c4d9e855_1099829454@dwillia2-mobl3.amr.corp.intel.com.notmuch> References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW4PR04CA0229.namprd04.prod.outlook.com (2603:10b6:303:87::24) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|DM3PR11MB8684:EE_ X-MS-Office365-Filtering-Correlation-Id: 0adf1b9a-c2a4-432a-55e0-08dcdaa20990 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4/hVVsM2pkYO1csKgKUwPbkZ0VzBvER6AmLVeBGUUtxHo4ogUuKf0Y9AaexC?= =?us-ascii?Q?4qHgBTiOWieexsQMxd5f5KA9Fq9sxClSffMSoZAa1w+AEbW9+uttj4AUzL+j?= =?us-ascii?Q?vvQsA0QHNgCUHr+dDisDrVUxztHpSokbthzM6AA0CD0/IqYJeVN5ete500wN?= =?us-ascii?Q?9P63waBbJVhiHy9lPXmd1t1TkTjtH+UfeDjphiRFU5OtUtwY5Njqb+B2gAAY?= =?us-ascii?Q?+01Ahd3KzZCW50i+wr5AVtrjVkjMvEFARyUrV+7akQIqSrCe3dK6rqEnwXCW?= =?us-ascii?Q?h0ndEJXMlkDGtH73In4eGe8Axo0EsAWEQUopkc4k4HqTMtwhuIOuKw8Hecgx?= =?us-ascii?Q?+FjeHFGHBuaZzAJFHDfFNGxDFZZh5GbtGSgeozLIpoI/5AVd8/pMRMK3P4Lc?= =?us-ascii?Q?q7h++VKpeDTXa/fT7CzRmAekAci2WOvmomIbfAdMY4earcsQHnOgoUK4Mlii?= =?us-ascii?Q?u3ElvyYhXW7Om+TCumvuFQ6awYaR9UXhkWsWgPWzDjCqe353RLoMslaBwjcX?= =?us-ascii?Q?1kM14clKIMTqg02M54Yob2GXRaUaUPZOzhGHOQlG9CrTL7hbOrEEjJ9t3ElF?= =?us-ascii?Q?ZoeyyWQkKPJYVjwa8Pjd04y7r87ClPh051tlPvAHbNTIgQJRdzl4IjRBWz5V?= =?us-ascii?Q?NMybDLINTsoOIDTzlGVFe3TQn1XG4+8qU2IfHM9JBvA2jS0qGbewwKsJGNwt?= =?us-ascii?Q?/90pVJXREDfZSdsCS8iZESEfHq90Ro0zEeAN8lymcr0jbyNGxdSXgMw2fZY8?= =?us-ascii?Q?c3ZEVK2UsOt5PBrlZL3nHxhKMxiCSN9vvrdN+dDOZhUxdkibddAcbV6bhUwY?= =?us-ascii?Q?bSkGw4LHPBhOL44Mvj5OpFVBb+XRXFN+0G77zGIcJxHrGUJSBiTlpzq9zeBH?= =?us-ascii?Q?39xm29S/4aQcrvDlyb1QUbmGkQhnzP07MVvIk4LV9wEl6BBIbZBBc9lr4Fpg?= =?us-ascii?Q?ugE6/7wje6x5/Ru5xlx5T0TFK+rAQIt4h2DLWoaIWYvXGkFC3CgGk3j+Ma11?= =?us-ascii?Q?AQJFiuJz6PQFNAU8wn0by2ATBUu7oWfq2/C/WeGGu4dCsdnDeP3s3YJ7UlNu?= =?us-ascii?Q?OfhKQkrtDPrIpaArmm/MOE/O3h9aZpuA2AtSdKHdoxxMjn21YgX4KkfEIjLJ?= =?us-ascii?Q?uHdkmd+ZuaufOVe0Xvtnfd6WoO4ewn4M6B7wY85F6vQEZyLBTcD19MN06382?= =?us-ascii?Q?veXjO+fxuWR1F30UFYOFZDxEQsMqJlsvKrgWXW75xRyQBcXq9h9iP0ridfxi?= =?us-ascii?Q?1gdRhgTxGw540sNx5AIqaGhWkBYEdJ8H8Dde5h3XO+lv8hwpCWc3anrJjc7h?= =?us-ascii?Q?NXKfPmQ7EZkR2oBbJqDbpvjSP1ZMog66Hl7WfcUFQbkeSA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0Rjf9gBju9Owq0OPEr4s3TA6dJ27eEEf92OhfYYSf6OOjz0AQT2pGmcntCzx?= =?us-ascii?Q?xTSA0vnwUrKeykJ2to04ZKBUJdd8+ZGRww9UEv5Te30VhRe01BwY5NRDCk+g?= =?us-ascii?Q?tRIY4Cw1QgpvCyr9VwbgBx6+d7gWyi8o3qy4yQXQ3LNwnc36jPTtHa1Ue2fH?= =?us-ascii?Q?tEOdX36J2o1Cmiqx/wFIh6WuceGzNO192HsB3ar3BbSqz4jOb/KXWafxkaCw?= =?us-ascii?Q?uC9Jc6SeNfV6/WddFXBFD0TlYSLxnciZbKVu+hkj0n2YlWrZpIEvz9fyd9lv?= =?us-ascii?Q?drX7qAcXH+SZm4Bg/dnsluBIcESAKdTZTc1YMJF1MbKZSXLRx/reUBODnzGl?= =?us-ascii?Q?6vN1psPpIJsu4yumBa/Hs62IP1hzX+xTkY9WbCmj0N6kCPFhYm+k+G+iy03v?= =?us-ascii?Q?tRLAN8QnuVCduc2exxOoo/8npMw6BZhaT8GF+tpbZKKDsnSriW61XG5eR0ql?= =?us-ascii?Q?WTGjGiQ4SqNHUUMZfpuG+kzrMXsAlPU/pcKUH+qFljhw7F6248tyfW5ntauP?= =?us-ascii?Q?bmJDFp6BINEjvx6ZybeY+EbPXRiavkuYXSmbrIZiLz9nZ5x99EZIkMhecKX1?= =?us-ascii?Q?M24p8InSvIpBWKCItW+W6AXrQqEugGvQ13uyzBQqJi3sgzBIFmYeBVmGJDzE?= =?us-ascii?Q?W52v8uR+Udk48fUIZgA/XT0T6s/I6fyHCgprCpifzP09eeTC+xquK//14gaG?= =?us-ascii?Q?YyTYYUPN/R+Te34qbJzv91jTt354lq/E9grzuVSoHjVTOIWG+1QoFKJHJ+pV?= =?us-ascii?Q?QMOzK3Ukdzwp0unGikX10cMXEl3RI/ZtcRLFep6uIghohW4i6WuYG2NP0TRe?= =?us-ascii?Q?gIbgS8ndHhCvhF4vkvX0A6mZHFrfdUzf67gGikZqgNuPkp6v6+Ye2WpGRrIc?= =?us-ascii?Q?pN4qecqOhA8bTnD+47h7JT9eroJDg48LGcSXi0u7hlcpPVlpjOCiIeJ+mzpQ?= =?us-ascii?Q?e4Wj/dGSfPrQkHh8+e7DQ9G2zfwuSQiQsyJILzPsIuHqbSN9O7B1XG6usdnx?= =?us-ascii?Q?1LHOTUQjfty9pkVLfWyuhX+JivDJmcfl9rwVYLgNA+8gcmSE0ZPNCuN8Ba3i?= =?us-ascii?Q?hYtdFmpdV2jZG5OBkZkwhVDA7DFWlg4P7Y7vETtI7V/daW+21rdNX2WZ+mPn?= =?us-ascii?Q?6ES9bXAgHOrP/4P5J32sqBltNhc1px8LJ85T75MtmOJBUEiV66Ov19jlNpY5?= =?us-ascii?Q?WAfYXZMoCTf+P/COq+9c+bXQprA+rxieg5/98Pc4s5EOSIz3wNORNAl0jQWX?= =?us-ascii?Q?U1grLCzCWlKUnPiLZSI1GQuUfNHQtAtDWbQj1nsK1th91DkwwUkdHgUPHZqz?= =?us-ascii?Q?rRE0PXJPCPl/MCDS2JzwOGWcKO9oM3Ub+wxaZqzDXjXdf/8uQyoMNwAp64Ub?= =?us-ascii?Q?dOYlvx8DjwDsReZgXADSXotFyIO3LmB1u7XykoMN83cXk4LZ6+1m37xv1y/3?= =?us-ascii?Q?/rH5NNa6aW2bCQDejYGwyafYY1u/ruPeHDUlon1aFG/TwMtHzBPNwo4/3BJ7?= =?us-ascii?Q?zx5DVVyJ1Zkp32+NIFaRGEWjuM0yCX/bUB/wq4nP7eGq5UU+UZEPLMyyNWue?= =?us-ascii?Q?k8BuY0OORIihmxtn07j6+kZWNzLa4E6zVfmkVRmuyeNV7cKTdH/qcmFJ9e5a?= =?us-ascii?Q?tA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0adf1b9a-c2a4-432a-55e0-08dcdaa20990 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 01:01:06.0757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SdeJDpLyMov76/jVkqotUZfDPxyvIH3F96j9ahHW5TlPsVFl9zzL666g1u7t8v+4GiqVP3eqKb3P234owiEW0E102+VZR3XUTXG3Bboocno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8684 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240921_180113_664516_7E0A9BCE X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alistair Popple wrote: > A FS DAX page is considered idle when its refcount drops to one. This > is currently open-coded in all file systems supporting FS DAX. Move > the idle detection to a common function to make future changes easier. > > Signed-off-by: Alistair Popple > Reviewed-by: Jan Kara > Reviewed-by: Christoph Hellwig Looks good to me: Reviewed-by: Dan Williams