From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D371F5580B for ; Mon, 20 Apr 2026 11:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YRg9YkWWDV4F09YB0wy+eAEhit+xLbJnq52E3U8BECY=; b=X8wMY1knhWkQPmL8V4J1Og1tmZ Swhn38TwE6r2ydVy1ldiZs4Z7Ap5XGYlOxp57LYR22koPVRCoCfZ4L13eq/dOAJPgelhY7jPDmX/E QJUgLFJc/795/CL0xyo2UsCP3R9lYz6WJ/mevekOW+cavJYY+Y+4a2mao7pIuTfuDQbzoOCt9WOsD x5XsqZ7RWf2Vnsz009DDv6jfrjlKs3ihqgHTXKEYQo21yzAvlrz1jOXLeXa2rGKgHF6/6p5IyQVfN hwH9T+HYIPsTwe5TSLh7GakoPLiqDdtgOCXt5CpTpPGxxYaa3UAmVBGwyWVZaKtCWM+xT4e+v558T phGcuChw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEmWP-00000006lys-2opu; Mon, 20 Apr 2026 11:10:33 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEmWM-00000006lxz-2RzX; Mon, 20 Apr 2026 11:10:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1776683428; bh=Z8VXFLlJoWE07bJb3Qbu/RqEB+C1PaoPjkKJ6JTdIvE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bHtv37ohJyNm91PWYAMTHaClPZy0Qbjyc490uOLIh7JS8wl3Yc6BxKPNc0krtv8qZ Zk9qpjPqQR0TnN/DqiuN3J+Xmc4i3TOn+1ncLIbOWgHdHtSI2LXu8pBwrzrhCFeLYr J2m5jpvmkc1+2AfOITp4QpNIFxAJ4auOSV7eygJ5XDeVU7aN4SeLq2oZBU8h8KzsWM ArngXbRl2wX523SOe/Zl/8e2SY9CK6farGUHT2ufeQLQKthCp2u+VM4UEcq5J/ho8I P+zGZ6zwYm2CEi6csbsynPhj1DiOIuLioC5tFDS6YTZT2XYjjlYqi9z1adIDZhZoEi OsN4R+x0R1RJg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 01A9C17E0595; Mon, 20 Apr 2026 13:10:27 +0200 (CEST) Message-ID: <66f9574c-8dff-4de2-bf54-20f1c1e64c24@collabora.com> Date: Mon, 20 Apr 2026 14:10:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/40] arm64: dts: rockchip: Wire up frl-enable-gpios for RK3576/RK3588 boards To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260417-dts-rk-frl-enable-gpios-v1-0-a19c0dd8c9f6@collabora.com> <2297365.1BCLMh4Saa@phil> <70e9a8a0-414d-428f-8da8-9b65cc764849@collabora.com> <2435759.n0HT0TaD9V@phil> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <2435759.n0HT0TaD9V@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260420_041030_770269_D7414081 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/18/26 2:18 AM, Heiko Stuebner wrote: > Hi Cristan, > > Am Freitag, 17. April 2026, 19:55:17 Mitteleuropäische Sommerzeit schrieb Cristian Ciocaltea: >> On 4/17/26 2:34 PM, Heiko Stuebner wrote: >>> Am Freitag, 17. April 2026, 11:24:34 Mitteleuropäische Sommerzeit schrieb Cristian Ciocaltea: >>> >>> [...] >>> >>>> Cristian Ciocaltea (40): >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-100ask-dshanpi-a1 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-armsom-sige5 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-evb1-v10 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-evb2-v10 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-luckfox-core3576 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-nanopi-m5 >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-nanopi-r76s >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-roc-pc >>>> arm64: dts: rockchip: Add frl-enable-gpios to rk3576-rock-4d >>> >>> I do think one patch per SoC (rk3576, rk3588, rk3588s) would make more >>> sense, because these patches really are mostly identical :-) >> >> Yeah, apologies for the large number of patches, I went this way to allow >> per-board reviews. As previously noted, I tried to identify the GPIO pins from >> multiple sources, so I'm not entirely sure about the accuracy in every case. >> >> Would it be preferable to squash the patches per SoC and board vendor, instead? > > I really would just do it per soc .. so 3 patches. That is a size that is > still reviewable for people, who can then check for their board. > > If the patch is labeled "Add frl-enable-gpios for all RK3588s boards", I > do expect people to notice it the same as "oh _my_ board gets changed". > ("all" could also be "most" :-) ). Ack. I would still keep the more invasive changes — such as those touching the regulator hacks — in separate patches, though. Thanks, Cristian