From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43059C4332F for ; Sat, 19 Mar 2022 14:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ukf8rI9gwNe8pGsmir0TxYwdzEQjWrpH7frIvdqPYK0=; b=fgOBap/spI9t0i Myya9gi5Sgu9opKrNm3/4wSw6/rn9EoaUXKGH3EwTyw8Y0GG9XhaHMpid0fDJFA69YkPmrDCaFzpw NUGuqlXf9cNrX10xQnOiz6HBcFX4jHLvv7UxnNV1QNzAWx+xq4kboMfeGoiv9QF3IhTVNDme39j9P Cxc9JacxVlUjwOEXdmn1IGt1e9ovmHQAIfhYiXWPk8b4U4wSz45cvd/3LWxjaOb817kwgAFQlMWoT kvHl77YLkAN+FXkw7XGjmMLc9FMxOyTlbUjUNPUR6EHTdS8tLJib/oG2dVAMEGAZ5mYKVAR1PoLrX l3h8IJ69MYJbzO3KBU3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVaDO-003vE4-21; Sat, 19 Mar 2022 14:37:58 +0000 Received: from mail-ed1-f52.google.com ([209.85.208.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVaDK-003vCf-3E for linux-arm-kernel@lists.infradead.org; Sat, 19 Mar 2022 14:37:55 +0000 Received: by mail-ed1-f52.google.com with SMTP id r23so13368551edb.0 for ; Sat, 19 Mar 2022 07:37:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=gH+r24fAOpSiIXUxUgbqmc3qpzbLfZoMAp2lb+50FuA=; b=g+DsjjtUxG5eghhh+nD9C1InfXIloyxHNTyDPQfsXpYIgFjKB8ZgxbEPK5gXx6Y0un Kxrjll1owMS6XWIawe0Lbyfa1+1RQYGBZQAoxXv2dy7Rbao8TXBPvaK9M2iC9npKjpsT QW7UTWbJpVY1lyt/yXST+2ZV3KHHJi2boosyCbmdfudYWVvT5s/I0bDkMxJsXqJcUL+e 0v+UhVgk5rY0VK/k9o04KefX8LBpgfyaW9TZcOa+yWR4BwgcMf9PTnJk3lLcdyqhA/rt 6FoI+uTluO4gHUXt8Fzh6lJCnfxsGdwKApZHj860HnAdskCu2fDF7ukZeUWKYo/WCQ1Q +72g== X-Gm-Message-State: AOAM532ZKRxD+UpzzZzGS2AycfrcA2zPlVeK36C+DGZiZuUgl9orx+gc Zu03n+Iyz//tSqig9xei/g3cbW+jFVw= X-Google-Smtp-Source: ABdhPJw3AzPtLQ+UjmKGVdKdQ4/84l1LKMcvSVPBB31aH0LaT4n0AZsECARqUGXu1wKRakT9dELALw== X-Received: by 2002:aa7:d6ca:0:b0:419:2804:d094 with SMTP id x10-20020aa7d6ca000000b004192804d094mr1757895edr.388.1647700672159; Sat, 19 Mar 2022 07:37:52 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id z21-20020a1709063a1500b006da6436819dsm4882063eje.173.2022.03.19.07.37.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Mar 2022 07:37:51 -0700 (PDT) Message-ID: <6729d4cd-45df-f554-708b-d353dc522cdf@kernel.org> Date: Sat, 19 Mar 2022 15:37:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp Content-Language: en-US To: Sherry Sun , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx References: <20220318113526.15986-1-sherry.sun@nxp.com> <57e516d4-68aa-44a6-4ea2-a7fdd4d9ed95@kernel.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220319_073754_180687_2738E329 X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/03/2022 10:53, Sherry Sun wrote: > Hi Krzysztof, > >> Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support >> EDAC on imx8mp >> >> On 18/03/2022 12:35, Sherry Sun wrote: >>> i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support for >>> i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver. >> >> One more point - I think it might be worth to add dedicated compatible for >> v3.70, as it is clearly a different version (with fallback to v3.80a). > > Thanks for the review, I have check the V3.70a and V3.80a Synopsys ddr controller databook, there is no difference for the inline ECC part. > So do you think we still need to add a new compatible for V3.70a even the EDAC driver operation is totally same with V3.80a? > Thanks for checking. In such case you don't have to add the compatible. It still might be beneficial in case there is some difference in hardware, but looks like not required. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel