From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE79C43381 for ; Wed, 6 Mar 2019 15:07:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17A59206DD for ; Wed, 6 Mar 2019 15:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aKHC9yA0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17A59206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ll9ArLi+VdhdB1kkbgrXHTc4muhspIyCcLc8I/khxIM=; b=aKHC9yA0aa+QES 4JLqzw6ex0o4wvtP7Cv8EirM0mB3UOfkafYLz9h4fMXBdSv/N+epr1vyNd9hU19Q9Qt+cwnP1tLNw QsfEzXIauZtrrdiHR1QdJJgyy6GvSJyfSCx8tsI8oIUpTvoo+ahaxtWvDwZ+b9FEKluFhlzg86tvQ +sx6BnISJ5ukXVUZw1Vo1cM+yNTehguvjgXE/IXnbh+5+tbFj5wm4jXf9ahgWU5hLLUPKwx6PDfNt iTmlY544Rr5z4dUCuyy3s+hUeCqI+QR0KnZZAYOZZCRrD3F7QX5W0yaHpGdKmwn1ksw/wpEZAql/8 q01thhqdS/TB+LnbrhYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Y8K-0003KX-63; Wed, 06 Mar 2019 15:07:00 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Y8E-0003K7-Rd for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 15:06:57 +0000 X-Originating-IP: 90.88.150.179 Received: from aptenodytes (aaubervilliers-681-1-31-179.w90-88.abo.wanadoo.fr [90.88.150.179]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7310E1BF20A; Wed, 6 Mar 2019 15:06:44 +0000 (UTC) Message-ID: <672c7eba534ca4b8008da6c5016a8c3881db5914.camel@bootlin.com> Subject: Re: [PATCH] drm/vc4: Use 16bpp by default for the fbdev buffer From: Paul Kocialkowski To: Maxime Ripard , Eric Anholt Date: Wed, 06 Mar 2019 16:06:44 +0100 In-Reply-To: <20190306140245.21973-1-maxime.ripard@bootlin.com> References: <20190306140245.21973-1-maxime.ripard@bootlin.com> Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_070655_043563_FC82B83C X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, Maarten Lankhorst , dri-devel@lists.freedesktop.org, Sean Paul , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2019-03-06 at 15:02 +0100, Maxime Ripard wrote: > The preferred bpp for the fbdev emulation buffer has been 32 so far, which > means that by default we will allocate an 8MB buffer with a 1920x1080 > resolution. > > Worse this memory will be allocated from the CMA pool, and will never be > freed even if we don't use the fbdev emulation. Therefore, reducing it is a > big deal, and switching to 16bpp by default will gain us around 4MB at > 1920x1080, while keeping decent color depth. And users still have the > option to switch to 32bpp using the kernel command line. > > Signed-off-by: Maxime Ripard Reviewed-by: Paul Kocialkowski Cheers, Paul > --- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > index 52576dee809e..c38cf64837e1 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.c > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > @@ -286,7 +286,7 @@ static int vc4_drm_bind(struct device *dev) > > vc4_kms_load(drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 16); > > return 0; > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel