linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 09/11] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX
Date: Mon, 17 Jun 2013 21:36:44 +0200	[thread overview]
Message-ID: <6736155.CBigTcsD4z@flatron> (raw)
In-Reply-To: <20130617160630.GF1403@sirena.org.uk>

On Monday 17 of June 2013 17:06:30 Mark Brown wrote:
> On Mon, Jun 17, 2013 at 03:59:39PM +0200, Linus Walleij wrote:
> > On Sun, Jun 16, 2013 at 10:54 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > > -       select S3C64XX_DMA if ARCH_S3C64XX
> > > +       select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080
> > 
> > I guess this means the SPI driver does not work without DMA.
> > But is the SPI driver already augmented to handle generic DMA engine?
> 
> > Anyway:
> Yes, the driver currently relies on DMA.  There are some pending patches
> for non-DMA operation that I need to test.  To be honest for both this
> and the ASoC driver I'd be more inclined to just either select or
> depend on the DMA controller rather than leaving the option of using
> the old code.

Well, I just left this for the purpose of this RFC, so testing things on 
both drivers would be possible (to see if any problems are caused by new 
driver or just by things that don't work).

If this driver turns out to be working correctly, I will happily remove 
the old private one and after s3c24xx moves to Heiko's DMA engine driver 
(or as it already moved?) we will be able to completely drop the private 
s3c-dma API.

Best regards,
Tomasz

  reply	other threads:[~2013-06-17 19:36 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16 20:54 [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA Tomasz Figa
2013-06-16 20:54 ` [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks Tomasz Figa
2013-06-17 13:25   ` Linus Walleij
2013-06-17 18:48   ` Russell King - ARM Linux
2013-06-17 18:56     ` Tomasz Figa
2013-06-18  7:47       ` Linus Walleij
2013-06-18 13:33         ` Arnd Bergmann
2013-06-16 20:54 ` [RFC PATCH 02/11] dma: amba-pl08x: Refactor pl08x_getbytes_chan() to lower indentation Tomasz Figa
2013-06-17 13:29   ` Linus Walleij
2013-06-16 20:54 ` [RFC PATCH 03/11] dma: amba-pl08x: Add support for different offset of CONFIG register Tomasz Figa
2013-06-17 13:31   ` Linus Walleij
2013-06-17 18:52   ` Russell King - ARM Linux
2013-06-17 19:02     ` Tomasz Figa
2013-06-16 20:54 ` [RFC PATCH 04/11] dma: amba-pl08x: Add support for PL080S variant Tomasz Figa
2013-06-17 13:39   ` Linus Walleij
2013-06-17 18:22     ` Tomasz Figa
2013-06-16 20:54 ` [RFC PATCH 05/11] dma: amba-pl08x: Add support for different maximum transfer size Tomasz Figa
2013-06-17 13:42   ` Linus Walleij
2013-06-17 18:27     ` Tomasz Figa
2013-06-16 20:54 ` [RFC PATCH 06/11] dma: amba-pl08x: Keep LLIs aligned to 4-word boundary Tomasz Figa
2013-06-17 13:51   ` Linus Walleij
2013-06-17 18:28     ` Tomasz Figa
2013-06-17 19:01     ` Russell King - ARM Linux
2013-06-16 20:54 ` [RFC PATCH 07/11] dmaengine: PL08x: Fix reading the byte count in cctl Tomasz Figa
2013-06-17 13:53   ` Linus Walleij
2013-06-17 18:32     ` Tomasz Figa
2013-06-17 19:03     ` Russell King - ARM Linux
2013-06-16 20:54 ` [RFC PATCH 08/11] dmaengine: PL08x: Add cyclic transfer support Tomasz Figa
2013-06-17 13:57   ` Linus Walleij
2013-06-17 18:52     ` Tomasz Figa
2013-06-17 18:56   ` Russell King - ARM Linux
2013-06-16 20:54 ` [RFC PATCH 09/11] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX Tomasz Figa
2013-06-17 13:59   ` Linus Walleij
2013-06-17 16:06     ` Mark Brown
2013-06-17 19:36       ` Tomasz Figa [this message]
2013-06-16 20:54 ` [RFC PATCH 10/11] ASoC: samsung: " Tomasz Figa
2013-06-17 14:01   ` Linus Walleij
2013-06-16 20:54 ` [RFC PATCH 11/11] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver Tomasz Figa
2013-06-17 14:04   ` Linus Walleij
2013-06-19 18:23     ` Tomasz Figa
2013-06-19 19:50       ` Linus Walleij
2013-06-17 14:06 ` [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA Linus Walleij
2013-06-17 19:38   ` Tomasz Figa
2013-06-19 17:40 ` Mark Brown
2013-06-19 18:26   ` Tomasz Figa
2013-06-19 19:01     ` Arnd Bergmann
2013-06-19 19:24       ` Mark Brown
2013-06-19 19:22     ` Mark Brown
2013-06-19 19:32       ` Tomasz Figa
2013-06-19 22:48         ` Mark Brown
2013-06-20  9:24       ` Phil Carmody
2013-06-20 10:35         ` Mark Brown
2013-06-20 11:14           ` Phil Carmody
2013-06-21  9:47             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6736155.CBigTcsD4z@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).