From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD96DC433F5 for ; Sat, 23 Apr 2022 06:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a7fEw6MeHYLfL63WfdNcK+LIcrWsb2o7pLEzLlBVi3o=; b=YpkIMaX/8HcRET EFQI8O3z+T2So3eQK7XIzl39r16l4txo8MslHgErjqcHZgyNkGVl+ZhIeQwQesXUSzeeGt6EOWxBu 7q9YrUg3z66fBR7HnWbxD/p2Vva1Hesa3N/Djyo+lGF+oRjTCjABBd4L4R/eI6fCgifRbuuvZk4cf 0Lzryo/vOXiam8NmyCa1UHoKIr68VIID1VsGFZkQL8MnfhDBvuqOyHGOmlLjtLoB1oXGTvfMqchIw TchwmaXsqIxpGHFXPtksO6UhwrFbHnHr6ZMyiNpOm5NUW7L+jAEATg4CkRaDjy/6XoIp0Yrf1X/oT ViIq+ObAEPI8IbRc97Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni9QZ-003Zqo-FH; Sat, 23 Apr 2022 06:39:31 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni9QV-003ZoF-J1 for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 06:39:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650695967; x=1682231967; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gVRIdH50VRkkOoW7Ed2DisHM8rizLUoP6GWfszv/o78=; b=Oo5EfltglhuofHlnd8uNwRKO+d3LmIgNIqIO7kcPIhT73b4TMWSn4oRT J3u9NyF9L1/pFaaA9ZOnqmIH+JS5wgKT90sRF7UJhnHgpQN3HpDzq3VHW r+TnA/DXZtKQ8RTwHv+OvnEpE/AKsSJRcsQOl0qvHqSxGVVTlGi0Aurmu XwUg8boeAr0Sc5xOFLYpJTrgn+yHIgaBXK9vLd5G7NpLUzomkX28jMKbG NsmNFTTh9fdny2TRGgKkdn6ybMyng8WWS0yBplV4uXR7aqZWtzv0ujw4w vHJhizlbQLTzrtOpPwQHWDgIw5VFVzItkZ4L71dSSp+o+dPJUct2eWDNM w==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="252191935" X-IronPort-AV: E=Sophos;i="5.90,283,1643702400"; d="scan'208";a="252191935" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 23:39:24 -0700 X-IronPort-AV: E=Sophos;i="5.90,283,1643702400"; d="scan'208";a="578293638" Received: from yjsun1-mobl.ccr.corp.intel.com (HELO [10.255.31.217]) ([10.255.31.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 23:39:17 -0700 Message-ID: <675db27a-94d4-f933-1fa1-0960d64f3ff2@linux.intel.com> Date: Sat, 23 Apr 2022 14:39:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v11 1/9] iommu: Introduce a callback to struct iommu_resv_region Content-Language: en-US To: Christoph Hellwig Cc: Shameer Kolothum , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, jon@solid-run.com, linuxarm@huawei.com, steven.price@arm.com, guohanjun@huawei.com, Sami.Mujawar@arm.com, will@kernel.org, wanghuiqiang@huawei.com References: <20220422162907.1276-1-shameerali.kolothum.thodi@huawei.com> <20220422162907.1276-2-shameerali.kolothum.thodi@huawei.com> <03e94ba9-f558-954f-e84b-cd8a9e693aea@linux.intel.com> From: Lu Baolu In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_233927_747404_2FFD5CB3 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/4/23 13:14, Christoph Hellwig wrote: > On Sat, Apr 23, 2022 at 10:04:39AM +0800, Lu Baolu wrote: >> The generic_iommu_put_resv_regions() itself is a callback. Why bothering >> adding another callback from the same iommu driver in it? Or, you are >> going to remove the put_resv_regions from the iommu ops? > > It is a driver method, but these reserved entries are not actually > allocated by the driver. And I do have a patch pending removing this > driver method that should never have been a driver method, check > the iomm list archives for > > iommu: remove the put_resv_regions method > Yeah! That's a good idea. Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel