From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ED2BC5320E for ; Sun, 25 Aug 2024 19:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:Subject:References:Cc:To:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bjgQi0W1Ld6Nlhe5ljDG2TAYgz7sHq4dy4igVOCgYto=; b=rBjSs80QFbFM4lFh2uSIspN2f0 qD0pDJ1hs38ga+MxWcxLzjbhN+ck0UxD3IlsL/S1ZbmT2h2NPHGc/5Cj6IMm8WEWjv/9rwcQFR8SK zB7+VWlGO3nHyuak8qczFc25jmoqCMz50tBtRqDyD+9X1rmHBuijpVWtfLo6+I+8L4FE3iAbP9R5g HiEoyYmJ3TFhOBPLlm4nTcxgLd5Wf1upnHHdS2oLR31UXjGKAKP25c1OivJhGjpwHcR5ifxgObZuN QTy27GXPLlAB2UmzZy8agjoHPgmYtPnC9D25FIyQXz8fn1hrgmoA6u5q7wYwDDEBq/3vOlrJplz7W 2nSFyEkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siJ2f-00000004v5h-06xG; Sun, 25 Aug 2024 19:36:49 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siJ1r-00000004uxv-2HRL for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 19:36:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1724614547; x=1725219347; i=markus.elfring@web.de; bh=bjgQi0W1Ld6Nlhe5ljDG2TAYgz7sHq4dy4igVOCgYto=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=w9v1seUk1qUDXIC7o/bDODS6lIRCAWpjvS3ZZyd7xNdA3le3N4EgrtyGbcTeM6RD wkL9opxXKf0ARg1r0UVgyUgFZer8LTTnVTiD17+crXNTyyNQ5G4XJ0BU/g2KTClxP PYhvVLY+PA3YJhoPZ7WMHOckcSQNmeJxQyGcvLnd5HR9mtN6/XFHyROuS8prf2kSj 13JPW15dx1+v/qQBuVsIYXx3MvJst+yYHO1zWmyAB6hFJg23C8EKEtoMWVvRl8ChA 4sSv15UxHdXDSNjWHlLWJsflIggpqWx/zNKOpxqJDPvG9XWcQOCaG3JyDy8RZ0XPB lCmO5LpvUdRxXM04uA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MTOhc-1sYVx904UO-00Kxby; Sun, 25 Aug 2024 21:35:47 +0200 Message-ID: <675f1e34-784f-44d2-9774-2652b919eecd@web.de> Date: Sun, 25 Aug 2024 21:35:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Krzysztof Kozlowski , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Arnd Bergmann , Boris Brezillon , Claudiu Beznea , Johan Hovold , Nicolas Ferre Cc: stable@vger.kernel.org, LKML References: <20240825183103.102904-1-krzysztof.kozlowski@linaro.org> Subject: Re: [PATCH] rtc: at91sam9: fix OF node leak in probe() error path Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240825183103.102904-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:arF0Zy4o4g6S4TXBWa3Il5wlniOMn4xA8VCzf0oURsxwtbIzve+ iKOgUnqiGBjOHqfuynzSeXIPRGjk/QOqymNVcCRPcxx38ID80jUbUNFGwQnZG59k6RoMhJ4 l4vPHRKq0uZ+JY8FoSiPGxLxyi5h6X0pazOUcGGuNVu/M/o7AqC8EoecVQF+5voLBc5tDn6 XErXOZRPNY9Hwc4N2/79Q== UI-OutboundReport: notjunk:1;M01:P0:B9gg9xDVWqM=;6Kjk/FwTmqmXIC1qZUbufPcza1g uVPi/dLQIWqzforFSCrnwuYVpD5/XS1SUEOAw1Sq75PM4JU8dwHN8N7g+zz22DPEixM/Vjd+a AzSLv7gEwPWY6UqPAZ7O+i+4dwSsFPxKqz8QExBZCuX2sVMA+KvxmfU4hXBlQFey63+UGJ7Q/ KCti/YVH13zybZqq+mFR9t6NGMjDc/gVMhnEzLnfe3Z9wd1kiuCWtK2kLAf2V62+hNGUscBno n05/jAlIRUNNXA3DF2ImuIeS1jgGXZNsPy8Xv+WL0ds/226uz6r6RZZFXVnLfaJuHxWU9rQtw GM1Upr1IuvlbQipWwG6eMsEA8pB1Je1wQbPTVl9t7C/45qWKgTXv2NpZl6IpLBp2CQ89Zw/Fz 3F64q8iJLCd5LpTdcVOd93NA8AbTRIiPMBhUXXG2l37DpcvbchT+4CFVgd8eVjqmcFY4CG3Ji p8YzcrwKKsl5bt09Xayzfjm3LSEoSEmzvHJEN1g+q+dSBGy1EoEMyoVhSA9iL2m0Kc35rbpm4 K4r8MoCZj2bJBmu9vDYbJLD4BLOhDgn+MuUI7DoIYrNsaVJ9+/I9axNFEBk9KBfZTBLdn5ehk 9eqp9VrJdmm12zjGKOz1LvfjFZ67Lp1CILN+jGkngABkURCuXKvHdRdyNkhIpFI3MzpVzgZea q2XRrhHSvPMQZTeMj95Gli6uvORMVVb/VLpYduhl1wxTngF/141p9lPnLoaCW+dSCYpeO6Ywx 2Bv3YbXmwxZKNQzm3ESWRU1SBjMT01RPRLQH/dxtMJ63vruAVSG5GCaEfrnIgvYU1HEgFDYif oMXZu0lRD63YiApC8tumtR2Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_123559_911928_9460A8B0 X-CRM114-Status: UNSURE ( 5.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Driver is leaking an OF node reference obtained from > of_parse_phandle_with_fixed_args(). Is there a need to improve such a change description another bit? + Imperative mood + Tags like =E2=80=9CFixes=E2=80=9D and =E2=80=9CCc=E2=80=9D Regards, Markus