From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF23C10F13 for ; Tue, 16 Apr 2019 14:50:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57AC520821 for ; Tue, 16 Apr 2019 14:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aB82wF/c"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=tronnes.org header.i=@tronnes.org header.b="qUrRpwSe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57AC520821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tronnes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KvEcXBqX1T+ckubyAZ5vOy2jRufdDRrF3wjzIGDCwaQ=; b=aB82wF/c0jo9sm 6WoR9ZC5k0/Ev9bjZKWeeE/GfQCLS0fq8CozUGNqGH/+dtuYeZbV5VNLJ2XryRWBefOFn18Ji6URg DAn0Oe22841mjRrk1wQYZRdEjrvmLN+xoByGjETSH4CjvBcnonELyMwa+Mh61+08lwVfqEBFA7mYj Csad5XDRLQ+3NJcFuZLjFVmIskCz5pHNkOGa2kLuAYjl1QfuIC2XmIL5ETIMYj0FxqPe788vSNbI6 4J6DIS5TejOJkK9NX2hZZ/IGjVDbVpbFUjGyGaA7idVY6khlxaS3+kowHgNvrT+/0RBaXHelzfxd1 s+SeRBk61DLtXFMd5S0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGPPZ-0002M3-Jh; Tue, 16 Apr 2019 14:50:13 +0000 Received: from smtp.domeneshop.no ([2a01:5b40:0:3005::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGPPV-0001uh-Ns for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 14:50:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org; s=ds201810; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=U4/1bOyJ4Q/x3TDli5Pdy7btHDEPIpEh7N2DuFmKrEY=; b=qUrRpwSelBMaUzLB2Ul+xEY4jvxI/onKVNx/Rp2059jPinIQ7+0UaN8HTj2MGrjL4Pe65wq9wkBN8gSJI/EIYnSAWvGJpd9uhxVLaMx0VBpGemIJibtboQvOSIEoI4kbozBGk/Ra/by64Bu9Kz6xojfT9+97O9Qdka50kApmms4M75KPH64RAL4lA6fi7IbEvywd6CAP40XM7w3/VOYA/KSjbSZFX8/uUz4ElfzlPF54jjnuKF837bbYja6sMd4o9MHm2EsjDnzwIiFnj6mTyaAdh8lbuoCfZXzAdzKFwNX1mBa/pjP6lR2ltT6+72wEjiPaz300KHQ2vAZRBOvmQQ==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:63601 helo=[192.168.10.179]) by smtp.domeneshop.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1hGPPQ-00041l-OA; Tue, 16 Apr 2019 16:50:04 +0200 Subject: Re: [PATCH v2 3/5] drm/modes: Allow to specify rotation and reflection on the commandline To: Maxime Ripard , Maarten Lankhorst , Sean Paul , Daniel Vetter , David Airlie References: <2afd45902d7e1e849d0aa7a0c4268c424cabe778.1554988934.git-series.maxime.ripard@bootlin.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <6785d207-bcfb-6723-22be-039c2b99edd4@tronnes.org> Date: Tue, 16 Apr 2019 16:50:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2afd45902d7e1e849d0aa7a0c4268c424cabe778.1554988934.git-series.maxime.ripard@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_075009_963172_20C9918D X-CRM114-Status: GOOD ( 24.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Kocialkowski , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , dri-devel@lists.freedesktop.org, eben@raspberrypi.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Den 11.04.2019 15.22, skrev Maxime Ripard: > Rotations and reflections setup are needed in some scenarios to initialise > properly the initial framebuffer. Some drivers already had a bunch of > quirks to deal with this, such as either a private kernel command line > parameter (omapdss) or on the device tree (various panels). > > In order to accomodate this, let's create a video mode parameter to deal > with the rotation and reflexion. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_fb_helper.c | 4 +- > drivers/gpu/drm/drm_modes.c | 110 +++++++++++++++++++++++++++------ > include/drm/drm_connector.h | 1 +- > 3 files changed, 95 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index b3a5d79436ae..8781897559b2 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -2521,6 +2521,7 @@ static void drm_setup_crtc_rotation(struct drm_fb_helper *fb_helper, > struct drm_connector *connector) > { > struct drm_plane *plane = fb_crtc->mode_set.crtc->primary; > + struct drm_cmdline_mode *mode = &connector->cmdline_mode; > uint64_t valid_mask = 0; > int i, rotation; > > @@ -2540,6 +2541,9 @@ static void drm_setup_crtc_rotation(struct drm_fb_helper *fb_helper, > rotation = DRM_MODE_ROTATE_0; > } > > + if (mode->rotation != DRM_MODE_ROTATE_0) > + fb_crtc->rotation = mode->rotation; > + We already have a property to describe initial display/panel rotation. If we can set connector->display_info.panel_orientation from the video= parameter, then there's no need to modify drm_fb_helper, it will just work. In that case, maybe 'orientation' is a better argument name with values mapped to the enum. And further, should we add the property (drm_connector_init_panel_orientation_property()) so DRM userspace can know about it to? Some pointers: - 8d70f395e6cb ("drm: Add support for a panel-orientation connector property") - 8f0cb418393b ("drm/fb-helper: Apply panel orientation connector prop to the primary plane") - drivers/gpu/drm/drm_panel_orientation_quirks.c Noralf. > /* > * TODO: support 90 / 270 degree hardware rotation, > * depending on the hardware this may require the framebuffer > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index 9613c1a28487..ac8d70b92b62 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -1531,6 +1531,71 @@ static int drm_mode_parse_cmdline_res_mode(const char *str, unsigned int length, > return 0; > } > > +static int drm_mode_parse_cmdline_options(char *str, size_t len, > + struct drm_connector *connector, > + struct drm_cmdline_mode *mode) > +{ > + unsigned int rotation = 0; > + char *sep = str; > + > + while ((sep = strchr(sep, ','))) { > + char *delim, *option; > + > + option = sep + 1; > + delim = strchr(option, '='); > + if (!delim) { > + delim = strchr(option, ','); > + > + if (!delim) > + delim = str + len; > + } > + > + if (!strncmp(option, "rotate", delim - option)) { > + const char *value = delim + 1; > + unsigned int deg; > + > + deg = simple_strtol(value, &sep, 10); > + > + /* Make sure we have parsed something */ > + if (sep == value) > + return -EINVAL; > + > + switch (deg) { > + case 0: > + rotation |= DRM_MODE_ROTATE_0; > + break; > + > + case 90: > + rotation |= DRM_MODE_ROTATE_90; > + break; > + > + case 180: > + rotation |= DRM_MODE_ROTATE_180; > + break; > + > + case 270: > + rotation |= DRM_MODE_ROTATE_270; > + break; > + > + default: > + return -EINVAL; > + } > + } else if (!strncmp(option, "reflect_x", delim - option)) { > + rotation |= DRM_MODE_REFLECT_X; > + sep = delim; > + } else if (!strncmp(option, "reflect_y", delim - option)) { > + rotation |= DRM_MODE_REFLECT_Y; > + sep = delim; > + } else { > + return -EINVAL; > + } > + } > + > + mode->rotation = rotation; > + > + return 0; > +} > + > /** > * drm_mode_parse_command_line_for_connector - parse command line modeline for connector > * @mode_option: optional per connector mode option > @@ -1558,9 +1623,10 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, > { > const char *name; > bool named_mode = false, parse_extras = false; > - unsigned int bpp_off = 0, refresh_off = 0; > + unsigned int bpp_off = 0, refresh_off = 0, options_off = 0; > unsigned int mode_end = 0; > char *bpp_ptr = NULL, *refresh_ptr = NULL, *extra_ptr = NULL; > + char *options_ptr = NULL; > char *bpp_end_ptr = NULL, *refresh_end_ptr = NULL; > int ret; > > @@ -1601,13 +1667,18 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, > mode->refresh_specified = true; > } > > + /* Locate the start of named options */ > + options_ptr = strchr(name, ','); > + if (options_ptr) > + options_off = options_ptr - name; > + > /* Locate the end of the name / resolution, and parse it */ > - if (bpp_ptr && refresh_ptr) { > - mode_end = min(bpp_off, refresh_off); > - } else if (bpp_ptr) { > + if (bpp_ptr) { > mode_end = bpp_off; > } else if (refresh_ptr) { > mode_end = refresh_off; > + } else if (options_ptr) { > + mode_end = options_off; > } else { > mode_end = strlen(name); > parse_extras = true; > @@ -1649,24 +1720,23 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, > else if (refresh_ptr) > extra_ptr = refresh_end_ptr; > > - if (extra_ptr) { > - if (!named_mode) { > - int len = strlen(name) - (extra_ptr - name); > + if (extra_ptr && > + extra_ptr != options_ptr) { > + int len = strlen(name) - (extra_ptr - name); > > - ret = drm_mode_parse_cmdline_extra(extra_ptr, len, > - connector, mode); > - if (ret) > - return false; > - } else { > - int remaining = strlen(name) - (extra_ptr - name); > + ret = drm_mode_parse_cmdline_extra(extra_ptr, len, > + connector, mode); > + if (ret) > + return false; > + } > > - /* > - * We still have characters to process, while > - * we shouldn't have any > - */ > - if (remaining > 0) > - return false; > - } > + if (options_ptr) { > + int len = strlen(name) - (options_ptr - name); > + > + ret = drm_mode_parse_cmdline_options(options_ptr, len, > + connector, mode); > + if (ret) > + return false; > } > > return true; > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 06aa3b9cb920..dfe7f2304b35 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -907,6 +907,7 @@ struct drm_cmdline_mode { > bool interlace; > bool cvt; > bool margins; > + unsigned int rotation; > enum drm_connector_force force; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel