linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros
@ 2025-06-27 13:13 A. Sverdlin
  2025-07-01 10:57 ` Sverdlin, Alexander
  0 siblings, 1 reply; 2+ messages in thread
From: A. Sverdlin @ 2025-06-27 13:13 UTC (permalink / raw)
  To: devicetree
  Cc: Alexander Sverdlin, Nishanth Menon, Vignesh Raghavendra,
	Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, linux-kernel

From: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Introduce ST_DISABLE and ST_ENABLE macros so that they can be used in
conjunction with PIN_INPUT* macros, e.g. (PIN_INPUT | ST_ENABLE).

Note that K3 might have quite strict input slew rate requirements and
all inputs actually have ST enabled on reset, but AM62PX_IOPAD macro
will not preserve this power-on default config. Therefore ST_ENABLE
is encouraged in many situations, especially if the input is to be
used as IRQ trigger.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-pinctrl.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
index cac7cccc11121..3e371be7b8062 100644
--- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
+++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
@@ -8,6 +8,7 @@
 #ifndef DTS_ARM64_TI_K3_PINCTRL_H
 #define DTS_ARM64_TI_K3_PINCTRL_H
 
+#define ST_EN_SHIFT		(14)
 #define PULLUDEN_SHIFT		(16)
 #define PULLTYPESEL_SHIFT	(17)
 #define RXACTIVE_SHIFT		(18)
@@ -44,6 +45,10 @@
 #define PIN_DEBOUNCE_CONF5	(5 << DEBOUNCE_SHIFT)
 #define PIN_DEBOUNCE_CONF6	(6 << DEBOUNCE_SHIFT)
 
+/* Schmitt trigger configuration */
+#define ST_DISABLE		(0 << ST_EN_SHIFT)
+#define ST_ENABLE		(1 << ST_EN_SHIFT)
+
 #define PIN_DS_FORCE_DISABLE		(0 << FORCE_DS_EN_SHIFT)
 #define PIN_DS_FORCE_ENABLE		(1 << FORCE_DS_EN_SHIFT)
 #define PIN_DS_IO_OVERRIDE_DISABLE	(0 << DS_IO_OVERRIDE_EN_SHIFT)
-- 
2.50.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros
  2025-06-27 13:13 [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros A. Sverdlin
@ 2025-07-01 10:57 ` Sverdlin, Alexander
  0 siblings, 0 replies; 2+ messages in thread
From: Sverdlin, Alexander @ 2025-07-01 10:57 UTC (permalink / raw)
  To: devicetree@vger.kernel.org
  Cc: kristo@kernel.org, robh@kernel.org, linux-kernel@vger.kernel.org,
	krzk+dt@kernel.org, nm@ti.com, vigneshr@ti.com,
	conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org

On Fri, 2025-06-27 at 15:13 +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Introduce ST_DISABLE and ST_ENABLE macros so that they can be used in
> conjunction with PIN_INPUT* macros, e.g. (PIN_INPUT | ST_ENABLE).
> 
> Note that K3 might have quite strict input slew rate requirements and
> all inputs actually have ST enabled on reset, but AM62PX_IOPAD macro
> will not preserve this power-on default config. Therefore ST_ENABLE
> is encouraged in many situations, especially if the input is to be
> used as IRQ trigger.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Please disregard in favour of patch
"arm64: dts: ti: k3-pinctrl: Enable Schmitt Trigger by default" [1].

[1] Link: https://lore.kernel.org/all/20250701105437.3539924-1-alexander.sverdlin@siemens.com/

> ---
>  arch/arm64/boot/dts/ti/k3-pinctrl.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> index cac7cccc11121..3e371be7b8062 100644
> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> @@ -8,6 +8,7 @@
>  #ifndef DTS_ARM64_TI_K3_PINCTRL_H
>  #define DTS_ARM64_TI_K3_PINCTRL_H
>  
> +#define ST_EN_SHIFT		(14)
>  #define PULLUDEN_SHIFT		(16)
>  #define PULLTYPESEL_SHIFT	(17)
>  #define RXACTIVE_SHIFT		(18)
> @@ -44,6 +45,10 @@
>  #define PIN_DEBOUNCE_CONF5	(5 << DEBOUNCE_SHIFT)
>  #define PIN_DEBOUNCE_CONF6	(6 << DEBOUNCE_SHIFT)
>  
> +/* Schmitt trigger configuration */
> +#define ST_DISABLE		(0 << ST_EN_SHIFT)
> +#define ST_ENABLE		(1 << ST_EN_SHIFT)
> +
>  #define PIN_DS_FORCE_DISABLE		(0 << FORCE_DS_EN_SHIFT)
>  #define PIN_DS_FORCE_ENABLE		(1 << FORCE_DS_EN_SHIFT)
>  #define PIN_DS_IO_OVERRIDE_DISABLE	(0 << DS_IO_OVERRIDE_EN_SHIFT)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-01 11:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-27 13:13 [PATCH] arm64: dts: ti: k3-pinctrl: Introduce Schmitt Trigger macros A. Sverdlin
2025-07-01 10:57 ` Sverdlin, Alexander

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).