From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CE3C433E0 for ; Mon, 25 May 2020 06:58:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5617D2071A for ; Mon, 25 May 2020 06:58:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S2eUX+zw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5617D2071A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iwr/3xRGdDfPdUFFp178xboa4vma9gAYI8CYcsM/lXA=; b=S2eUX+zwaUyYye DcjkHQLwt033nuT+6ZEO/asSk43kPGqlEcKoeS8siF3NwBIMvshZ5ssVc7uH99ANlxjDay9wUnvj2 0dXfhUzUiSkNPXpxdTqytTWSPI8J1+lt/n4BgNafyJnG4JKg4kSy4Djjqg8Q2wc/Do75s91S+bucF XIhOQHSGPQFqejYsP2I7LkHTKZOvs9fIVAawjJbWlKPu/6hOv5QOwbNa08lyMXAEruHZJaR0LvWed Rw0uKlR31VSBkam5iqiIOdEbRRH6R1Oig16lc7Z8NLusvssNTVzGRh6aQA9PlYFYXJWc/FSjF5X1E aGJuOHqEPdqnWNWltMkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd73v-0005vE-C9; Mon, 25 May 2020 06:58:15 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd73s-0005uN-Ab for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 06:58:14 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 968702E8603D2EE3E816; Mon, 25 May 2020 14:58:07 +0800 (CST) Received: from [127.0.0.1] (10.173.220.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 25 May 2020 14:58:00 +0800 Subject: Re: [PATCH v2 3/6] arm64: Add tlbi_user_level TLB invalidation helper To: Catalin Marinas References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-4-yezhenyu2@huawei.com> <20200522154925.GE26492@gaia> From: Zhenyu Ye Message-ID: <67ac92a2-d37b-d472-3cbc-0bc855235c3f@huawei.com> Date: Mon, 25 May 2020 14:57:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200522154925.GE26492@gaia> X-Originating-IP: [10.173.220.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200524_235813_335975_C49CB5F9 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, linux-mm@kvack.org, guohanjun@huawei.com, will@kernel.org, linux-arch@vger.kernel.org, yuzhao@google.com, aneesh.kumar@linux.ibm.com, steven.price@arm.com, arm@kernel.org, Dave.Martin@arm.com, arnd@arndb.de, suzuki.poulose@arm.com, npiggin@gmail.com, zhangshaokun@hisilicon.com, broonie@kernel.org, rostedt@goodmis.org, prime.zeng@hisilicon.com, kuhn.chenqun@huawei.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, xiexiangyou@huawei.com, linux-kernel@vger.kernel.org, maz@kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/5/22 23:49, Catalin Marinas wrote: > On Thu, Apr 23, 2020 at 09:56:53PM +0800, Zhenyu Ye wrote: >> @@ -190,8 +196,8 @@ static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, >> unsigned long addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); >> >> dsb(ishst); >> - __tlbi(vale1is, addr); >> - __tlbi_user(vale1is, addr); >> + __tlbi_level(vale1is, addr, 0); >> + __tlbi_user_level(vale1is, addr, 0); >> } > > This one remains with a level 0 throughout the series. Is this > intentional? If we can't guarantee the level here, better to use the > non-level __tlbi(). > OK, I will change it back to non-level __tlbi(). Thanks, Zhenyu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel