linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Alain Volmat <avolmat@me.com>, <patrice.chotard@st.com>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/12] ARM: dts: sti: move usb picophy nodes out of soc in stih418.dtsi
Date: Thu, 10 Feb 2022 09:37:45 +0100	[thread overview]
Message-ID: <67b2631d-cd30-ab7a-7066-33f04604316d@foss.st.com> (raw)
In-Reply-To: <20211202075105.195664-11-avolmat@me.com>

Hi Alain

On 12/2/21 08:51, Alain Volmat wrote:
> Move the usb2_picophy1 and usb2_picophy2 nodes out of the soc section.
> Since they are controlled via syscfg, there is no reg property needed,
> which is required when having the node within the soc section.
> 
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
>  arch/arm/boot/dts/stih418.dtsi | 38 ++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih418.dtsi b/arch/arm/boot/dts/stih418.dtsi
> index 97eda4392fbe..b35b9b7a7ccc 100644
> --- a/arch/arm/boot/dts/stih418.dtsi
> +++ b/arch/arm/boot/dts/stih418.dtsi
> @@ -26,31 +26,29 @@ cpu@3 {
>  		};
>  	};
>  
> +	usb2_picophy1: phy2 {
> +		compatible = "st,stih407-usb2-phy";
> +		#phy-cells = <0>;
> +		st,syscfg = <&syscfg_core 0xf8 0xf4>;
> +		resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> +			 <&picophyreset STIH407_PICOPHY0_RESET>;
> +		reset-names = "global", "port";
> +	};
> +
> +	usb2_picophy2: phy3 {
> +		compatible = "st,stih407-usb2-phy";
> +		#phy-cells = <0>;
> +		st,syscfg = <&syscfg_core 0xfc 0xf4>;
> +		resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> +			 <&picophyreset STIH407_PICOPHY1_RESET>;
> +		reset-names = "global", "port";
> +	};
> +
>  	soc {
>  		rng11: rng@8a8a000 {
>  			status = "disabled";
>  		};
>  
> -		usb2_picophy1: phy2@0 {
> -			compatible = "st,stih407-usb2-phy";
> -			reg = <0 0>;
> -			#phy-cells = <0>;
> -			st,syscfg = <&syscfg_core 0xf8 0xf4>;
> -			resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> -				 <&picophyreset STIH407_PICOPHY0_RESET>;
> -			reset-names = "global", "port";
> -		};
> -
> -		usb2_picophy2: phy3@0 {
> -			compatible = "st,stih407-usb2-phy";
> -			reg = <0 0>;
> -			#phy-cells = <0>;
> -			st,syscfg = <&syscfg_core 0xfc 0xf4>;
> -			resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
> -				 <&picophyreset STIH407_PICOPHY1_RESET>;
> -			reset-names = "global", "port";
> -		};
> -
>  		ohci0: usb@9a03c00 {
>  			compatible = "st,st-ohci-300x";
>  			reg = <0x9a03c00 0x100>;
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-10  8:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  7:50 [PATCH 00/12] ARM: dts: sti: various DT fixes to avoid warnings Alain Volmat
2021-12-02  7:50 ` [PATCH 01/12] ARM: dts: sti: ensure unique unit-address in stih407-clock Alain Volmat
2022-02-10  8:35   ` Patrice CHOTARD
2021-12-02  7:50 ` [PATCH 02/12] ARM: dts: sti: ensure unique unit-address in stih410-clock Alain Volmat
2022-02-10  8:36   ` Patrice CHOTARD
2021-12-02  7:50 ` [PATCH 03/12] ARM: dts: sti: ensure unique unit-address in stih418-clock Alain Volmat
2022-02-10  8:36   ` Patrice CHOTARD
2021-12-02  7:50 ` [PATCH 04/12] ARM: dts: sti: move some nodes out of the soc section in stih407-family.dtsi Alain Volmat
2022-02-10  8:36   ` Patrice CHOTARD
2021-12-02  7:50 ` [PATCH 05/12] ARM: dts: sti: update stih410-b2260 following stih407-family DT update Alain Volmat
2022-02-10  8:36   ` Patrice CHOTARD
2021-12-02  7:50 ` [PATCH 06/12] ARM: dts: sti: update stih418-b2199 " Alain Volmat
2022-02-10  8:37   ` Patrice CHOTARD
2021-12-02  7:51 ` [PATCH 07/12] ARM: dts: sti: update stihxxx-b2120 " Alain Volmat
2022-02-10  8:37   ` Patrice CHOTARD
2021-12-02  7:51 ` [PATCH 08/12] ARM: dts: sti: remove delta node from stih410.dtsi Alain Volmat
2022-02-10  8:37   ` Patrice CHOTARD
2021-12-02  7:51 ` [PATCH 09/12] ARM: dts: sti: move usb picophy nodes out of soc in stih410.dtsi Alain Volmat
2022-02-10  8:37   ` Patrice CHOTARD
2021-12-02  7:51 ` [PATCH 10/12] ARM: dts: sti: move usb picophy nodes out of soc in stih418.dtsi Alain Volmat
2022-02-10  8:37   ` Patrice CHOTARD [this message]
2021-12-02  7:51 ` [PATCH 11/12] ARM: dts: sti: move usb picophy nodes in stih410-b2120.dts Alain Volmat
2022-02-10  8:57   ` Patrice CHOTARD
2021-12-02  7:51 ` [PATCH 12/12] ARM: dts: sti: move usb picophy nodes in stih410-b2260.dts Alain Volmat
2022-02-10  8:38   ` Patrice CHOTARD
2022-02-10  8:59 ` [PATCH 00/12] ARM: dts: sti: various DT fixes to avoid warnings Patrice CHOTARD
2022-02-11 18:13   ` Alain Volmat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67b2631d-cd30-ab7a-7066-33f04604316d@foss.st.com \
    --to=patrice.chotard@foss.st.com \
    --cc=avolmat@me.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=patrice.chotard@st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).