From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA94C43381 for ; Thu, 28 Mar 2019 11:07:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED3B620700 for ; Thu, 28 Mar 2019 11:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BilTbA/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED3B620700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=33iqKV9r7MHABA1oj17L+yd1+cR55KaFXLjSuPKtaLI=; b=BilTbA/CH5EVfl6Tj0SXook2e p0cOm2A99QxhlVxZCo4llnUDxNeYqX4wjU0rtD7s9h92wArb4ot9TlQExfvmQHhlVCA2SEYJ4Zgns BCjzPS27tBNtvnGFelrqaHKneUagDn+qwn9UqzOhV1DJ890TKiz1PMrvjzgfpJV0A+JwNz1MObHr0 TC+fXlBPNWei8lpAXbKe8qktMU+N6AeJaHzRM/u6Yg/cPi9r4TvlaVxxNi/olm5U8eGK7W8f8Q1gW iulPG2srbp5kqxnew2UYCHlIo6alOcDtdIwUjo9Pw25oCz/yHSh8gkQzQlFzY1vzEE49kw/l63MUk eO8T82H1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9SsB-0004YU-2X; Thu, 28 Mar 2019 11:07:03 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Ss8-0004YB-9S for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 11:07:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76E3715AB; Thu, 28 Mar 2019 04:06:59 -0700 (PDT) Received: from [10.37.12.55] (unknown [10.37.12.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63F5C3F59C; Thu, 28 Mar 2019 04:06:57 -0700 (PDT) Subject: Re: [PATCH 13/25] coresight: etb10: Clean up device specific data To: mathieu.poirier@linaro.org References: <1553107783-3340-1-git-send-email-suzuki.poulose@arm.com> <1553107783-3340-14-git-send-email-suzuki.poulose@arm.com> <20190327213903.GA778@xps15> From: Suzuki K Poulose Message-ID: <67c7b74e-62d9-1f73-0622-b861af44c6b4@arm.com> Date: Thu, 28 Mar 2019 11:09:12 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190327213903.GA778@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_040700_337318_A1499471 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/27/2019 09:39 PM, Mathieu Poirier wrote: > On Wed, Mar 20, 2019 at 06:49:30PM +0000, Suzuki K Poulose wrote: >> Track the coresight device instead of the real device. >> >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> >> @@ -701,7 +701,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) >> if (!drvdata) >> return -ENOMEM; >> >> - drvdata->dev = &adev->dev; >> drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ >> if (!IS_ERR(drvdata->atclk)) { >> ret = clk_prepare_enable(drvdata->atclk); >> @@ -740,6 +739,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) >> if (IS_ERR(drvdata->csdev)) >> return PTR_ERR(drvdata->csdev); >> >> + drvdata->dev = &drvdata->csdev->dev; > > For patch 11, 12, 13 - same comment as earlier. Let's use drvdata::csdev > and get rid of drvdata::dev. > Sure, will do. Thanks for the detailed review ! Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel