From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56148C00319 for ; Tue, 5 Mar 2019 17:27:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29A5F20661 for ; Tue, 5 Mar 2019 17:27:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p1M25wh/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YCjgZBKX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A5F20661 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zenQbwFRcHDOltjiECBoOUmbRu6/5NvsdR+t1DkyqAU=; b=p1M25wh/X79/qH USUBQqIan5VYs2QGFJs7VXwJ3IIXYrcjCvsiCNlnxLYlC8SLorgJBEJETJbR1LWjlNeKAidGdzm11 dCT6GxQNvUwx3h628KoV2+ETtWw6E2TIZB3rEugX1JXw1mGb9YcRBQtzAvTou5VC5IKX+h7VSlTxD kQsXsJzzaULoScxVPl99Y+fND08zthfbJXPQlobJ1MXxuclEc4WxUTIyjzkC+ZqX+wetZNfCda0Wb 1I9yjC+ulRYo2P2rN2RCbPeWjizFCcUMAbAkNUZAOuQgkG5lpWoAGs91qJ9Fy/ivDw40DMHjIhz8b Ax60XlWZcFOmrSwUy+pQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1DqY-0000hf-15; Tue, 05 Mar 2019 17:27:18 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1DqU-0000hC-Sb for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 17:27:16 +0000 Received: by mail-pg1-x541.google.com with SMTP id b2so6073220pgl.9 for ; Tue, 05 Mar 2019 09:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Tw8B+9dl5M+qG13zllqE3uJafdO3lFaK6AkwIiiHLA=; b=YCjgZBKXK8fZt4TGt9pxlRE20txRF4XbadKVLvDfg7bL/+7OatY9gTVQ5YW5fUQq+0 0tVRrT62VNn4968dKncr6pIushx58f/OuliV2o3PiCjUwUhCDSIe8+oa9DMeW29auxwv ChwLRxQkV8tcR5EsrSDOHEjZf6m1k0gTR9ROg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Tw8B+9dl5M+qG13zllqE3uJafdO3lFaK6AkwIiiHLA=; b=SVib7ulnSTOcU4maDAvdwhcIIn/QMULJnDxW/uLcUraBs+WE+PTbwQw8HbspTEya0h hQ4jOlAYVr/C5r7mMNFTGAiz5QfEJTAhOp1v8wLt2k98Vu02xc5DJ2t/6UEj8V5DejZl ga8rYD5fEmVSHnPEt4lo8aHpRnGms6OXhsmThxgVl2kd1NbOSDRV2exVabX3DSTbsnal o6WTriHAvrBbvsvt1bXHgMPD3HUofg4ktWI1d7a8LEjOqiLtGnjo908NLclf71l4CD67 MpT7EcLXl4KqzWZTSNOUj/7iubY8Gp+y7ceLiOGGk3Jg/DA9wSJyZ80ltkFHaNaI9rJr OdOA== X-Gm-Message-State: APjAAAXUx6GbICiWzL08BHOn3Ydo5+wazOaYFRtsG3QbCsaI/blSU2eH l5PcwfV4rPbo/HlrPBOBXdgLX0K8T6YpGp8FmAihwPDvZNYBQOJKOjlLPmS9Jt5zZKX+QSv6la3 S6IwdWStduGLIzmhe668O5Ca/GynshPw9+gWLY5u0CgQLZYlw+pYYutoflePF3CuoidrntYPDEj hC2aEZTVb2mOw= X-Google-Smtp-Source: APXvYqynNU5AEbhzX5gpwi/uLwYHOpYIYu2e1qbuRGYbF/0+kvCi5ljzvKen/ONB1mfstEFng4hddw== X-Received: by 2002:a63:d205:: with SMTP id a5mr2372488pgg.142.1551806832665; Tue, 05 Mar 2019 09:27:12 -0800 (PST) Received: from [10.136.8.252] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id y6sm19786029pfy.87.2019.03.05.09.27.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 09:27:11 -0800 (PST) Subject: Re: [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node_put To: Wen Yang , linux-kernel@vger.kernel.org References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> <1551785646-46173-2-git-send-email-wen.yang99@zte.com.cn> From: Ray Jui Message-ID: <67d1be96-ad8a-a453-996f-731a363677ae@broadcom.com> Date: Tue, 5 Mar 2019 09:24:05 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1551785646-46173-2-git-send-email-wen.yang99@zte.com.cn> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_092714_924247_5EB3EDB4 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wang.yi59@zte.com.cn, Florian Fainelli , Scott Branden , Ray Jui , Russell King , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/5/2019 3:33 AM, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > v2->v1: add a missing space between "adding" and "missing" > > arch/arm/mach-bcm/board_bcm281xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-bcm/board_bcm281xx.c b/arch/arm/mach-bcm/board_bcm281xx.c > index b81bb38..1238ac8 100644 > --- a/arch/arm/mach-bcm/board_bcm281xx.c > +++ b/arch/arm/mach-bcm/board_bcm281xx.c > @@ -38,6 +38,7 @@ static void bcm281xx_restart(enum reboot_mode mode, const char *cmd) > return; > } > base = of_iomap(np_wdog, 0); > + of_node_put(np_wdog); > if (!base) { > pr_emerg("Couldn't map brcm,kona-wdt\n"); > return; > Change looks good to me. Thanks! Acked-by: Ray Jui _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel