From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98420C433E6 for ; Fri, 29 Jan 2021 15:13:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44A4064E02 for ; Fri, 29 Jan 2021 15:13:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A4064E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6mcVf48wte40sy3dYjD+mUifcX3gZ8CD/BnVAXGffC4=; b=lQ2ljHz3boMgvmFQ2s8Xn1JYX 0CLY46vnu022r+x2JKVOzrEkbhS3humDkpbAO60PjxVvX90Vk0QJcRO98Msow6NFuhaAUC96Dz5/a aFofjoKK46YeSDwVDQo8/gXZXAMLTYAmoF+8PI7H/+Po4KFzNmWkNxcy94soKiEGWK7hdC/8ArZ9/ XTtKYwZ+0KmalnEXQ51fRCvAOFKc3CvwrgyywRh+VvvMPdnctZ8cns5UUJF7ioBujCkqUJM91siCB Zg/Oo/rAFAeKyrOPOlj1bDjD9e+uXbqmK4mkWtqso/ss0YWSlquT70yXnSaaNDjooPhBNXANQm8fI VH9IMJr1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5VRs-0002rr-J3; Fri, 29 Jan 2021 15:12:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5VRp-0002r9-Pd for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 15:12:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 333D213D5; Fri, 29 Jan 2021 07:12:25 -0800 (PST) Received: from [10.57.35.163] (unknown [10.57.35.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B382F3F71B; Fri, 29 Jan 2021 07:12:23 -0800 (PST) Subject: Re: [PATCH v3 2/3] perf/smmuv3: Add a MODULE_SOFTDEP() to indicate dependency on SMMU To: Zhen Lei , Will Deacon , Mark Rutland , Joerg Roedel , linux-arm-kernel , iommu , linux-kernel References: <20210127113258.1421-1-thunder.leizhen@huawei.com> <20210127113258.1421-3-thunder.leizhen@huawei.com> From: Robin Murphy Message-ID: <67e0859b-2633-3516-527f-57557e210fa1@arm.com> Date: Fri, 29 Jan 2021 15:12:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210127113258.1421-3-thunder.leizhen@huawei.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_101233_910878_0EE860FA X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , Shameer Kolothum Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-01-27 11:32, Zhen Lei wrote: > The MODULE_SOFTDEP() gives user space a hint of the loading sequence. And > when command "modprobe arm_smmuv3_pmu" is executed, the arm_smmu_v3.ko is > automatically loaded in advance. Why do we need this? If probe order doesn't matter when both drivers are built-in, why should module load order? TBH I'm not sure why we even have a Kconfig dependency on ARM_SMMU_V3, given that the drivers operate completely independently :/ Robin. > Signed-off-by: Zhen Lei > --- > drivers/perf/arm_smmuv3_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c > index e5e505a0804fe53..9a305ac51208cd2 100644 > --- a/drivers/perf/arm_smmuv3_pmu.c > +++ b/drivers/perf/arm_smmuv3_pmu.c > @@ -950,6 +950,7 @@ static void __exit arm_smmu_pmu_exit(void) > module_exit(arm_smmu_pmu_exit); > > MODULE_DESCRIPTION("PMU driver for ARM SMMUv3 Performance Monitors Extension"); > +MODULE_SOFTDEP("pre: arm_smmu_v3"); > MODULE_AUTHOR("Neil Leeder "); > MODULE_AUTHOR("Shameer Kolothum "); > MODULE_LICENSE("GPL v2"); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel