From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Nava kishore Manne <nava.manne@xilinx.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, jollys@xilinx.com, rajanv@xilinx.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver
Date: Sun, 3 Feb 2019 09:38:10 +0000 [thread overview]
Message-ID: <67e2af69-10bc-655c-e730-4c02a6375381@linaro.org> (raw)
In-Reply-To: <20190204070951.6933-4-nava.manne@xilinx.com>
On 04/02/2019 07:09, Nava kishore Manne wrote:
>
> -config SC27XX_EFUSE
> - tristate "Spreadtrum SC27XX eFuse Support"
> - depends on MFD_SC27XX_PMIC || COMPILE_TEST
> - depends on HAS_IOMEM
Why are you removing SC27XX_EFUSE support here?
It does not look right!
> +config NVMEM_ZYNQMP
> + bool "Xilinx ZYNQMP SoC nvmem firmware support"
> + depends on ARCH_ZYNQMP
> help
> - This is a simple driver to dump specified values of Spreadtrum
> - SC27XX PMICs from eFuse.
> + This is a driver to access hardware related data like
> + soc revision, IDCODE... etc by using the firmware
> + interface.
>
> - This driver can also be built as a module. If so, the module
> - will be called nvmem-sc27xx-efuse.
> + If sure, say yes. If unsure, say no.
>
> endif
> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile
> index 4e8c61628f1a..0b3abd7f5d02 100644
> --- a/drivers/nvmem/Makefile
> +++ b/drivers/nvmem/Makefile
> @@ -39,5 +39,6 @@ obj-$(CONFIG_NVMEM_SNVS_LPGPR) += nvmem_snvs_lpgpr.o
> nvmem_snvs_lpgpr-y := snvs_lpgpr.o
> obj-$(CONFIG_RAVE_SP_EEPROM) += nvmem-rave-sp-eeprom.o
> nvmem-rave-sp-eeprom-y := rave-sp-eeprom.o
> -obj-$(CONFIG_SC27XX_EFUSE) += nvmem-sc27xx-efuse.o
> -nvmem-sc27xx-efuse-y := sc27xx-efuse.o
same here?
> +obj-$(CONFIG_NVMEM_ZYNQMP) += nvmem_zynqmp_nvmem.o
> +nvmem_zynqmp_nvmem-y := zynqmp_nvmem.o
> +
--srini
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-03 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 7:09 [PATCH v2 0/3] Add nvmem driver support for ZynqMP Nava kishore Manne
2019-02-04 7:09 ` [PATCH v2 1/3] firmware: xilinx: Add zynqmp_pm_get_chipid() API Nava kishore Manne
2019-02-03 8:50 ` Srinivas Kandagatla
2019-02-05 10:29 ` Michal Simek
2019-02-05 10:33 ` Srinivas Kandagatla
2019-02-05 10:36 ` Michal Simek
2019-02-04 7:09 ` [PATCH v2 2/3] dt-bindings: nvmem: Add bindings for ZynqMP nvmem driver Nava kishore Manne
2019-02-04 7:09 ` [PATCH v2 3/3] nvmem: zynqmp: Added zynqmp nvmem firmware driver Nava kishore Manne
2019-02-03 9:38 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e2af69-10bc-655c-e730-4c02a6375381@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox