From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: "Frank Wunderlich" <frank-w@public-files.de>,
"Chaotian Jing" <chaotian.jing@mediatek.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Wenbin Mei" <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: mmc: mtk-sd: Set clocks based on compatible
Date: Sun, 23 Oct 2022 08:56:38 -0400 [thread overview]
Message-ID: <67e4c08c-f03c-fcaf-60d2-fffb87a69a9d@linaro.org> (raw)
In-Reply-To: <20221023091247.70586-3-linux@fw-web.de>
On 23/10/2022 05:12, Frank Wunderlich wrote:
> From: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> The binding was describing a single clock list for all platforms, but
> that's not really suitable:
>
> Most platforms using at least 2 clocks (source, hclk), some of them
> a third "source_cg". Mt2712 requires an extra 'bus_clk' on some of
> its controllers, while mt8192 requires 8 clocks.
>
> Move the clock definitions inside if blocks that match on the
> compatibles.
>
> I used Patch from Nícolas F. R. A. Prado and modified it to not using
> "not" statement.
>
> Fixes: 59a23395d8aa ("dt-bindings: mmc: Add support for MT8192 SoC")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-23 12:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 9:12 [PATCH v3 0/7] Add mmc-support for mt7986 Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 1/7] dt-bindings: mmc: Add compatible for Mediatek MT7986 Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 2/7] dt-bindings: mmc: mtk-sd: Set clocks based on compatible Frank Wunderlich
2022-10-23 12:56 ` Krzysztof Kozlowski [this message]
2022-10-24 16:43 ` Nícolas F. R. A. Prado
2022-10-24 18:42 ` Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 Frank Wunderlich
2022-10-23 12:56 ` Krzysztof Kozlowski
2022-10-24 14:55 ` Aw: " Frank Wunderlich
2022-10-24 16:48 ` Krzysztof Kozlowski
2022-10-23 9:12 ` [PATCH v3 4/7] arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 5/7] arm64: dts: mt8183: drop drv-type from mmc-node Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 6/7] arm64: dts: mt7622: drop r_smpl property from mmc node Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 7/7] mmc: mediatek: add support for MT7986 SoC Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e4c08c-f03c-fcaf-60d2-fffb87a69a9d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).