From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51A4EC00140 for ; Mon, 15 Aug 2022 14:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sR8bHV/2VsnogoWxZJD+bGltk/6invcqiHr1G7M4bzE=; b=o+/Hdf5hMY9CXG gzSVSzRhk+7PddQVYNayBLhGi2HFiDGoV1GOUyZK1va0Wz9v13AenAHM2UfqQdGlBZC218wAZDOMB +VG7nUrSNV8ljkChVG9kYZOEjOWdJ6YqGyXduLhTqxiV7A6wK0mj55uTFzVokQZfXa9EDqk1wQlVM aoPj7Xki0GrZsWoPcXHzA3LszNUejKUTb3fRm8R/piFMaql1ZuFz1nUwL931s4aGwYSQ5v81w1ETU lm3ThyQbyIQBcryoUHQPDB0YygoyjlUloc7tfseA0c9E4HW1I4ml+u92lpkLkihrd6NLaTjkxwTv0 lsS50GC8PAtzMRLU3LTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNb4k-00Haza-C7; Mon, 15 Aug 2022 14:28:18 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNaji-00HGgw-HK for linux-arm-kernel@lists.infradead.org; Mon, 15 Aug 2022 14:06:36 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oNajc-00043b-0N; Mon, 15 Aug 2022 16:06:28 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org Cc: Samuel Holland , Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Samuel Holland Subject: Re: [PATCH v2 05/10] soc: sunxi: sram: Fix probe function ordering issues Date: Mon, 15 Aug 2022 16:06:27 +0200 Message-ID: <6807552.18pcnM708K@diego> In-Reply-To: <20220815041248.53268-6-samuel@sholland.org> References: <20220815041248.53268-1-samuel@sholland.org> <20220815041248.53268-6-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220815_070634_642991_906CCE55 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 15. August 2022, 06:12:42 CEST schrieb Samuel Holland: > Errors from debugfs are intended to be non-fatal, and should not prevent > the driver from probing. > > Since debugfs file creation is treated as infallible, move it below the > parts of the probe function that can fail. This prevents an error > elsewhere in the probe function from causing the file to leak. Do the > same for the call to of_platform_populate(). > > Finally, checkpatch suggests an octal literal for the file permissions. > > Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs") > Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64") > Reviewed-by: Jernej Skrabec > Signed-off-by: Samuel Holland Tested-by: Heiko Stuebner but one thing below > --- > > (no changes since v1) > > drivers/soc/sunxi/sunxi_sram.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c > index a858a37fcdd4..52d07bed7664 100644 > --- a/drivers/soc/sunxi/sunxi_sram.c > +++ b/drivers/soc/sunxi/sunxi_sram.c > @@ -332,9 +332,9 @@ static struct regmap_config sunxi_sram_emac_clock_regmap = { > > static int __init sunxi_sram_probe(struct platform_device *pdev) > { > - struct dentry *d; > struct regmap *emac_clock; > const struct sunxi_sramc_variant *variant; > + struct device *dev = &pdev->dev; > > sram_dev = &pdev->dev; > > @@ -346,13 +346,6 @@ static int __init sunxi_sram_probe(struct platform_device *pdev) > if (IS_ERR(base)) > return PTR_ERR(base); > > - of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > - > - d = debugfs_create_file("sram", S_IRUGO, NULL, NULL, > - &sunxi_sram_fops); > - if (!d) > - return -ENOMEM; > - > if (variant->num_emac_clocks > 0) { > emac_clock = devm_regmap_init_mmio(&pdev->dev, base, > &sunxi_sram_emac_clock_regmap); > @@ -361,6 +354,10 @@ static int __init sunxi_sram_probe(struct platform_device *pdev) > return PTR_ERR(emac_clock); > } > > + of_platform_populate(dev->of_node, NULL, NULL, dev); hmm, of_platform_populate() can actually fail [0] it just looks a bit like sunxi driver seem to ignore that by {chance, design?} [1] . So I guess this might want to have handling for probably unlikely possible errors instead? Heiko [0] https://elixir.bootlin.com/linux/latest/source/drivers/of/platform.c#L463 [1] https://elixir.bootlin.com/linux/latest/source/drivers/bus/sun50i-de2.c#L22 > + > + debugfs_create_file("sram", 0444, NULL, NULL, &sunxi_sram_fops); > + > return 0; > } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel