From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4203C44507 for ; Tue, 14 Jul 2026 20:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GZnKgW+PTI85uwSvBTZx6tE/LVkjSY/LHRD2fDPNzO0=; b=m4OhxHJpn+yPKI5QNGG8OEZt9i RhVw/6RzUIs+4W0YPBAVG5sjGQHqO/H0XQEyQ7Ggly02+w1Vi/420yj+qFL4mfTJA+5qZFZT6RLOd Jc1cwTHPq+kIE2Ikmgo2qQSEbapNb3Ueyw953brAhMclhOBZFhFYWpC2eFbv8x0wN1Uvy+TAChMHS uqvWF0/1UHwpFRvhywHr7Y3MeTLtdCDmwDZ6t+As59pnuhUWQRv1eHs9ZAbGJf9VuUR7MDFmH384E w/u59n1VBrG70Y5IdXT7wN2wxoUceEN/YjodqVJY5RJYIe/76lqy6X/JDZZeCndjPW9S2//8JZ2rg 6L4vr66Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjVc-0000000DCYI-0G70; Tue, 14 Jul 2026 20:13:40 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjjVY-0000000DCXG-2oJc for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2026 20:13:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GZnKgW+PTI85uwSvBTZx6tE/LVkjSY/LHRD2fDPNzO0=; b=pDJ4GOG290nNbD7p9pehUqbd6J liRP7KZdmFIUYrnPXVRorJ+btZrptsNhTyOE6IcMio8Z7W0/PkmCvK/jiRDtGbzxLi5Rm1ihsYGcP D6XqGXjWUEYD1ptZjY+ed8cKUhRvmUeZyVFvFrqTJk3NuFUrKT/o+vUrikzcxituPc94=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wjjVG-00CFLL-Bi; Tue, 14 Jul 2026 22:13:18 +0200 Date: Tue, 14 Jul 2026 22:13:18 +0200 From: Andrew Lunn To: "Shenwei Wang (OSS)" Cc: Mathieu Poirier , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Frank Li , Sascha Hauer , Shuah Khan , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , Fabio Estevam , Shenwei Wang , Peng Fan , "devicetree@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , Arnaud POULIQUEN , "b-padhi@ti.com" Subject: Re: [PATCH v14 1/5] docs: driver-api: gpio: rpmsg gpio driver over rpmsg bus Message-ID: <680d0633-cdec-4545-9114-79bfd6eaac41@lunn.ch> References: <20260625155432.815185-1-shenwei.wang@oss.nxp.com> <20260625155432.815185-2-shenwei.wang@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260714_131336_710530_8C2A4C31 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > 1) You did not include messages that mask and unmask interrupts at the driver > > side. > > Interrupt masking and unmasking are handled entirely on the local processor. > > When an interrupt occurs, the remote system masks the interrupt and then sends a notification > to Linux. After Linux processes the notification, it sends a SET_IRQ_TYPE message back to the > remote system, which then unmasks the interrupt. Masking and unmasking an interrupt are orthogonal to the interrupt type. When the interrupt fires, the interrupt core calls the irq_mask() operation on the interrupt. That should mask the interrupt. Once the handler has finished, the interrupt core, will call irq_unmask() to unmask the interrupt. Edge, level, high, low, raising, falling has nothing to do with masking. Please don't mix concepts which Linux keeps separate. Andrew