From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81779EB64DD for ; Wed, 21 Jun 2023 17:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5l9XrIjisFxzI+juweHbQYjfuZTNPzgxDiJFLDtWE/c=; b=3GS0Nyr/Y9zgHk Z/4AdU+p/QxxS8ZkTyXpgETeEHP2OyJVt7E1skKiGRugKfk5N903iXqsyQCYjbLSCQO8qY1XYGjHI vU5/j/1gnMrUsRbeAF1TGM8Cxxz9g59H5HIqJRxAXCd0VX4v14V4hTe8vQ6mHPYyHetIq548RNKTs EHXnyyJN86EJhV4YwsZZx6aoMF4U88zm1adoEKpm8cAMdCe+0W01Jpb6roOiGY9TIJYFsoRLsduST tJtxCWMOfAlx/34iPAMRldxgoP/2FZL7ireYrYCOqvcbT0+NNYMJig/IPcal9GDh0rBxqCTp1Ihzt cOG+aXDI4I5Azm2oB8ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qC1qZ-00FFvp-0D; Wed, 21 Jun 2023 17:42:23 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qC1qW-00FFvK-2c for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2023 17:42:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687369340; x=1718905340; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=LVptCrukcCrf+ulAXv9iJ2UzZRi1STprNI7mWSySJig=; b=J1iLjNiZZucR7G0HfPh3DRTV9dO2yIFyStD+K2Yd5oDKLLJdDKLxg1Bs LojdvDQKRek0QEVR8KBObEhg32pjNpMpp+DTkJTe4B8rGZ33+7D/ZK25b pJwvrhbrgNqMTrfs1bWNy/sKAx2De7TQE6q3ZOu5KiTNVpEx+Y1yEBhfB hSSELWorUEGTCQMa8RpKRLhlQgdLQxMLHUADibAxgvaWcuED83Bzs2OXO Eb3IK0ke/Ai7+coXc14eEJiH74b1Yje+943TW9Bf1mdvn+Ybh27ID+gUA 3rsUwHup4v7lXkhd7CLragYvNTPYCzZlvXzS/eFn2WiXtO/TFjs1y4z0y g==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="339870181" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="339870181" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:42:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="1044816796" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="1044816796" Received: from rmathew-mobl2.amr.corp.intel.com (HELO [10.212.134.235]) ([10.212.134.235]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 10:42:16 -0700 Message-ID: <680fadba-9104-3914-5175-e207fd3d9246@intel.com> Date: Wed, 21 Jun 2023 10:42:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Content-Language: en-US To: Yair Podemsky , mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> From: Dave Hansen In-Reply-To: <20230620144618.125703-3-ypodemsk@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_104220_859586_72C010BB X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/20/23 07:46, Yair Podemsky wrote: > -void tlb_remove_table_sync_one(void) > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > +#else > +#define REMOVE_TABLE_IPI_MASK cpu_online_mask > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > + > +void tlb_remove_table_sync_one(struct mm_struct *mm) > { > /* > * This isn't an RCU grace period and hence the page-tables cannot be > @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) > * It is however sufficient for software page-table walkers that rely on > * IRQ disabling. > */ > - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); > + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, > + NULL, true); > } That "REMOVE_TABLE_IPI_MASK" thing is pretty confusing. It *looks* like a constant. It does *NOT* look at all like it consumes 'mm'. Worst case, just create a local variable: if (IS_ENABLED(CONFIG_ARCH_HAS_CPUMASK_BITS)) ipi_mask = mm_cpumask(mm); else ipi_mask = cpu_online_mask; on_each_cpu_mask(ipi_mask, ...); That's a billion times more clear and it'll compile down to the same thing. I do think the CONFIG_ARCH_HAS_CPUMASK_BITS naming is also pretty confusing, but I don't have any better suggestions. Maybe something with "MM_CPUMASK" in it? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel