public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode
Date: Tue, 13 Oct 2015 09:57:53 +0200	[thread overview]
Message-ID: <6820669.agSbTbzqFV@wuerfel> (raw)
In-Reply-To: <87fv1f6bjj.fsf@belgarion.home>

On Monday 12 October 2015 23:07:28 Robert Jarzmik wrote:
> Arnd Bergmann <arnd@arndb.de> writes:

> > The z2 in particular never did, except in the powerdown handler. So if it
> > is unable to wake up reliably from DEEPSLEEP, that may be a reason to use
> > that flag only in the poweroff function but not during normal operation.
> My first thought was :
>         This flag's only use is for Suspend to RAM.  There might be special
>         wirings where the voltage to the RAM is provided out of SYS_EN pin
>         control, and therefore PWRMODE_DEEPSLEEP is possible. But the most
>         common pattern would be a PMIC, providing voltage to the DRAM through
>         Vcc_Mem.
> 
> But having a closer look, you're right, I have misunderstood the way z2 poweroff
> was designed. The setting of poweroff to PWRMODE_DEEPSLEEP +
> pxa27x_cpu_pm_enter() is a whole, it is the closest to a platform halt where no
> external chip handles the poweroff phase, and memory is shutdown in deep sleep.
> 
> Therefore I'll drop Thierry's patch (which would actually break suspend to RAM I
> think) and take yours.

Ok, sounds good. thanks!

	Arnd

  reply	other threads:[~2015-10-13  7:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 13:44 [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Arnd Bergmann
2015-10-12 13:46 ` [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Arnd Bergmann
2015-10-12 17:10   ` Robert Jarzmik
2015-10-12 18:53     ` Robert Jarzmik
2015-10-12 19:20       ` Arnd Bergmann
2015-10-12 21:07         ` Robert Jarzmik
2015-10-13  7:57           ` Arnd Bergmann [this message]
2015-10-12 18:57     ` Arnd Bergmann
2015-10-12 17:03 ` [PATCH] ARM: pxa: fix pxa3xx DFI lockup hack Robert Jarzmik
2015-10-12 18:57   ` Arnd Bergmann
2015-10-14 15:14   ` Arnd Bergmann
2015-10-14 19:05     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6820669.agSbTbzqFV@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox