From: Leonard Crestez <leonard.crestez@nxp.com>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: "robh@kernel.org" <robh@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"abelvesa@linux.com" <abelvesa@linux.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"spencercw@gmail.com" <spencercw@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver
Date: Wed, 27 Feb 2019 13:15:44 +0000 [thread overview]
Message-ID: <682cdcf278560b375ebced2eee1940b3dfc75e03.camel@nxp.com> (raw)
In-Reply-To: <20190227084116.42yrs26i5xlkppgl@fsr-ub1664-175>
On Wed, 2019-02-27 at 08:41 +0000, Abel Vesa wrote:
> On 19-02-26 13:34:52, Leonard Crestez wrote:
> > On Tue, 2019-02-26 at 10:53 +0000, Abel Vesa wrote:
> > > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code.
> > > For now, only i.MX8MQ revision B1 is supported. For any other, i.MX8MQ
> > > revision it will print 'unknown'.
> > >
> > > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
> > > + if (!np)
> > > + goto out;
> > > +
> > > + ocotp_base = of_iomap(np, 0);
> > > + WARN_ON(!ocotp_base);
> > > +
> > > + magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1);
> > > + if (magic == IMX8MQ_SW_MAGIC_B1)
> > > + rev = REV_B1;
> >
> > Turns out that imx8mq version determination is uniquely messy. I think
> > we should try to print the revision number even for older chips so that
> > we know how old they are, but this code can be enhanced in later
> > patches.
>
> Fair enough. I believe we should stick to B1 only for now though.
Yes, people who want their old SOC revisions to be be detected can
submit later patches.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-27 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 10:53 [PATCH v2] soc: imx: Add generic i.MX8 SoC driver Abel Vesa
2019-02-26 11:34 ` Chris Spencer
2019-02-26 13:34 ` Leonard Crestez
2019-02-27 8:41 ` Abel Vesa
2019-02-27 13:15 ` Leonard Crestez [this message]
2019-02-26 13:37 ` Fabio Estevam
2019-02-26 13:38 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682cdcf278560b375ebced2eee1940b3dfc75e03.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=abelvesa@linux.com \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=spencercw@gmail.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).