From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35E15C3DA4A for ; Sat, 13 Jul 2024 00:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o1mT6PlMdzu79a8oj2oSMpn7lPddAo5re8ZN7EDToGo=; b=QFqjzg5Hiihd45JSLC1KKXH+4/ 6X1LlV7TnHaYKNKzO3eLMDbl1XY7Z1tgkYBqPe3VanKl0ysdpTCzu84Dd84hRNfxkNNUDl8JZZXDh Cg1UWrobYBE+XnqrVnGj/9NL84l4znmwWaO4fKhvVfAU878sye3/9I6J+SROVXauoPW1DSuTz6ELn 4vuxSsWwhG9YljHs2zQx6XrVmpLA6fiZMBoGX/n/ciG/+Y5wcseo3l01cgglnmL5rdyNc9x27bi3j dStOUI2sROmmNHjdWSLrVKzRNoMciMAC+mqdWzzFe7Bvpan2Ds/zDbBeMxJfYbmYU3UL7v5Cc9pD1 MS1s+htA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSQDY-00000001Z1S-3foT; Sat, 13 Jul 2024 00:02:24 +0000 Received: from mail-dm6nam12on20601.outbound.protection.outlook.com ([2a01:111:f403:2417::601] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSQDF-00000001YvM-2u5l; Sat, 13 Jul 2024 00:02:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G2bJqY1HO9VLcoACjQa5rgPayYOu5F/dDW/e7s8VryWWGf+VFSRmOIy772uqdaXhW3wfEFtgHuydbnmLlnq32W32chC+FTntKOnDLBcK4wIa6E8L8U68OgA5GKHJBt01FFzhKACm5+byFt1cg9/63mgrAvpIGVmjwDty7W0iREnZhende+IMP8myrz8JvKV4wjZl/C9jh45sXIs8qGxcbdABgy+n9E1qDS0PyAeSgAAFBhvauReCV7E89W6c/Wm0VWARXRhaoHTpUwtfXXc9Y6uPZfRGYoE2Pne8nuKRZUyyX7zJ6q20RzRpiuNbHUUSkwnrhSkjUnCKZ/TJZS8qhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o1mT6PlMdzu79a8oj2oSMpn7lPddAo5re8ZN7EDToGo=; b=GYYbn+GtuAdzr7TircQxe0jjHfh9zylPa4wXhqwYWOfM9HMZeJpV+vVR6XHVqRMVncQlBy7vyERreyV0ZszGpv8djuzH8Y/I3A76+oZFFw3wkxvoYIDZdCcbZERHUptQPX+xeh90eUkwAa0dDMPrrog0ci+sXfcn34mBCVI1RFFb4DL5SKGWkOhQOAh1r1J+VC/VVoa0aAJ0pDWw5VtntE1YCnCemnluP1s0zOLHnpTdrBeTP63/ULBiojV3aDd+k7uczgMnCyNtz2GT5n3m0KptRDkzi1HbpEEwDdm8qrOPjxhNSXea3mbOoUrs8Fky3MeNnrJgIvnv+odSVnzmfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o1mT6PlMdzu79a8oj2oSMpn7lPddAo5re8ZN7EDToGo=; b=CaEFdFOMPytTA0r5ZE7f9S4mSLx3DIfitz56IXN/TCBKrHnQdveKiEteZdeSWg67CCljmHDRzRgSEYfKTjcdePwvq2cbDI1zBC1DSR1uNIIF4W/GpQi7mKOHDl+xHsx92zsVrmGzvupFQoV3A9Kzhgy9J3f2Fayqq1b16MSFIfb4qhlKUHL09JQTygPbtrxYSpw7fAX6jic+2yQk1t/rrREj+2natGhmK2u3q5iwqtWz2wCsJnaXpZHM+4fYJnk1ZstewZkPmup9mnIChfBf/wXqZxZSFETuEtinlF9ywzFNPvRQOlv3Wh5mygUwBwedHzLgzd4jsOHBGGJC71Xqjg== Received: from BY5PR16CA0021.namprd16.prod.outlook.com (2603:10b6:a03:1a0::34) by MW3PR12MB4458.namprd12.prod.outlook.com (2603:10b6:303:5d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.21; Sat, 13 Jul 2024 00:01:56 +0000 Received: from SJ1PEPF000023D7.namprd21.prod.outlook.com (2603:10b6:a03:1a0:cafe::55) by BY5PR16CA0021.outlook.office365.com (2603:10b6:a03:1a0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35 via Frontend Transport; Sat, 13 Jul 2024 00:01:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023D7.mail.protection.outlook.com (10.167.244.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Sat, 13 Jul 2024 00:01:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 17:01:40 -0700 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 17:01:39 -0700 Message-ID: <682e293b-cc0d-4261-90a8-bc6f16df0992@nvidia.com> Date: Fri, 12 Jul 2024 17:01:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/net: fix gro.c compilation failure due to non-existent opt_ipproto_off To: Greg Kroah-Hartman CC: Shuah Khan , "David S . Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Pravin B Shelar , "Willem de Bruijn" , Alexander Mikhalitsyn , zhujun2 , "Petr Machata" , Ido Schimmel , Hangbin Liu , Nikolay Aleksandrov , "Benjamin Poirier" , Sebastian Andrzej Siewior , Dmitry Safonov <0x7f454c46@gmail.com>, , , , , , , LKML , , , Ignat Korchagin References: <20240712235150.99175-1-jhubbard@nvidia.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20240712235150.99175-1-jhubbard@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D7:EE_|MW3PR12MB4458:EE_ X-MS-Office365-Filtering-Correlation-Id: 1667e350-5152-4741-711a-08dca2cf0244 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QXBWV1B4dWExY082ekxQaGRjTWh0UHZwWjI0QTZtNGsveU9PREFaK2N5eWg3?= =?utf-8?B?MUI0RXNWVEhXUEZPbURjcVNNdnRNSjllbDIvSjdKTjllaE1MNXhFMktlM3Fa?= =?utf-8?B?SERYdVZsODRBUFg2TXk1U0gxSWplWWl1bEU2M2NlMTIrOEx6dVlHb01ORjd1?= =?utf-8?B?S2NRRUJqYnFwUU5ObkFvMURobnU4SGNESDlqY05kZksydCtmZ2x1V3lrOXJr?= =?utf-8?B?YlZrYzJCNmgzMjNETUZxQ05uenc1aDB0b3Z5cHo2UHlqY0xCaFVCL1FRK3JH?= =?utf-8?B?VG85TXgrcjVXWlB6Mk5Ja2RPanNOZ1NCKzRRaytXU3JnNkMrMk93bjdEVE9L?= =?utf-8?B?OG1ncm1YMXBuUUpGYmh0Z0FIVkxuK2ZuazFab1dFQzVkMnIvV1MzdWZVcnBE?= =?utf-8?B?QkVCb0JaejFUSllWNmp5dy9wc2N1L1M0RkhzTENLZms4YWo0dDVZaGNrR3hH?= =?utf-8?B?WUd5RUZOZ3BjUUtNSFRJRHJLZVE2eklUa2VIUk42K1dHRjlIRkxBRWFYc1dT?= =?utf-8?B?OExKanIvRkxtRmVzNGY2QVBUZ3UvUlg1K1BHR3ZLdlY0RGk2enQ0SHBiM2tC?= =?utf-8?B?aVlwRi8zOGV3RGpEclY2eXoyelRmTm4wT2cwd2lNUEV5blkxMnJNRGUrUnpl?= =?utf-8?B?Q3pFaWl1VW5kZW1KNzVPYyt4b2NvTEpKZE1HNmxEdzQwV2wxSGRqZVpTc2xN?= =?utf-8?B?QkRKT1FwRW0wK0h0LytsY0xnRDZyb0tqOUgwcVBWM2w3dFBhcENrVlVHYUlk?= =?utf-8?B?YXUrMXZMNG11ZDJQMlJJWFJORVFYRGZHT0w3QmRGVXlDdlI1MjhsV2QrbmhL?= =?utf-8?B?amZTc2lGbVZFaVJUelhmVzFldzNuR0JDNkQrbHVSU1VWVDBKcjV4cDVpcXAx?= =?utf-8?B?VGlIN2hORjJjUlF2elRoMWpySmthMnZNVndiRm5Bc2Z4YkI2NkU2UXhnaTBU?= =?utf-8?B?d3cxOG1maDVXeTJrTlVCNWpTWE8rYnQzaVF2M05sRDFiMUNJU09mRW0wcGJO?= =?utf-8?B?ZXo2cjh3OEVTcS9IcVZtb3lyUFVBZzlsWDY3N29hTVJTYWVFL1hyZmdCNHB1?= =?utf-8?B?SU44a2pTUXVQbmtkbENyT2cyY0NnbmV6V3poTVpFelZWV1VLVUtrMnNmZU1j?= =?utf-8?B?QjFTRnNzOHh5aUZvNmFiUkJLdGFnZEQxakJiQ2pLTGNPbmpCNUFRNmlBNWp5?= =?utf-8?B?Yk9UWm5zcnd0TmMvWFFySE1zTGNPcFRkQmpzSjFVOVJ6cW5uc1dJVzdzZmho?= =?utf-8?B?elJqUkxJWHlyOUVZZGptQU5mdkxpVnVReG1SUVBmNUxkZkRIUStBYUVCaWov?= =?utf-8?B?Z1habkFOUGhKSHMwUnNyOXF2QXdKUDVRbEo2eG5OM0tCY2l3cUcrYXdadWxT?= =?utf-8?B?U2hOcG1hQ3ZNbTg2aGRFVWk0K0ZYRS90eFluaE81WXFWMEdWVmxaQXhIa1Nn?= =?utf-8?B?c0pDMk4rZlVQSkIrdGtjZWxYeHdDUFJYQVh6ZFp4TzFya2N1NkNKVlhaVXRh?= =?utf-8?B?bzFPS0U1U3B3eTE4YmQ1TTVtU2VXZUJlQmd0UjYxaXJYYXVFNDlKbDZMdDgv?= =?utf-8?B?K29wbzNtU1hINDJTWjFCYzBmNm84ZEtITHZINFFaRXJhMzlpcEd1TG5NSHhN?= =?utf-8?B?amROa29meStZZFVxT0V3QmU5NVA2NUp4Z2kwR3F4c2xqK1Rjbjd5YmU3Y2ln?= =?utf-8?B?UHYvSS8zc3Rocno0S3kwb0tYc2pXcW5BTWFwamtGNVMxOC9UdUV4eXJRaDNU?= =?utf-8?B?U2FKR3ZSbzlhTkRQWGVITFR1UEkrUWkyRnJGUzgrTk1tSUQwcjVBK3FSQWxY?= =?utf-8?B?MStoK0YxZEV1eEtZRWNmRHJxQVpOa3pBZE5rVVdXZDVRYnh3UVNTMzgvVTdi?= =?utf-8?B?aWhhdEJ1MGpQRkZCVThGZUppVGNKc0Y0Nk85OEZFRitwZFE9PQ==?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2024 00:01:55.9425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1667e350-5152-4741-711a-08dca2cf0244 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D7.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4458 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_170205_771004_358E9AE8 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/12/24 4:51 PM, John Hubbard wrote: > Linux 6.6 does not have an opt_ipproto_off variable in gro.c at all (it > was added in later kernel versions), so attempting to initialize one > breaks the build. This is the first time I've tried to fix something in linux-stable, and I'm not sure that I've made it completely clear. This is only for linux-6.6.y in linux-stable. thanks, -- John Hubbard NVIDIA > > Fixes: c80d53c484e8 ("selftests/net: fix uninitialized variables") > Cc: # 6.6 > Reported-by: Ignat Korchagin > Closes: https://lore.kernel.org/all/8B1717DB-8C4A-47EE-B28C-170B630C4639@cloudflare.com/#t > Signed-off-by: John Hubbard > --- > tools/testing/selftests/net/gro.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/net/gro.c b/tools/testing/selftests/net/gro.c > index b204df4f3332..30024d0ed373 100644 > --- a/tools/testing/selftests/net/gro.c > +++ b/tools/testing/selftests/net/gro.c > @@ -113,9 +113,6 @@ static void setup_sock_filter(int fd) > next_off = offsetof(struct ipv6hdr, nexthdr); > ipproto_off = ETH_HLEN + next_off; > > - /* Overridden later if exthdrs are used: */ > - opt_ipproto_off = ipproto_off; > - > if (strcmp(testname, "ip") == 0) { > if (proto == PF_INET) > optlen = sizeof(struct ip_timestamp); > > base-commit: 2ced7518a03d002284999ed8336ffac462a358ec