From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18E98C433DB for ; Thu, 31 Dec 2020 08:58:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA90D207A0 for ; Thu, 31 Dec 2020 08:58:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA90D207A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7XNPjShhc2QzUlV7aYFalcQwgHAmID2/MvswmtU3iFk=; b=wX9t5BqyrXRHVrUyrlXKhMdRS tjkbe+MxLLxrjghmBXkxLSd8VnDzi/J9SgfkUxXJ4BHqUtJXkcbzC10wE6jOiV+/lEQ8Ns+MFgK9x hjPdeh849lqJQLqHwItd+OkUyzybqOTbHkjtDUoP0xJwkLCuzjeildEEunBLnzWY6DuT2PRZ6Bmqa HbJJ31DAfpQowC4xKsLDl8WbiXViuCazFVCXq01LdThmhyvY47nGO174tbTXWsVCJAop4Pc4ljh5w w3eQwgda86vJ3/ldMpF0MexKyyOxsaAFpSijkeLA37MmRwIhzHeYwtVxlhzlNOo1orH5kyNOO4/EN qmyBwfqMg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kutm1-0002iA-A1; Thu, 31 Dec 2020 08:57:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kutly-0002hV-Ry for linux-arm-kernel@lists.infradead.org; Thu, 31 Dec 2020 08:57:31 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2293422287; Thu, 31 Dec 2020 08:57:29 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kutlu-004h5B-Vs; Thu, 31 Dec 2020 08:57:27 +0000 MIME-Version: 1.0 Date: Thu, 31 Dec 2020 08:57:26 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [PATCH RFC] KVM: arm64: vgic: Decouple the check of the EnableLPIs bit from the ITS LPI translation In-Reply-To: <20201231062813.714-1-lushenming@huawei.com> References: <20201231062813.714-1-lushenming@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <683134bdea8a22d3bb784117dcfe17a1@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, will@kernel.org, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201231_035731_030396_DB1C0532 X-CRM114-Status: GOOD ( 24.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Eric Auger , yuzenghui@huawei.com, wanghaibin.wang@huawei.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shemming, On 2020-12-31 06:28, Shenming Lu wrote: > When the EnableLPIs bit is set to 0, any ITS LPI requests in the > Redistributor would be ignored. And this check is independent from > the ITS LPI translation. So it might be better to move the check > of the EnableLPIs bit out of the LPI resolving, and also add it > to the path that uses the translation cache. But by doing that, you are moving the overhead of checking for EnableLPIs from the slow path (translation walk) to the fast path (cache hit), which seems counter-productive. > Besides it seems that > by this the invalidating of the translation cache caused by the LPI > disabling is unnecessary. > > Not sure if I have missed something... Thanks. I am certainly missing the purpose of this patch. The effect of EnableLPIs being zero is to drop the result of any translation (a new pending bit) on the floor. Given that, it is immaterial whether this causes a new translation or hits in the cache, as the result is still to not pend a new interrupt. I get the feeling that you are trying to optimise for the unusual case where EnableLPIs is 0 *and* you have a screaming device injecting tons of interrupt. If that is the case, I don't think this is worth it. Thanks, M. > > Signed-off-by: Shenming Lu > --- > arch/arm64/kvm/vgic/vgic-its.c | 9 +++++---- > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 4 +--- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-its.c > b/arch/arm64/kvm/vgic/vgic-its.c > index 40cbaca81333..f53446bc154e 100644 > --- a/arch/arm64/kvm/vgic/vgic-its.c > +++ b/arch/arm64/kvm/vgic/vgic-its.c > @@ -683,9 +683,6 @@ int vgic_its_resolve_lpi(struct kvm *kvm, struct > vgic_its *its, > if (!vcpu) > return E_ITS_INT_UNMAPPED_INTERRUPT; > > - if (!vcpu->arch.vgic_cpu.lpis_enabled) > - return -EBUSY; > - > vgic_its_cache_translation(kvm, its, devid, eventid, ite->irq); > > *irq = ite->irq; > @@ -738,6 +735,9 @@ static int vgic_its_trigger_msi(struct kvm *kvm, > struct vgic_its *its, > if (err) > return err; > > + if (!irq->target_vcpu->arch.vgic_cpu.lpis_enabled) > + return -EBUSY; > + > if (irq->hw) > return irq_set_irqchip_state(irq->host_irq, > IRQCHIP_STATE_PENDING, true); > @@ -757,7 +757,8 @@ int vgic_its_inject_cached_translation(struct kvm > *kvm, struct kvm_msi *msi) > > db = (u64)msi->address_hi << 32 | msi->address_lo; > irq = vgic_its_check_cache(kvm, db, msi->devid, msi->data); > - if (!irq) > + > + if (!irq || !irq->target_vcpu->arch.vgic_cpu.lpis_enabled) > return -EWOULDBLOCK; > > raw_spin_lock_irqsave(&irq->irq_lock, flags); > diff --git a/arch/arm64/kvm/vgic/vgic-mmio-v3.c > b/arch/arm64/kvm/vgic/vgic-mmio-v3.c > index 15a6c98ee92f..7b0749f7660d 100644 > --- a/arch/arm64/kvm/vgic/vgic-mmio-v3.c > +++ b/arch/arm64/kvm/vgic/vgic-mmio-v3.c > @@ -242,10 +242,8 @@ static void vgic_mmio_write_v3r_ctlr(struct > kvm_vcpu *vcpu, > > vgic_cpu->lpis_enabled = val & GICR_CTLR_ENABLE_LPIS; > > - if (was_enabled && !vgic_cpu->lpis_enabled) { > + if (was_enabled && !vgic_cpu->lpis_enabled) > vgic_flush_pending_lpis(vcpu); > - vgic_its_invalidate_cache(vcpu->kvm); > - } > > if (!was_enabled && vgic_cpu->lpis_enabled) > vgic_enable_lpis(vcpu); -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel