From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] input: fix odd_ptr_err.cocci warnings
Date: Wed, 17 Feb 2016 13:55:11 +0100 [thread overview]
Message-ID: <6833564.Kp6CL1O0GI@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.10.1602170724320.2685@hadrien>
On Wednesday 17 February 2016 07:29:05 Julia Lawall wrote:
> PTR_ERR should access the value just tested by IS_ERR
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> I haven't checked the context in detail. There can be false positives,
> when it is the call to IS_ERR that is wrong.
>
> tree: https://github.com/Broadcom/arm64-linux iproc-tsc-v2
> head: ef32cf1baeb934bfcdf7c9eb8ad345aae266cde5
> commit: c3afc7a1c330ce452c52e2183a23b2ab9f70bd4a [2/3] input: syscon
> support in bcm_iproc_tsc driver
>
> Please take the patch only if it's a positive warning. Thanks!
>
>
Looks correct to me
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> if (IS_ERR(priv->regmap)) {
> - error = PTR_ERR(priv->regs);
> + error = PTR_ERR(priv->regmap);
I think this could have been avoided using
error = PTR_ERR_OR_ZERO(priv->regmap);
if (error) {
...
Arnd
next prev parent reply other threads:[~2016-02-17 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 12:29 [PATCH] input: fix odd_ptr_err.cocci warnings Julia Lawall
2016-02-17 12:55 ` Arnd Bergmann [this message]
[not found] <202204070801.hNvu3cEu-lkp@intel.com>
2022-04-07 0:09 ` [PATCH] Input: " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6833564.Kp6CL1O0GI@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox