From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EE15C43602 for ; Tue, 7 Jul 2026 10:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pOL2LivOziEKOydGhyELrv4YvjM0xwsEQoaCeoympc0=; b=YaikaYwo6mcJ6lFpJZto46n13u EjFnbX7utXyo/OCuK8G4HWHZ6wPsto2/7w94eDGulq7GQ50k3+eRq9tvfrP6r01HZ8QPCTFyqvzOz iqkfZCaT4WfWrYxiFmziQJbjS3R0jlP187v0ZMh9cjTqr6Kd7cD9kSiy04QhWFQJyvdqBHKygPlK3 dFiyzcvyAsELAcwpjj4526XMG7mAp4jOim5B4Dd9f5XphH39wAHJfaPrrS3EXX46qUOgr4rFF6O9b txhglrIdOE2GOcmGUSM6wZSmY2WekTs14cFtd88b9FuXYaSPye7bT/yzF9/EEBpnq7krBVH+N6i5x M5Sf4Iuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh3BZ-0000000EljY-0H4r; Tue, 07 Jul 2026 10:37:55 +0000 Received: from server.couthit.com ([162.240.164.96]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh3BW-0000000Elb0-3rEn for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2026 10:37:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=couthit.com ; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pOL2LivOziEKOydGhyELrv4YvjM0xwsEQoaCeoympc0=; b=ZURn/r+hEiMd3lVJPe/lPjjAVo IdeS+ZWvzmh+2rYtf9zrbw/86Nt8ZO2bDKtQKVqjJhoWPervjLGwI+LJyisjySLsthlhu2qTdyMs9 sMPzgBm7xc48QzEIXWy6QV18Wk01rri39Xsb9vwVJ8FcVoV/aUakNKIEi1jzBRcMysBY9cG7415RQ Aj81c6NXsjSQL9BiPfAWpmGAURaCqZI8Ojzz144z/JMtcYOFDd4RWve15J0JallqPRYhtoDrBF/X3 lIthMKaxbw9CKjUa4ZqIDlORJKRbtKEiHYQy5WIKhNOAlbmuCH7izWz89QxEX/Dhn/iWwI31PUKPs /K9f7Dfg==; Received: from [115.246.246.98] (port=38479 helo=zimbra.couthit.local) by server.couthit.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.4) (envelope-from ) id 1wh3Am-0000000DcCE-2mia; Tue, 07 Jul 2026 06:37:04 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id 75E8C1B071DC; Tue, 7 Jul 2026 16:06:56 +0530 (IST) Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10032) with ESMTP id IJLnN744ezV4; Tue, 7 Jul 2026 16:06:52 +0530 (IST) Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id D46861B071D0; Tue, 7 Jul 2026 16:06:52 +0530 (IST) X-Virus-Scanned: amavis at couthit.local Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavis, port 10026) with ESMTP id Xgrw10G8zfdZ; Tue, 7 Jul 2026 16:06:52 +0530 (IST) Received: from zimbra.couthit.local (zimbra.couthit.local [10.10.10.103]) by zimbra.couthit.local (Postfix) with ESMTP id B07661B071DC; Tue, 7 Jul 2026 16:06:52 +0530 (IST) Date: Tue, 7 Jul 2026 16:06:52 +0530 (IST) From: Parvathi Pudi To: Paolo Abeni Cc: parvathi , andrew+netdev , davem , edumazet , kuba , danishanwar , rogerq , pmohan , afd , basharath , arnd , linux-kernel , netdev , linux-arm-kernel , pratheesh , j-rameshbabu , Vignesh Raghavendra , praneeth , srk , rogerq , m-malladi , krishna , mohan Message-ID: <683548159.1585651.1783420612671.JavaMail.zimbra@couthit.local> In-Reply-To: <20260706091338.134754-1-pabeni@redhat.com> References: <20260630124958.894360-4-parvathi@couthit.com> <20260706091338.134754-1-pabeni@redhat.com> Subject: Re: [PATCH net-next v2 3/3] net: ti: icssm-prueth: Support duplicate HW offload feature for HSR and PRP MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.10.233] X-Mailer: Zimbra 9.0.0_ZEXTRAS_20240927 (ZimbraWebClient - GC138 (Linux)/9.0.0_ZEXTRAS_20240927) Thread-Topic: icssm-prueth: Support duplicate HW offload feature for HSR and PRP Thread-Index: 1L122pWSAIHcS+z+0TJ+oGlKhvBb9Q== X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.couthit.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - couthit.com X-Get-Message-Sender-Via: server.couthit.com: authenticated_id: smtp@couthit.com X-Authenticated-Sender: server.couthit.com: smtp@couthit.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260707_033751_038504_E26F50A8 X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > From: AI Reviewer > > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > Full review at: https://sashiko.dev/ > --- > net: ti: icssm-prueth: Support duplicate HW offload feature for HSR and PRP > > This commit introduces hardware duplicate offload for HSR and PRP modes. It > implements a common shared queue between the two ports, writing frames once > to OCMC RAM and relying on the firmware to replicate the transmission. > >> diff --git a/drivers/net/ethernet/ti/icssm/icssm_prueth.c >> b/drivers/net/ethernet/ti/icssm/icssm_prueth.c >> index 2ab78a98f8568..cbe666a212c3b 100644 >> --- a/drivers/net/ethernet/ti/icssm/icssm_prueth.c >> +++ b/drivers/net/ethernet/ti/icssm/icssm_prueth.c >> @@ -97,6 +125,17 @@ static void icssm_prueth_write_reg(struct prueth *prueth, >> static enum pruss_mem pruss_mem_ids[] = { PRUSS_MEM_DRAM0, PRUSS_MEM_DRAM1, >> PRUSS_MEM_SHRD_RAM2 }; >> >> +struct prp_txopt_rct { >> + __be16 sequence_nr; >> + __be16 lan_id_and_lsdu_size; >> + __be16 prp_suffix; >> +}; > > [Severity: High] > Does this structure definition need the __packed attribute? > > This struct consists of three 16-bit fields but lacks the __packed attribute, > so it inherits a 2-byte alignment requirement. Later in > icssm_prueth_tx_enqueue, a pointer to this structure is derived directly > from skb_tail_pointer. > > If an ethernet frame payload has an odd byte length, wouldn't casting and > dereferencing this pointer cause an unaligned 16-bit memory access, resulting > in hardware traps or panics on architectures that do not support it? > > [ ... ] >> @@ -549,15 +588,24 @@ static int icssm_prueth_tx_enqueue(struct prueth_emac >> *emac, > [ ... ] >> + other_emac = emac->prueth->emac[(emac->port_id == PRUETH_PORT_MII0) ? >> + PRUETH_PORT_MII1 - 1 : PRUETH_PORT_MII0 - 1]; >> + >> + if (prueth_is_lre(prueth) && (emac->link || other_emac->link)) >> + link_up = true; > > [Severity: High] > Could this logical OR cause the shared transmission queue to stall completely > if only one of the slave links goes down? > > If one port loses its link, its emac->link is 0, but the other active port > will still evaluate link_up as true. The active port would continue sending > duplicate frames to the shared queue. > > [ ... ] >> @@ -605,6 +659,29 @@ static int icssm_prueth_tx_enqueue(struct prueth_emac >> *emac, > [ ... ] >> + if (free_blocks_other_port < free_blocks) >> + free_blocks = free_blocks_other_port; >> + } > > [Severity: High] > Following up on the link_up logic above, since the available queue space is > bounded by the slowest reader here, wouldn't the inactive port's read pointer > remain frozen? > > This appears to exhaust the free_blocks pool, causing the active port to > eventually spin and return -ENOBUFS permanently, defeating the redundancy. > > [ ... ] >> + } else { >> + /* Read PRP RCT to extract sequence number and LAN ID */ >> + struct prp_txopt_rct *rct = >> + (struct prp_txopt_rct *)(skb_tail_pointer(skb) - >> + ICSSM_LRE_TAG_SIZE); >> + >> + if (rct->prp_suffix == htons(ETH_P_PRP)) { > > [Severity: High] > Is it safe to directly dereference rct->prp_suffix here? > > As mentioned above regarding the struct definition, this might lead to an > unaligned memory access on certain architectures. Perhaps using the > get_unaligned_be16 helper would be safer here, or adding the __packed > attribute to the structure definition. > > [ ... ] >> @@ -1341,18 +1516,30 @@ static enum netdev_tx icssm_emac_ndo_start_xmit(struct >> sk_buff *skb, > [ ... ] >> + raw_spin_lock(lock_queue); >> + ret = icssm_prueth_tx_enqueue(emac, skb, qid); >> + raw_spin_unlock(lock_queue); > > [Severity: High] > Does this need to use the irqsave variant to protect against cross-device > deadlocks with netpoll? > > The lre_host_queue_lock is shared between the two ports. If a hardirq > preempts a CPU while it holds this lock during a transmission, and the > interrupt handler invokes a printk that triggers netconsole over the second > interface, netpoll might bypass the netif_tx_lock. > > When the second interface calls into ndo_start_xmit, it would attempt to > acquire the exact same lre_host_queue_lock, causing it to spin forever on > the same CPU. > -- > This is an AI-generated review. We are in the process of reviewing the comments and will revert with additional details. Thanks and Regards, Parvathi.