From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5BEDC433FE for ; Thu, 13 Oct 2022 05:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FpdFIZPM7LapZe+dhB1wyeB05gKfmOFaUYes/UhL3JQ=; b=sXgemyaQYftvHH GzPa5Ek0wI4zDaQNe1IuqdFrahOnfA+MJko6LteJfcqCriOc8Hkbs3DQ5bejYY4Eo4bC0+HExpo79 rUwss74ji6xyhpdDqWYhE9ZF0uN2dZXEUyn9DtOKfWwLLTUA954kF6RSiGknGRAXLND0UmxnQUQqa q3vno5alP+BhHIm0soySW5VVAmC1DbMCaYidfwsd8p0F+zp9os7FmeXGIUz6tNQMYwhGVcerqTrXi AOF8eiCUhhMeLMSgtZk6ffnwi+MNM/agYip0QYoI4fvp43KC/eOicWMn4mZ9n9IHqKPSPvnnAJLvX rWem1ZLi5hBp9dWwYDmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oirCy-00AlVz-RC; Thu, 13 Oct 2022 05:56:41 +0000 Received: from esa2.hgst.iphmx.com ([68.232.143.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oirCv-00AlUD-Bs for linux-arm-kernel@lists.infradead.org; Thu, 13 Oct 2022 05:56:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1665640597; x=1697176597; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QJzUPWjBRzDrZnxgC//C5t7Ufi9qlwbyFKrKzT02xgs=; b=kfAcV3iIP7Rvj4A5CtyRyRx2rn4ojhZrte8PNKlmjexN+6BBFGLgSGA0 Vu2w6isrpq9JnaES3p9RFDd/+PYzMtF801TD9zGSmRRakafsYy8HJSrbs wpwtUSsEzoT4RxDER2ExuKLheaelBT2eavogyQ08blYq6aBWg3zGgGPJ5 h0z7IYN4WF8lbrVEZ7GRtyat3kZiFktF+z/VfyNmoNJykbN+P5Vrod0od Z+YniqLv8WVu725adrlBOV+HlmiA0mZyvegu3CeArdDbPPcwo1dy18mzi jdtOB1+fFoOj3KDjNJSK0cSqAc5nQ8qi8nk2JUaspHbOyygUB9nMP52Ba Q==; X-IronPort-AV: E=Sophos;i="5.95,180,1661788800"; d="scan'208";a="317975383" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 13 Oct 2022 13:56:33 +0800 IronPort-SDR: b8DAmtkHGKnBKOL5AqMKG7XEftGaPEfL46bpSWdx9GGYNePKCRfjbb9UFpZb1LVrNg7v68jI4t 0HlBIhwkYpHnkFwyaPU2bAdgluNh14z4AwEhA1cpqimaUNamjS1phTurqg4K0QncRayUGMDNYx Q70V64DJsPpZEeHnZwpVB00oNNU1nHNOeReiWW500rHwN5LhWHbHwIF8oRqTGhbM6u8TnVXuZZ xNNr4lWeVXGW980sL6hH8ABRVdWDNimHSADLXXe9/yDefMAAAoXbjJVx3L4bROa+wvOeU4FWLS dz0zWaBbZ4oMYrzCRHmfCrEC Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Oct 2022 22:16:11 -0700 IronPort-SDR: iVBLf3cltXu7L3HgAUDpcHGiVM9+obybZeNgqnAGmpqDopALfB8zc69y/sAp6pcLhbwy7MQFm5 djsk3E3QvcPqk+jqxQTY0PV/Q/ZMKAMWRG0m06kod6HR9h+3TOjNfoVe2TbVmRmwlbV7ke9njF HZR7nnxppUJ4qGlRaidtQFUQQVyGK/gff7QTlww75AQaCuO8nOljTebnJHRb2kFDMboCxky4An 2Ni7nPkrxatFZZoWF7g1leyFrbBYUXD9TjBdtfBQAzApbtRkaEzbEoMOZSmnqfTdNFe2YSffri fG4= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Oct 2022 22:56:34 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MnzKr55zPz1Rwtl for ; Wed, 12 Oct 2022 22:56:32 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1665640592; x=1668232593; bh=QJzUPWjBRzDrZnxgC//C5t7Ufi9qlwbyFKr KzT02xgs=; b=nhipVFkfPgzH/NeGynZpIdAW28UhEpidS2eKz0NaYyfz8fHfBEI IsGHZwR0WVN8QFked2Ju7tVMdgC2RJ+OUXK65XJTVO4ZVPmmHDSpTA73HYarHz+H s8+FXU2aTGP44a574Fuddg4QAoHVccj2NxmCatWkvTANgXPwnoDCbSGJIZtKKQDf dm95/xC+5fisdN6l7H5NL75gp1ZRUe4EjoMXEx+cNlboPkmapV09ygeAilQzGLo4 gj7KwpUNotZkS4Bf9C3MIG3CdiTyOSsYkbHZCeQoUe1xrKoNuccnKBSZTzwUJfli FM0Vd2CZf8MplX9OOrTX9RtCeLOLjRf8qqQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OZYgFRjyIy4y for ; Wed, 12 Oct 2022 22:56:32 -0700 (PDT) Received: from [10.149.53.254] (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MnzKp6Jslz1RvLy; Wed, 12 Oct 2022 22:56:30 -0700 (PDT) Message-ID: <68788b58-1e5f-c629-e9cd-f198b50e6019@opensource.wdc.com> Date: Thu, 13 Oct 2022 14:56:29 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS Content-Language: en-US To: Alexander Stein , Fabio Estevam Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221012131105.725258-1-alexander.stein@ew.tq-group.com> <5877338.lOV4Wx5bFT@steina-w> <4442509.LvFx2qVVIh@steina-w> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <4442509.LvFx2qVVIh@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_225637_493358_1469448F X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/13/22 14:55, Alexander Stein wrote: > Hello Damien, > > Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal: >> On 10/12/22 22:30, Alexander Stein wrote: >>> Hello Fabio, >>> >>> Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam: >>>> Hi Alexander, >>>> >>>> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein >>>> >>>> wrote: >>>>> 'ahci:' is an invalid prefix, preventing the module from autoloading. >>>>> Fix this by using the 'platform:' prefix and DRV_NAME. >>>> >>>> What about adding a Fixes tag? >>>> >>>> Reviewed-by: Fabio Estevam >>> >>> Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at >>> which point auto loading stopped working (if it did at all). >> >> Given that the alias was wrong in the first place when added for a >> platform driver, this I think should be a fix for: >> >> 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms") > > I was hesitating tagging the very first commit, not knowing if it did work at > that time. But it seems reasonable. Yep, I do not think this will hurt... If someone think I am wrong, please scream ! > >> I can add the Fixes tag when applying. > > Thanks! > > Best regards, > Alexander > > -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel