From: Wei Xu <xuwei5@hisilicon.com>
To: Huisong Li <lihuisong@huawei.com>, <xuwei5@huawei.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <linuxarm@huawei.com>, <jonathan.cameron@huawei.com>,
<zhanjie9@hisilicon.com>
Subject: Re: [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect log information
Date: Fri, 18 Jul 2025 16:05:30 +0800 [thread overview]
Message-ID: <687A004A.7030905@hisilicon.com> (raw)
In-Reply-To: <20250711063706.3121253-1-lihuisong@huawei.com>
Hi Huisong,
On 2025/7/11 14:37, Huisong Li wrote:
> The hccs_get_all_spec_port_idle_sta() will tell user which port
> is busy when firmware doesn't allow to decrease HCCS lane number.
> However, the current log prints the index of die and port instead
> of the hardware ID user perceived.
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> drivers/soc/hisilicon/kunpeng_hccs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> index 7fc353732d55..65ff45fdcac7 100644
> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> @@ -1295,11 +1295,11 @@ static int hccs_get_all_spec_port_idle_sta(struct hccs_dev *hdev, u8 port_type,
> if (ret) {
> dev_err(hdev->dev,
> "hccs%u on chip%u/die%u get idle status failed, ret = %d.\n",
> - k, i, j, ret);
> + port->port_id, chip->chip_id, die->die_id, ret);
> return ret;
> } else if (idle == 0) {
> dev_info(hdev->dev, "hccs%u on chip%u/die%u is busy.\n",
> - k, i, j);
> + port->port_id, chip->chip_id, die->die_id);
> return 0;
> }
> }
>
Applied to the Hisilicon driver tree.
Thanks!
Best Regards,
Wei
prev parent reply other threads:[~2025-07-18 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 6:37 [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect log information Huisong Li
2025-07-11 10:38 ` Jonathan Cameron
2025-07-12 1:22 ` lihuisong (C)
2025-07-18 8:05 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687A004A.7030905@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=jonathan.cameron@huawei.com \
--cc=lihuisong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@huawei.com \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox