[PATCH 05/17] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

Kishon Vijay Abraham I
2014-05-07T09:22:47Z

Hi,

On Tuesday 06 May 2014 10:05 PM, Jason Gunthorpe wrote:
> On Tue, May 06, 2014 at 07:03:51PM +0530, Kishon Vijay Abraham I wrote:
>> +Example:
>> +pcie at 51000000 {
>> + compatible = "ti,dra7xx-pcie";
>> + reg = <0x51002000 0x14c>, <0x51000000 0x2000>;
>> + reg-names = "ti_conf", "rc_dbics";
>> + interrupts = <0 232 0x4>, <0 233 0x4>;
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + device_type = "pci";
>> + ti,device_type = <3>;
>> + ranges = <0x00000800 0 0x20001000 0x20001000 0 0x00002000 /* Configuration Space */
>
> Configuration space should not show up in the ranges, please don't
> copy that mistake from other drivers, put it in reg.

But then it needs pcie-designware.c to be modified and it will be breaking
other platforms no?
>
>> + interrupt-map-mask = <0 0 0 0>;
>> + interrupt-map = <0x0 0 &gic 134>;
>
> The HW cannot decode INTA/B/C/D?
>
>> +#define PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI 0x0034
>> +#define PCIECTRL_DRA7XX_CONF_IRQENABLE_SET_MSI 0x0038
>> +#define INTA BIT(0)
>> +#define INTB BIT(1)
>> +#define INTC BIT(2)
>> +#define INTD BIT(3)
>> +#define MSI BIT(4)
>> +#define LEG_EP_INTERRUPTS (INTA | INTB | INTC | INTD)
>
> Oh, it can, it would be wise to export this from the driver. Look at
> the latest patches from Srikanth Thokala for the Xilinx PCI driver to
> see how this should look

ok.. will have a look at it.

Thanks
Kishon