From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEDA3C27C77 for ; Tue, 11 Jun 2024 15:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NF3nrKavNgHvmvoaIolzDhI4xmFVWzlR9Cykd9V5Of0=; b=3qFwxwmRpVXOhB 8xH4J2hPHy408ur423YrSVjGO0rOz859dkwV52dzCtjSmeS+iixJph4UwLXSqC8VN18uJU88gGQkn BY2qtDmBUXwxkLtJ3fL6umJNTRJhhi/+T3xWIG6J1Sl+kITRTHpgBiSQIqc9KEk0Wtl16gkVwjtIH 6AHBk2rFJenz8GB2AQZOqVwYjqbSnJo/VRdabpUaOeuQ3LtCfjNU97YFko1uM89VGnPe2cgTTYqs6 YOGynteYZKm0NYj6Qp9gHfYcxFDWTn5wXefFFgQzi/FvZwXvrP9Fyxax19td2RA4WRX1BWVIoF9NQ 8NXZoxk0ByAp6SBMre/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH357-00000009Gvz-2Icw; Tue, 11 Jun 2024 15:06:41 +0000 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sH34u-00000009Gpa-0gD3 for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 15:06:31 +0000 X-Envelope-To: andrew@lunn.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718118385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0aa0B8ChIF+mHezAp/R9HTe7kWW9pZH2yyyhrXiFF0=; b=FRFMNOCBURkGgNiRwdQjskn6JC0c3uRW0W52Sszed5ab4rK3EMuOb2lX1zLJw+gZ4/f4Oi WblrkxY5Q8yAx838JJ5gvifUL1VI54QrRA7IXFlHRSNoprkWuE5BgRyNftiNJgx6drVdyo tTtzOHtRFOCKwwI7UOuEiy5939UO/g0= X-Envelope-To: radhey.shyam.pandey@amd.com X-Envelope-To: netdev@vger.kernel.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: michal.simek@amd.com X-Envelope-To: kuba@kernel.org X-Envelope-To: linux@armlinux.org.uk X-Envelope-To: pabeni@redhat.com X-Envelope-To: edumazet@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: davem@davemloft.net Message-ID: <68c47426-f459-4b83-9cf9-b38cd9d65a94@linux.dev> Date: Tue, 11 Jun 2024 11:06:19 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net-next 1/3] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev_err To: Andrew Lunn Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Jakub Kicinski , Russell King , Paolo Abeni , Eric Dumazet , linux-kernel@vger.kernel.org, "David S . Miller" References: <20240610231022.2460953-1-sean.anderson@linux.dev> <20240610231022.2460953-2-sean.anderson@linux.dev> <42fff229-ee8c-4738-854b-6093f254408f@lunn.ch> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <42fff229-ee8c-4738-854b-6093f254408f@lunn.ch> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_080628_777970_B7C9B737 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/10/24 19:49, Andrew Lunn wrote: > On Mon, Jun 10, 2024 at 07:10:20PM -0400, Sean Anderson wrote: >> This error message can be triggered by userspace. Use NL_SET_ERR_MSG so >> the message is returned to the user and to avoid polluting the kernel >> logs. > > This has nothing to do with statistics. So it would be better to post > it as a standalone patch. It is the sort of trivial patch that should > get merged quickly. I included it in the series since patch 3 touches lines near it. But upon reviewing that patch, it seems that these lines are not in that patch's context. So I will resumbit this separately. > I would also comment about the change from EFAULT to EBUSY in the > commit message. OK. --Sean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel