From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4338AC32771 for ; Sat, 24 Sep 2022 08:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HCZCTJf6eFKOl5XeZ9dxru+/5e7pvZhaXFoiIJbO3Us=; b=eHhtTB+KHX2TD1 7j8B2zDp3RQXwap+fAWdKgTgnh4XsK7ppdpJiGqk8tRqoPP6/QbGgbTRhr6TGA/J6Oe8Ymx3g25Gd bJIDvNyISSP4JbHuH/rLYld6I/Q2lB7yx0eCwcwhe9/rx3wJqqzTW+o8v5WTWxuge64fquv/OWkSx VRMY63x2qHh4iNuazufc61xExKgcRBg9q/dSZLeGXBHAjJPuhEiubaP4rbDc1MGkzHR3AxJLnp8lN uPJuTXFlI27j5gZLfkEMCy5cHfn+1dw2/oao4iS+LekPoaLRWFdIJHJRap7BzHicQhyRib0WzChsX JWOWKE565z0UlubCIOQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oc0bz-006hZw-3K; Sat, 24 Sep 2022 08:34:11 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oc0bu-006hZN-9u for linux-arm-kernel@lists.infradead.org; Sat, 24 Sep 2022 08:34:07 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 0568E2B06765; Sat, 24 Sep 2022 04:34:01 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Sat, 24 Sep 2022 04:34:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1664008441; x=1664012041; bh=/WWds24ntc UKbKWLsiLHKDoxKaoSccYQR5V3Km1yp4s=; b=BhkT20XEhvFZug/DAGPfWynldN u02HADT75UMmdSvz/VjsbL1cBuDFGdC+8TJOrLbXsgEsWfQUlHEy676nZJ92254r oQ54yOIiM8xuOz6aPiQZ1o4H6c6yNMu2V4ZDg3MYv/9TJTdCKZSg6W3GC/dXxXr0 GZ+q1TTT6nGzhJMLheGnn97Gwf6HXgFZDVenrdggdB6scG/RJZx+6R1LAV4q15KF jPm2+z8t5kWwJDr9lfvyrMiDZtwNgAW7tUVUyxYVzHwuKg2Z6VO+lbPpRKZHQG0z +wn2/+LgnEdnqPCZSMgwzdlOPNZEW/mwAdq8kKIBSZld9qab+wGwFhfnhq7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664008441; x=1664012041; bh=/WWds24ntcUKbKWLsiLHKDoxKaoS ccYQR5V3Km1yp4s=; b=0rG88KEBbrUvwYUlsGimvq4nvPwN/kdGSw2+zWZrDMLl ygFQfRlpfYV0ik2JZjZ+Es17o+OjwO/b3zY43n3b3Vz9XFMUVR39dxh0cpuMUQkJ tpzyWj+fTppZD/dDgYKRZFjrLm0drCV9Prx6ZWgGWc+BlmZOcVAgOTxwwGWVrXbQ fljwWG0IAMDX0Ug9jrI6vXxss1YjLgZ0CnkjrMux0f1JKtTFrhUHzBsbJrBgaUQc YBgz4aGLiVy5yZwNusQpbNT+7xml71lE0/6P8qGdCPLJhdSghxx4TTwAqMyzuuSB 8yI247cIoS/Yuto6cFiXztGsIUpO9XTvsE9yZkdTjg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefkedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id ECB1CB60086; Sat, 24 Sep 2022 04:34:00 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-935-ge4ccd4c47b-fm-20220914.001-ge4ccd4c4 Mime-Version: 1.0 Message-Id: <68c63077-848b-45f5-8aca-ed995391f2b6@www.fastmail.com> In-Reply-To: References: Date: Sat, 24 Sep 2022 10:33:29 +0200 From: "Arnd Bergmann" To: "Dmitry Torokhov" , "Alexandre Belloni" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Claudiu Beznea" Subject: Re: [PATCH] pcmcia: at91_cf: switch to using gpiod API X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220924_013406_673072_407CE30A X-CRM114-Status: GOOD ( 22.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 24, 2022, at 8:04 AM, Dmitry Torokhov wrote: > This patch switches the driver to use newer gpiod API instead of legacy > gpio API. This moves us closer to the goal of stopping exporting > OF-specific APIs of gpiolib. > > While at it, stop using module-global for regmap. > > Signed-off-by: Dmitry Torokhov This looks good to me overall. Three comments: > @@ -63,7 +62,7 @@ struct at91_cf_socket { > > static inline int at91_cf_present(struct at91_cf_socket *cf) > { > - return !gpio_get_value(cf->board->det_pin); > + return gpiod_get_value(cf->board->det_pin); > } a) The change in polarity looks wrong here, I can't really tell from the patch. If this is intentional, maybe explain it in the changelog. With that addressed (either way) Reviewed-by: Arnd Bergmann b) In case you are doing more patches like this one at the moment, note that I'm in the process of removing all unused board files for arch/arm/, which will in turn make a lot of drivers unused. I should be able to provide a branch soon, which can be used to identify drivers that don't have DT support any more and don't have any board files. Rather than converting them to gpio descriptors, we can probably just remove those drivers. c) I'm not sure about the state of the at91_cf driver. Apparently we used to have three drivers for the same hardware (pcmcia, pata and ide), and only the pcmcia driver remained in the tree after drivers/ide/ was removed and pata_at91 did not get converted to DT. I think in the long run we will remove the pcmcia layer, so if you are actually trying to use this hardware, we may want to revive the pata variant and drop this one instead. There is no dts file in tree that actually declares either of them, so chances are that nobody is actually using the CF slot on at91 any more. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel