From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbaron@akamai.com (Jason Baron) Date: Mon, 27 Feb 2017 17:50:25 -0500 Subject: [PATCH] jump_label: align jump_entry table to at least 4-bytes In-Reply-To: <7bd72716-feea-073f-741c-04212ebd0802@caviumnetworks.com> References: <1488221364-13905-1-git-send-email-jbaron@akamai.com> <93219edf-0f6d-5cc7-309c-c998f16fe7ac@akamai.com> <20170227160601.5b79a1fe@gandalf.local.home> <6db89a8d-6053-51d1-5fd4-bae0179a5ebd@caviumnetworks.com> <20170227170911.2280ca3e@gandalf.local.home> <7fa95eea-20be-611c-2b63-fca600779465@caviumnetworks.com> <20170227173630.57fff459@gandalf.local.home> <7bd72716-feea-073f-741c-04212ebd0802@caviumnetworks.com> Message-ID: <68fe24ea-7795-24d8-211b-9d8a50affe9f@akamai.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/27/2017 05:45 PM, David Daney wrote: > On 02/27/2017 02:36 PM, Steven Rostedt wrote: >> On Mon, 27 Feb 2017 14:21:21 -0800 >> David Daney wrote: >> >>> See attached for mips. It seems to do the right thing. >>> >>> I leave it as an exercise to the reader to fix the other architectures. >>> >>> Consult your own binutils experts to verify that what I say is true. >> >> It may still just be safer to do the pointers instead. That way we >> don't need to worry about some strange arch or off by one binutils >> messing it up. > > Obviously it is your choice, but this is bog standard ELF linking. In > theory even the arrays of power-of-2 sized objects should also supply an > entity size. Think __ex_table and its ilk. > > > The benefit of supplying an entsize is that you don't have to change the > structure of the existing code and risk breaking something in the process. > > David Daney > > Thanks for the suggestion! I would like to see if this resolves the ppc issue we had. I'm attaching a powerpc patch based on your suggestion. Hopefully, Sachin can try it. Thanks, -Jason -------------- next part -------------- A non-text attachment was scrubbed... Name: ppc-pack.patch Type: text/x-patch Size: 1975 bytes Desc: not available URL: