From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CB0FC678D4 for ; Fri, 3 Mar 2023 10:14:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HnuKUr5QGX2DTyeXcYQvDTJit3GvNoP2KbHaaZLkxgk=; b=l2W6G2WbIPB3K6 IVE6w/ZX020d8qlfxC/gjU5wfclqRZoURMcWXUc+vYW/VmcFtXB4M7FBbSNt7vBUwoSIYLp8IZXLk RKh6xomOQXKc97tc6o+WwjyVoWLG05dpfPoYaU+JN9On9amGiTuiKzw/b6sJk/6K9P2swmbRpm734 0B0s435ik2p/MVUEK6g+XxpQkhZ044+PHG7zF5iTkdPEyYNXNTUk2e6vmUVSFU355EvJyD43I4dUI t5QJWHb7J0za9itqPd2ShdUYdYnXg8NoqSbm6e1gnc63QY2KTDGvJZpQPzPSz2Y+UWSbQ1LAtQ2l5 R9Kv+5h7Nf8Do3OAjcNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY2PQ-005yIX-Ak; Fri, 03 Mar 2023 10:13:04 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY2PM-005yFI-KA for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 10:13:02 +0000 Received: by mail-ed1-x534.google.com with SMTP id g3so8291036eda.1 for ; Fri, 03 Mar 2023 02:12:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677838361; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wIXpkJrhXTPwGpv7CslgbXTP5NsG/65llnuvwiJ94Xo=; b=F+wT+WYF1s8KiGpaCpHuq6j21Oy+hkULUoUT1oL/0G67XEYLxp+nuJvTYtIySgnnE7 BLg9JlCla+mhai9qMEvjnpojEWFK+pk3E2ojrqYhMFLBiNuLBN5SwlFsMIIbCBeZDFpK 9AChHRuU4rKc/fq6mGithDketvTbQ0K1VRBO9Msw/zgsXOPBdPkQg0IdaneD7ShSU4od t3nhFiZRTAz8O6B3hWHBNzxUFNUc4GR6BgTBOP3Ny5PNYj0dR8Aoo4kYP2e6gnFF5rTJ TENBctVZF6N4e3Rx4vcK4qbZRxGe56Ld0OHuKWisHGK04TEuwOUGTvitswVfvqg0dLPJ SdHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677838361; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wIXpkJrhXTPwGpv7CslgbXTP5NsG/65llnuvwiJ94Xo=; b=HlAH3L9wgS9xxDZyrUv90GIl7NyFTu4nLJdnh25puXFil6aleZoD+8cDi+Y8cQLRjk ymWojHM0ut205hs99CUU+n5kf7cZXVc7I1Ux2mQMF1Pmvg2ER7RsO2PmLYUhU/Hcu6ho WcnEsQf4IG6BA0wXa0qEH42Bj0nF99Xagu0AUYxzJX8BlSbT0UWP3N2aeTpu1MLIClSh WUcUT4bbZK249xIMX+m1N2FFCq2HfeW7yjQEH2pL9QcxHBfacAwEQFDOZCxVn3ZArOMB 78cmQneOEGJ6X1hkXWO2DioAj457BcPjIz2K9hRDowU321x4d+1HUModWvWimT/Tto1P k+QA== X-Gm-Message-State: AO0yUKX8iwRqZet0MLnvNkxXYtmGXIQDPEvdd0FcZwQOQG5CapuR1FVh BzkulCOvl2kVrpYVh2CzAUUjVA== X-Google-Smtp-Source: AK7set9InJ7ZobX7OkawZpjXpE9ZuWZ2mzMhO1nV58gYpmXHx6LmAwUTVwzlW/aazm++QwUmDo3hrQ== X-Received: by 2002:a17:906:3106:b0:8b1:7eb4:6bea with SMTP id 6-20020a170906310600b008b17eb46beamr1000101ejx.38.1677838360754; Fri, 03 Mar 2023 02:12:40 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h3-20020a170906590300b008ddf3476c75sm789818ejq.92.2023.03.03.02.12.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 02:12:40 -0800 (PST) Message-ID: <690dec31-6de6-efe4-c1b1-f434ff1a771f@linaro.org> Date: Fri, 3 Mar 2023 11:12:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe Content-Language: en-US To: Shradha Todi , lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-2-shradha.t@samsung.com> <139501d94d06$2e159850$8a40c8f0$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <139501d94d06$2e159850$8a40c8f0$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_021300_711876_D9C3BD1D X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/03/2023 13:54, Shradha Todi wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 16 February 2023 16:24 >> To: Shradha Todi ; lpieralisi@kernel.org; >> kw@linux.com; robh@kernel.org; bhelgaas@google.com; >> krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; >> jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; >> lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; >> m.szyprowski@samsung.com; jh80.chung@samsung.co; >> pankaj.dubey@samsung.com >> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to >> Samsung PCIe >> >> On 14/02/2023 13:13, Shradha Todi wrote: >>> The current DT bindings is being used for Exynos5433 SoC only. >>> In order to extend this binding for all SoCs manufactured by Samsung >>> using DWC PCIe controller, renaming this file to a more generic name. >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> Signed-off-by: Shradha Todi >>> --- >>> .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) rename >>> Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => >>> samsung,pcie.yaml} (93%) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml >>> similarity index 93% >>> rename from >>> Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml >>> index f20ed7e709f7..6cd36d9ccba0 100644 >>> --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml >> >> We keep the name rather tied to compatible, not generic. There are no other >> compatibles here, so I don't think we should rename it. >> > > Our intention to rename was to have a common name for Samsung manufactured SoCs having PCIe controller. > Though this change may not be a blocker for us but we feel it will be good to have a common name as this file will > not have bindings only for Exynos series of SoC (Samsung Sys. LSI designed) but also custom ASICs such as FSD / ARTPEC SoC (Samsung Foundry designed). > We hope we are not breaking any ABI as such in this patch. There is no FSD/Artpec added here, so renaming just for "rename" is a no. If you add new hardware here, this could have sense, depending on the hardware. But since we pretty often expect the first compatible to be the name of the file, why renaming at all? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel