From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B1AC43461 for ; Tue, 15 Sep 2020 19:35:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B2F42064B for ; Tue, 15 Sep 2020 19:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RCWkOAF7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T7rHCHK0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B2F42064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pi9dv7j8KBVBTcNgaT2B+FcTEl8z4wznavRvwoy2LSQ=; b=RCWkOAF7Uoa4gsN/RjP85kH3n SoGA+HvwfyEQK7ZFlVJcYHojrVb9vA6fiHju5Zzy7MQuAc6bqb29p3nl4YYIOQiqz8A4tZC0v8IU1 1CSo7xaUl30GN0AjnrIwUEflbrigJeLnF6g15pvqunxE+A/tD2B6b9ofb2P0/QGzTdaKWWzIpI7YQ hhXXAX4NbmMz9zy6vgaW/DR6bbHNdZVbKQw/gJEdUeXBH2p3G+nXW9DYBz/kGG+9QpbD39J2/4Ci2 KXzbGK54VNBCxiKfQIp1tzEpOUyccQnH2CyzdA4GHYt5ftInHkqMSHi/OIIfVh44595GFo1Dl1sNQ fumnlj5ng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIGiF-00010o-Nh; Tue, 15 Sep 2020 19:33:59 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIGiC-0000zq-RI for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 19:33:57 +0000 Received: by mail-pf1-x444.google.com with SMTP id b124so2510780pfg.13 for ; Tue, 15 Sep 2020 12:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ilVz9b6REPKrYKXGMSZDZJ/4PE1awctJVmiZRDvsYnM=; b=T7rHCHK0yazSYxhoaeaaQAUQX0wEWreFsk+vdLUAaIF9OT32QkScrYl9jeFQDyyyot FRTU55mhu00DYjkz+ay7xre1umF6i+TK5fLA42jOP6DXmvl+xpdoADeJ5AS8vjC4OY7D BZBc9v0KPA2iVChzpd+yln0egBare2E3ka2pBIAtj1qAlWY9llCXvf+Mm+a0pbW85AN7 Iaz+RCoYUi92hv4Tk4E66SuTZGjDe+T6B9YNVdWgwCGXsm+mqj1s7PDj8XbydbB0Qhdn K+X5RKUKrSIP3iGKzaZAeAROmrjiFMlEaXrDKax/xzn5mPcWoX2DIto3pJ0O3cW2UmUN 2itg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ilVz9b6REPKrYKXGMSZDZJ/4PE1awctJVmiZRDvsYnM=; b=X3m6n3WGh7UZCaElvy/mRMl8IH5GlrO+pEmeJcFRCmacbr0e31m0VgIeUsfVt4avwC 7VPxFB+DPQTULg8jd7PGQWP6GZFFwxLpH1Rzf9oQMzWEfvRvL+3EHDpKGQeJE530OgnQ CFClF0tzkG18Smd5aeFiC0pYCrJhX9Rr4lycWu6mcczgcUN7SEFEobiT64Z8Dcs1Q1vP YahjDB4F7KmHM393nJjITj8Dx+MjFIjrcntCUGUJy1yinyZc/9J8GnX5Ez7Gw1r4zJZg T5wamGh/wHffGzGNoDrxJyqTYyDN7GuY1opXJv5eVEk8jXdkNw6IW2ARHp3FQPRavM3r Efpw== X-Gm-Message-State: AOAM532p0Bi5P5eRYd2Zo4fGIa9gODl5VxFwHfXsWmrUjOeOWsh8EL/Z 00XTTVNR2SbRFGtsNlwIpGUEeIhJcCtTgA== X-Google-Smtp-Source: ABdhPJznkwpNsB+sy8J0qXZ93Bl9U+K9ML5t3hG5Wx3ldlKKF3zqkhg3Z98T2b8VQn5WuCXwiK8rOQ== X-Received: by 2002:a62:fc06:0:b029:142:2501:397d with SMTP id e6-20020a62fc060000b02901422501397dmr3255460pfh.66.1600198432651; Tue, 15 Sep 2020 12:33:52 -0700 (PDT) Received: from [10.230.28.120] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g129sm2655042pfb.9.2020.09.15.12.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Sep 2020 12:33:51 -0700 (PDT) Subject: Re: [PATCH v1 2/2] mailbox: Add Broadcom STB mailbox driver To: Jim Quinlan , bcm-kernel-feedback-list@broadcom.com References: <20200915193109.16034-1-james.quinlan@broadcom.com> <20200915193109.16034-2-james.quinlan@broadcom.com> From: Florian Fainelli Message-ID: <6924a28d-ceb6-6d96-b84a-9f8919de9866@gmail.com> Date: Tue, 15 Sep 2020 12:33:50 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200915193109.16034-2-james.quinlan@broadcom.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_153356_886896_E00CE9A2 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jassi Brar , Florian Fainelli , open list , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jim, On 9/15/2020 12:31 PM, Jim Quinlan wrote: > This is a simple mailbox driver to be used by the SCMI protocol stack. It > only implements the agent-to-platform channel; we may implement the > platform-to-agent channel in the future. An unusual aspect of this driver > is how the completion of an SCMI message is indicated. An SCMI message is > initiated with an ARM SMC call, but the return of this call does not > indicate the execution or completion of the message. Rather, the message's > completion is signaled by an interrupt. > > Signed-off-by: Jim Quinlan > Signed-off-by: Florian Fainelli > --- > drivers/mailbox/Kconfig | 13 +++ > drivers/mailbox/Makefile | 2 + > drivers/mailbox/brcmstb-mailbox.c | 173 ++++++++++++++++++++++++++++++ > 3 files changed, 188 insertions(+) > create mode 100644 drivers/mailbox/brcmstb-mailbox.c > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index 05b1009e2820..bebf7da778bc 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -254,4 +254,17 @@ config QCOM_IPCC > acts as an interrupt controller for receiving interrupts from clients. > Say Y here if you want to build this driver. > > +config BRCMSTB_MBOX > + tristate "Broadcom STB Mailbox" > + depends on ARM64 || ARM > + depends on ARM_SCMI_PROTOCOL && ARCH_BRCMSTB > + depends on SMP We can actually remove the SMP dependency cannot we? This was needed back when we used the hackish way of hooking to IPIs in the downstream kernel which we fortunately no longer do. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel