[PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

Arnd Bergmann
2015-04-29T14:45:30Z

On Wednesday 29 April 2015 19:55:53 Suman Tripathi wrote:
> >
> > The above assumes that the limitation is enforced by the bus (e.g. an
> > AHB bus can only do 32-bit DMA). It would be a little different if you
> > have a 64-bit AXI bus and the Arasan device itself is limited to 32-bit
> > independent of the width of the bus it is connected to. Can you find out
> > which of these two cases you have?
> >
>
> We have 64 bit AXI and Arasan device or controller is 32 bit . So there is
> 64 bit AXI to 32 bit AHB translation.

Please be very specific here. If this is an AHB based MMC controller, you
should model that AHB bus in DT, with the 32-bit dma-ranges.

However, if this is an AXI based MMC controller that is limited to 32-bit
DMA, the correct change would be to make ensure that the driver never
asks for a 64-bit DMA mask with this hardware.

Both will result in a 32-bit dma mask being used, and high DMA handled
through the block bounce code or swiotlb, but it's best to ensure that
the DT representation matches the actual hardware as closely as possible,
so it keeps working when you change something in a future chip.

Arnd