From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 168D3C77B72 for ; Mon, 17 Apr 2023 08:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SsbmJec/BcG5bAro8yf1+QFOUgwnPhqeV58ufjU4ciM=; b=oW7tSBL4o23I2H nRrcXM8oZ6SE9ArbRjcDqv4J+0K6v6gdSGT9uGCTDu8bjNizEPcRpP5Gbf7VfeEXzx+GWEmyT34tK S8YS0PdnN9giQvYui6/lGR8JHc9ApBCoqAiwOfIhImRrMBH/qknN5pqPv06WQruWjP6jv3jZejItd rfRFPSolxTijiQ23FbCCP8angrtsnN0fLtNWnWrwLkOST/6I5/E+4k4GWsu5pezewf7YHDek431TB EJly/z1tk7KDTBjSfHQ9KH4KW77X38y9/uPMf1XxGMPiLJYLvspDVc5bONzRTu8lvgE7qsP8rFCQQ 1sIAzyToOZFk7QuL89Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poK71-00FMIW-0y; Mon, 17 Apr 2023 08:21:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poK6y-00FMHL-1s; Mon, 17 Apr 2023 08:21:21 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1poK6b-0001cB-Kj; Mon, 17 Apr 2023 10:20:57 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Joerg Roedel , Will Deacon , Robin Murphy , Marc Zyngier , Olof Johansson , Chao Wang Cc: hust-os-kernel-patches@googlegroups.com, Chao Wang , Dongliang Mu , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: Fix unwind goto issue Date: Mon, 17 Apr 2023 10:20:56 +0200 Message-ID: <6931079.K2JlShyGXD@diego> In-Reply-To: <20230417030421.2777-1-D202280639@hust.edu.cn> References: <20230417030421.2777-1-D202280639@hust.edu.cn> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_012120_615518_4B8E2F6B X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 17. April 2023, 05:04:21 CEST schrieb Chao Wang: > Smatch complains that > drivers/iommu/rockchip-iommu.c:1306 rk_iommu_probe() warn: missing unwind goto? > > The rk_iommu_probe function, after obtaining the irq value through > platform_get_irq, directly returns an error if the returned value > is negative, without releasing any resources. > > Fix this by adding a new error handling label "err_pm_disable" and > use a goto statement to redirect to the error handling process. In > order to preserve the original semantics, set err to the value of irq. > > Fixes: 1aa55ca9b14a ("iommu/rockchip: Move irq request past pm_runtime_enable") > Signed-off-by: Chao Wang > Reviewed-by: Dongliang Mu Looking at the code, that makes a lot of sense. Reviewed-by: Heiko Stuebner _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel