From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DE8C10F09 for ; Fri, 8 Mar 2019 12:07:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B1F020684 for ; Fri, 8 Mar 2019 12:07:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GFVyM/8r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B1F020684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=orktGNL9eq2r16xi7R218Xuf9YmM7w1+EZa8VT6Ew1A=; b=GFVyM/8rQvwuKv7oflhfvxVwN /zTSL710nlw2Ub2ndv2VqJJbbp+t9JVJk50tonzhfY3PKM9iO+AazAMRou38dyA9xL36+5kmOP5RW UwMnuMsO/6A+JuqsInx1mOJq0ejM7g2jiZlLEEEiO8QTQBSpS8SRnyM6koh4u2h3kamAra459lETc 4L6iRJoVBYWkXObjGrgIZL9/g/Kc+UggTJ0iDAiGPxRqrvRQJlZr2VClf3sbmG37yALEa6mDtdkEe ZrFyd9DI0l4RoDCYYscx+ytBEO+M75ebbLScMf7EV6NEs823uyfDavg+Eb8F2HDJYbhr5dPGDtbG4 2AfGFPYlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2EI0-0006yO-Fm; Fri, 08 Mar 2019 12:07:48 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2EHt-0006xI-Vt for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2019 12:07:46 +0000 Received: by mail-ed1-f66.google.com with SMTP id c55so16225752edb.0 for ; Fri, 08 Mar 2019 04:07:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=//WICpYL2sIU8xG0IGhIJRsEKn5vd6H7DZAjSt6+vEw=; b=VCou4Fk9+SmU5WN8Emq+JaCbYcbcSVArwcNcKIYWpS9wBGa+Elwacl7yjPS+nImlm+ iwLRHLW24f4FJ0IUKRJqHJXBmBbPy4m4oxyTsU2NgjsBShoDeYLx7h4O8FfX3vvESc16 Z+LZGlYJSM/pbGwOwuO4eI1GfBo+FvljWDX/Co7H4D09bkOyBjTZSiOIzUs0O8cg6aph CCr55kfmSzC4usi4LPm/x9KppTZ6YhFbEbFmXZcRAX+Y3rVgaw4DYspaGnwyAs6PlvgF rHKUvxa5IC/1+5hmCBSK0HzCuvgjR4sWHSZUg5Ca6gJx93EtMs56Hu4BzQxrgdGFenez t9VA== X-Gm-Message-State: APjAAAUBUZnobgO2I1uuewOp+jWc+g9+5YincAdbYGOvNhXm9CcORuUj TGK0itVB70FWADwkyl972YMH7A== X-Google-Smtp-Source: APXvYqz2Bey2O5sZtOvfrAkNpkMvFQFIQ6mYIruzgkJXIEeL4Rnm2HxsdcGy74unbr9mO41E+WOEmw== X-Received: by 2002:a50:9fe9:: with SMTP id c96mr33245420edf.0.1552046860040; Fri, 08 Mar 2019 04:07:40 -0800 (PST) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id x21sm1397221ejf.65.2019.03.08.04.07.38 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 04:07:39 -0800 (PST) Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B To: Chunfeng Yun , Rob Herring , Greg Kroah-Hartman , Heikki Krogerus References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> From: Hans de Goede Message-ID: <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> Date: Fri, 8 Mar 2019 13:07:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_040744_599626_A5202300 X-CRM114-Status: GOOD ( 21.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 08-03-19 07:13, Chunfeng Yun wrote: > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > usb-b-connector > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > index a9a2f2fc44f2..7a07b0f4f973 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > @@ -17,6 +17,16 @@ Optional properties: > - self-powered: Set this property if the usb device that has its own power > source. > > +Optional properties for usb-b-connector: > +- id-gpios: gpio for USB ID pin. What about boards where the ID pin is *not* connected to a GPIO, but e.g. to a special pin on the PMIC which can also detect an ACA adapter ? Currently this case is handled by extcon drivers, but we have no way to set e.g. vbus-supply for the connector. Maybe in this case the usb-connector node should be a child of the PMIC node ? And in many cases there also is a mux to switch the datalines between the host and device(gadget) controllers, how should that be described in this model? See the new usb-role-switch code under drivers/usb/roles In some cases the mux is controlled through a gpio, so we may want to add a "mux-gpios" here in which case we also need to define what 0/1 means. > +- vbus-gpios: gpio for USB VBUS pin. > + see gpio/gpio.txt. > +- vbus-supply: reference to the VBUS regulator, needed when supports > + dual-role mode. I think this needs some text that there can be either a vbus-gpio or a vbus-supply. Oh wait reading: https://patchwork.kernel.org/patch/10819377/ I see that this GPIO is for detecting vbus presence, not for driving/enabling 5v to Vbus from the board, that needs to be described more clearly. > +- pinctrl-names : a pinctrl state named "default" is optional > +- pinctrl-0 : pin control group > + see pinctrl/pinctrl-bindings.txt > + > Optional properties for usb-c-connector: > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > connector has power support. > Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel