From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA04EC2BB1D for ; Fri, 13 Mar 2020 16:19:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 813C2206B7 for ; Fri, 13 Mar 2020 16:19:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rgcp+xHo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UaJGqhaS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 813C2206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jbkq1jzZwx6rg/tBVu/mbTuiSxQeWYOxAs0GfJCTHPM=; b=rgcp+xHopw8GFE tvkiIeTdtUsZDdHawSv18VarBTCtO/CGrypUJc19Yv2B/GmGMMuhYYE6/f0H0e+iB6Ny38Z3I7P1t oXstBm+mU67bayIjb0esFCVPKIED/qZGOZWRZERWtDUriQV7jJ6xf+bgEfDcqezkWcDsspAWaOhld Mvp6h+D6HByvLWWvYzQb8fprafkWAzEmd9y+KUBPHbfP6gF+cKRRuwaNX8IizFi2DHT9PmHPo6wvr iN8Uw1ZiFiCRj3mvfBlknP/wQMDJbJO1Prwv99Pq2HOWq0SuTEpr1pgfq3rUytbUZ1jUBMwivKup2 WMFQCtYPTuqA/wfDJT+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCn29-0000Ru-3I; Fri, 13 Mar 2020 16:19:37 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCn26-0000R4-Pe for linux-arm-kernel@lists.infradead.org; Fri, 13 Mar 2020 16:19:36 +0000 Received: by mail-wm1-x341.google.com with SMTP id z12so1759733wmf.5 for ; Fri, 13 Mar 2020 09:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DzWpdx6328OZ0aH4x17MPaDC7GHF6Gljp2V0qUX/DXo=; b=UaJGqhaStKvtpmCHIX3kKDpHnWc+X5jToC5SA/qFSF367bfEjsz2TVGFQPWSP8HeUx GRLu8BKAOod/fH4D9Sowc0g+v0PGZvefYUcatrjW7Hns/gHMn0/5MvDT//4Z9EWPhYvQ KJah4mfhH2zRxGewD8tH3WSFEYvcHtW/vfQO6ucpmC8zuWcsqvQ5w246yKiWspujo/Ly vdN9l8dgYdikc6SF9YTp5CKa4Mi8ppQT3A9PbDL/lzQqsfGXhMpz8T50Q2WliEJDvN7x nJt9rp5Tyx77XMF6/Rv1OlehOLOIkgQL2QYO5J0J0WTA4aa++VluIhkdS0C3yTOp8PjN Y+nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DzWpdx6328OZ0aH4x17MPaDC7GHF6Gljp2V0qUX/DXo=; b=B/Gr++Kis8CJ67Bb1sXHVz3JJaFrdM5DctssltcbFVfXV2pvOH6gqTx4mBHQ8S1HoP IGr6GcS853WaYmxEp6kXPypdUTsqYzjj1Mj5r598rWAnjkMfVW7hMX8zBbTT/Rl4xtT5 HW8OEMkAzDqUqqo84bITh/xS62gfB4qXdcGOFdKVF5QypnHkjsZFPVf8wkq63YxolzKI IcdxM2sy2CzSO5krkDfgWEaubvA9aDffqSSL7v+0OG/EXr0m6wtzbB/5Fn7D+DwVa/z+ kwDR0NjSumcMyepjXQFMs7qWWdceQOSDKrcQRhDt5ZDiJ1Ts38F8zEIc/rHSrDKjYY/V 3kUg== X-Gm-Message-State: ANhLgQ1bHaqGp8N39bnNlFDdmc8WE3fb6fT5vJJz2xCONqa0k1fK7UEH tARCEOB1TDRr+kT8vt0CNCM= X-Google-Smtp-Source: ADFU+vsq06fil7othF27XQT8Yzw4TwrwXBYm7m6KjdoRKe730VpT0nmboNEJS30sUYpx7sh4hoWlkQ== X-Received: by 2002:a1c:791a:: with SMTP id l26mr11500620wme.103.1584116370132; Fri, 13 Mar 2020 09:19:30 -0700 (PDT) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id w1sm16365071wmc.11.2020.03.13.09.19.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 09:19:29 -0700 (PDT) Subject: Re: [PATCH v3 00/26] Introduce common headers for vDSO To: Vincenzo Frascino , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org References: <20200313154345.56760-1-vincenzo.frascino@arm.com> From: Dmitry Safonov <0x7f454c46@gmail.com> Message-ID: <693b6a61-b5f6-2744-1579-b356e6510547@gmail.com> Date: Fri, 13 Mar 2020 16:19:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200313154345.56760-1-vincenzo.frascino@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_091934_838515_FBCC9E65 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nick Desaulniers , Kees Cook , Arnd Bergmann , Stephen Boyd , Catalin Marinas , Will Deacon , Russell King , Mark Salyzyn , Paul Burton , Ingo Molnar , Borislav Petkov , Andy Lutomirski , Marc Zyngier , Thomas Gleixner , Peter Collingbourne , Andrei Vagin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vincenzo, all I like the idea, but I'm wondering if we could have less-grained headers? Like, AFAICS the patches create headers < 10 lines and even mostly < 5 lines.. I like that header's names perfectly describe what's inside, but I'm not sure how effective to have a lot of extra-small includes. Or maybe there's a plan to grow the code in them? On 3/13/20 3:43 PM, Vincenzo Frascino wrote: [..] > create mode 100644 arch/arm/include/asm/vdso/clocksource.h > create mode 100644 arch/arm/include/asm/vdso/cp15.h > create mode 100644 arch/arm/include/asm/vdso/processor.h > create mode 100644 arch/arm64/include/asm/vdso/arch_timer.h > create mode 100644 arch/arm64/include/asm/vdso/clocksource.h > create mode 100644 arch/arm64/include/asm/vdso/processor.h > create mode 100644 arch/mips/include/asm/vdso/clocksource.h > create mode 100644 arch/mips/include/asm/vdso/processor.h > create mode 100644 arch/x86/include/asm/vdso/clocksource.h > create mode 100644 arch/x86/include/asm/vdso/processor.h > create mode 100644 include/vdso/bits.h > create mode 100644 include/vdso/clocksource.h > create mode 100644 include/vdso/const.h > create mode 100644 include/vdso/jiffies.h > create mode 100644 include/vdso/ktime.h > create mode 100644 include/vdso/limits.h > create mode 100644 include/vdso/math64.h > create mode 100644 include/vdso/processor.h > create mode 100644 include/vdso/time.h > create mode 100644 include/vdso/time32.h > create mode 100644 include/vdso/time64.h Maybe we could made them less-grained? I.e, time32 + time64 + time.h => time.h? Thanks for Cc, Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel