From: Markus Elfring <Markus.Elfring@web.de>
To: Carlos Song <carlos.song@oss.nxp.com>,
imx@lists.linux.dev, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Cc: Carlos Song <carlos.song@nxp.com>,
Andi Shyti <andi.shyti@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v5 1/2] i2c: imx-lpi2c: properly unwind resources on probe failure
Date: Wed, 15 Jul 2026 08:50:41 +0200 [thread overview]
Message-ID: <693e0bee-6522-4d6a-803f-3bbd0ea2243b@web.de> (raw)
In-Reply-To: <5fp45u3yuwz73nk6eeofx5fp5drvaqxp435mithslttb73zylb@t2s3se5a4qux>
> Does it look better?
I suggest to reconsider missing tab characters in the indentation.
https://elixir.bootlin.com/linux/v7.2-rc3/source/drivers/i2c/busses/i2c-imx-lpi2c.c#L1471-L1583
Regards,
Markus
next prev parent reply other threads:[~2026-07-15 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:52 [PATCH v5 0/2] i2c: imx-lpi2c: fix probe error handling and reset controller carlos.song
2026-06-30 10:52 ` [PATCH v5 1/2] i2c: imx-lpi2c: properly unwind resources on probe failure carlos.song
2026-07-14 13:47 ` Frank Li
2026-07-14 14:10 ` Markus Elfring
2026-07-15 2:54 ` Carlos Song
2026-07-15 6:50 ` Markus Elfring [this message]
2026-06-30 10:52 ` [PATCH v5 2/2] i2c: imx-lpi2c: reset controller in probe stage carlos.song
2026-07-14 13:49 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693e0bee-6522-4d6a-803f-3bbd0ea2243b@web.de \
--to=markus.elfring@web.de \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=carlos.song@nxp.com \
--cc=carlos.song@oss.nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox