From: Flavio Suligoi <f.suligoi@asem.it>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
Daniel Mack <daniel@zonque.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/1] spi: pxa2xx: add driver enabling message
Date: Wed, 10 Apr 2019 12:01:15 +0000 [thread overview]
Message-ID: <6953cafeb6bc4367842f37f567bb893f@asem.it> (raw)
In-Reply-To: <20190410115431.GO6106@sirena.org.uk>
> On Wed, Apr 10, 2019 at 11:47:43AM +0000, Flavio Suligoi wrote:
>
> > You have right about to avoid too many boot messages,
> > but in this case, using an x86 machine and with
> > the spi-pxa2xx in DMA mode, so without the message:
>
> > "no DMA channels available, using PIO",
>
> > there is absolutely no indication about the existence
> > of the SPI master controller.
>
> It's totally fine to not have a boot print for the device, the best way
> to find devices if you need them is to look in sysfs anyway.
Ok
> > The second reason is about the DMA/PIO mode indication.
> > With the board I'm using, sometimes the spi-pxa2xx driver can't allocate
> > a DMA channel and works in PIO mode.
>
> > So, with the advice of Jarkko, I think that a valid solution could be:
>
> > 1) remove the "no DMA channels available, using PIO" message
> > 2) add a new message with the indications of:
> > - controller mode (slave or master)
> > - transfer mode (DMA or PIO)
>
> > What do you think about this?
>
> If the system is randomly failing to assign a DMA channel when it should
> then shouldn't we just fix that? A print which is presumably intended
> to prompt the user to reboot to try to get things working doesn't seem
> like a good solution.
Right, I'm just fix the DMA problem (I'm preparing a patch about this)
Flavio
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-10 12:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 15:22 [PATCH 1/1] spi: pxa2xx: add driver enabling message Flavio Suligoi
2019-04-09 13:48 ` Jarkko Nikula
2019-04-09 14:11 ` Flavio Suligoi
2019-04-10 7:55 ` Jarkko Nikula
2019-04-10 8:13 ` Flavio Suligoi
2019-04-10 8:29 ` Jarkko Nikula
2019-04-10 8:47 ` Flavio Suligoi
2019-04-10 9:47 ` [PATCH v2 " Flavio Suligoi
2019-04-10 10:11 ` Jarkko Nikula
2019-04-10 10:16 ` Flavio Suligoi
2019-04-10 10:32 ` [PATCH " Mark Brown
2019-04-10 11:47 ` Flavio Suligoi
2019-04-10 11:54 ` Mark Brown
2019-04-10 12:01 ` Flavio Suligoi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6953cafeb6bc4367842f37f567bb893f@asem.it \
--to=f.suligoi@asem.it \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).