From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24081C07E95 for ; Tue, 13 Jul 2021 09:31:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E704460720 for ; Tue, 13 Jul 2021 09:31:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E704460720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zwjpXVCRx/JjABRUhGmErk+9d0/EzN7uiqFDBtpSBA8=; b=LFb+Wij22ltTHr E3I8DRNTEY5PGAgFjOqJKabfEH28orrnr6jNVgv2X7lubCOdh/5wJEcFtxR19c6RkFjXXrjzLidH4 KG1ufqQOtQSjcGhVTuUUlYBn+Ua50WZk+tB0hRKxdHCLFJ5971NPYsQOOOWCV55/YNylb4OyBwgbq ynRXd0/ibLFlRLXf7bHXR2nnwcVT55NX3l2dHlA2X1P1BidL5FFPP07fCgmSZujIKSB74E87BWJ/E ftPw+ieU9WB45PUrmKvFSiFuZwEn4QJuh2yLeiJI/j3/v2wW8yJ4Jl6YI0sMqUIiMGyin3z/YB8Ih 5DJKXaEEgwNTsnBlFHJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3EkF-009ds1-3W; Tue, 13 Jul 2021 09:30:27 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3EkA-009dqm-HI for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 09:30:24 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3Ejr-0000rp-Gk; Tue, 13 Jul 2021 11:30:03 +0200 Message-ID: <695d47eb5dad9292d8f87e69ad1bccaa2e132a66.camel@pengutronix.de> Subject: Re: [PATCH v14 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul From: Lucas Stach To: Robin Gong , "vkoul@kernel.org" , "mark.rutland@arm.com" , "broonie@kernel.org" , "robh+dt@kernel.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "shawnguo@kernel.org" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "martin.fuzzey@flowbird.group" , "u.kleine-koenig@pengutronix.de" , "dan.j.williams@intel.com" , "matthias.schiffer@ew.tq-group.com" , "frieder.schrempf@kontron.de" , "m.felsch@pengutronix.de" , Clark Wang Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Tue, 13 Jul 2021 11:30:01 +0200 In-Reply-To: References: <1617809456-17693-1-git-send-email-yibin.gong@nxp.com> <1617809456-17693-9-git-send-email-yibin.gong@nxp.com> <7ca4554c58908618705768e01239409d19f83d17.camel@pengutronix.de> User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_023022_628998_D5AAE750 X-CRM114-Status: GOOD ( 27.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, dem 13.07.2021 um 09:12 +0000 schrieb Robin Gong: > On 12/07/21 17:31 Lucas Stach wrote: > > Am Montag, dem 12.07.2021 um 03:48 +0000 schrieb Robin Gong: > > > On 09/07/21 17:42 Lucas Stach wrote: > > > > Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong: > > > > > ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and > > > > > i.mx8m/8mm still need this errata. Please refer to nxp official > > > > > errata document from > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww > > > > w.n > > xp.com%2F&data=04%7C01%7Cyibin.gong%40nxp.com%7C48156bc93d > > > > > > c84ac26e9d08d942bdc0ac%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% > > > > > > 7C1%7C637614205017900475%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > > > > > > wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a > > > > > > mp;sdata=keYQubzt1jWrKhaxXr40RL41vzFuIn7x1Sasa3p%2F9Xo%3D&res > > > > erved=0 . > > > > > > > > > > For removing workaround on those chips. Add new i.mx6ul type. > > > > > > > > > > Signed-off-by: Robin Gong > > > > > Acked-by: Mark Brown > > > > > --- > > > > > drivers/spi/spi-imx.c | 47 > > > > > +++++++++++++++++++++++++++++++++++++++++++---- > > > > > 1 file changed, 43 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index > > > > > cf235b9..d18ee25 100644 > > > > > --- a/drivers/spi/spi-imx.c > > > > > +++ b/drivers/spi/spi-imx.c > > > > > @@ -59,6 +59,7 @@ enum spi_imx_devtype { > > > > > IMX35_CSPI, /* CSPI on all i.mx except above */ > > > > > IMX51_ECSPI, /* ECSPI on i.mx51 */ > > > > > IMX53_ECSPI, /* ECSPI on i.mx53 and later */ > > > > > + IMX6UL_ECSPI, /* ERR009165 fix from i.mx6ul */ > > > > > > > > This patch could be a lot smaller if you didn't introduce a new > > > > devtype. You could just use the IMX51_ECSPI in > > > > imx6ul_ecspi_devtype_data, as all you care about as a relevant > > > > difference is the tx_glitch_fixed property, which isn't tied to the devtype. > > > I knew tx_glitch_fixed was enough but I still prefer to add new > > > 'IMX6UL_ECSPI' because we can clearly choose the right IP which has > > > fix the issue while legacy IMX51 if it's not fixed by dts. > > > > > Sorry, I don't follow this reasoning. You are not using the new IMX6UL_ECSPI > > devtype in any way in this patch, other than a single location, where you just > > handle it the same as the IMX51_ECSPI devtype. > Okay, will reuse IMX51_ECSPI as devtype, but will still keep "fsl,imx6ul-ecspi". > That's exactly what I meant: have a "fsl,imx6ul-ecspi" compatible with it's own imx6ul_ecspi_devtype_data, but reuse the IMX51_ECSPI devtype. Glad we are on the same page now. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel