Re: [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

[Krzysztof Kozlowski <krzk@kernel.org>]

On 23/10/2025 08:43, Krzysztof Kozlowski wrote:
> On Fri, Oct 17, 2025 at 11:51:58PM +0000, Roy Luo wrote:
>> Document the device tree bindings for the USB PHY interfaces integrated
>> with the DWC3 controller on Google Tensor SoCs, starting with G5
>> generation. The USB PHY on Tensor G5 includes two integrated Synopsys
>> PHY IPs: the eUSB 2.0 PHY IP and the USB 3.2/DisplayPort combo PHY IP.
>>
>> Due to a complete architectural overhaul in the Google Tensor G5, the
>> existing Samsung/Exynos USB PHY binding for older generations of Google
>> silicons such as gs101 are no longer compatible, necessitating this new
>> device tree binding.
>>
>> Signed-off-by: Roy Luo <royluo@google.com>
>> ---
>>  .../bindings/phy/google,gs5-usb-phy.yaml      | 104 ++++++++++++++++++
>>  1 file changed, 104 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/phy/google,gs5-usb-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/google,gs5-usb-phy.yaml b/Documentation/devicetree/bindings/phy/google,gs5-usb-phy.yaml
>> new file mode 100644
>> index 000000000000..c92c20eba1ea
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/google,gs5-usb-phy.yaml
>> @@ -0,0 +1,104 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2025, Google LLC
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/google,gs5-usb-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Google Tensor Series (G5+) USB PHY
>> +
>> +maintainers:
>> +  - Roy Luo <royluo@google.com>
>> +
>> +description: |
>> +  Describes the USB PHY interfaces integrated with the DWC3 USB controller on
>> +  Google Tensor SoCs, starting with the G5 generation.
>> +  Two specific PHY IPs from Synopsys are integrated, including eUSB 2.0 PHY IP
>> +  and USB 3.2/DisplayPort combo PHY IP.
>> +  The hardware can support three PHY interfaces, which are selected using the
>> +  first phandle argument in the PHY specifier::
> 
> Just one ':', anyway this sentence and below does not belong to
> description but to phy-cells. You describe the cells.
> 
> Or just mention the header with IDs - here or in phy-cells.


If you go with free-form text description in phy cells, then some
example could be:
renesas,rcar-gen2-usb-phy.yaml

For the header (in this case clocks):
display/msm/dsi-phy-common.yaml


Best regards,
Krzysztof