From: Gavin Shan <gshan@redhat.com>
To: Ben Horgan <ben.horgan@arm.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Dan Carpenter <error27@gmail.com>,
James Morse <james.morse@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 1/2] arm_mpam: resctrl: Fix the check for no monitor components found
Date: Wed, 15 Apr 2026 09:08:33 +1000 [thread overview]
Message-ID: <699733d1-55ad-4cd7-9d14-f8562c00d598@redhat.com> (raw)
In-Reply-To: <20260414132758.196874-3-ben.horgan@arm.com>
On 4/14/26 11:27 PM, Ben Horgan wrote:
> Dan Carpenter reports that, in mpam_resctrl_alloc_domain(), any_mon_comp is
> used in an 'if' condition when it may be uninitialized. Initialize it to
> NULL so that the check behaves correctly when no monitor components are
> found.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Fixes: 264c285999fc ("arm_mpam: resctrl: Add monitor initialisation and domain boilerplate")
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
> ---
> drivers/resctrl/mpam_resctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
next prev parent reply other threads:[~2026-04-14 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 13:27 [PATCH v1 0/2] arm_mpam: resctrl: mpam resctrl glue code fixes Ben Horgan
2026-04-14 13:27 ` [PATCH v1 1/2] arm_mpam: resctrl: Fix broken error path in mpam_resctrl_alloc_domain() Ben Horgan
2026-04-14 13:31 ` Ben Horgan
2026-04-14 13:27 ` [PATCH v1 1/2] arm_mpam: resctrl: Fix the check for no monitor components found Ben Horgan
2026-04-14 23:08 ` Gavin Shan [this message]
2026-04-14 13:27 ` [PATCH v1 2/2] arm_mpam: resctrl: Make resctrl_mon_ctx_waiters static Ben Horgan
2026-04-14 23:09 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=699733d1-55ad-4cd7-9d14-f8562c00d598@redhat.com \
--to=gshan@redhat.com \
--cc=ben.horgan@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=error27@gmail.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox